Patch Detail
Show a patch.
GET /api/1.1/patches/161/?format=api
{ "id": 161, "url": "https://patchwork.libcamera.org/api/1.1/patches/161/?format=api", "web_url": "https://patchwork.libcamera.org/patch/161/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190107155427.10124-1-kieran.bingham@ideasonboard.com>", "date": "2019-01-07T15:54:27", "name": "[libcamera-devel] libcamera: media_object: Undef major/minor system macros", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "078179973168769448e15f9ac4193e313a499c74", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/161/mbox/", "series": [ { "id": 54, "url": "https://patchwork.libcamera.org/api/1.1/series/54/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=54", "date": "2019-01-07T15:54:27", "name": "[libcamera-devel] libcamera: media_object: Undef major/minor system macros", "version": 1, "mbox": "https://patchwork.libcamera.org/series/54/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/161/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/161/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1276C600CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Jan 2019 16:54:32 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64040E22;\n\tMon, 7 Jan 2019 16:54:31 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546876471;\n\tbh=VEQyNoE9xpTCIx8oPzNCtpmleNu5oGn1lPW2PhPM7Nk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=stR+8fZPdCSC54MRQf7L7CsgQnLg29oREPtVaQryvO52ZuNs+UB04rD2ZhrmwVCHp\n\t0wpHNyQNv44yXgcq1u9ziZb5ox1twRuvPvL9WehL0T9twb2QnpB8+NF+u3nm3CPkmN\n\t+K5aQ0QeYH5JsvmlHKAkVqr3NbQH1Y7JAnvrvQBE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Mon, 7 Jan 2019 15:54:27 +0000", "Message-Id": "<20190107155427.10124-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[libcamera-devel] [PATCH] libcamera: media_object: Undef\n\tmajor/minor system macros", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 07 Jan 2019 15:54:32 -0000" }, "content": "GCC 7.3.0 defines conflicting macros within <sys/types.h> which are\ndeprecated and removed in later versions.\n\nTo support compilation with this toolchain, ensure that any previous\ndefinition is removed before the class definitions.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/include/media_object.h | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/include/media_object.h b/src/libcamera/include/media_object.h\nindex 950a33286690..00772fd11234 100644\n--- a/src/libcamera/include/media_object.h\n+++ b/src/libcamera/include/media_object.h\n@@ -12,6 +12,15 @@\n \n #include <linux/media.h>\n \n+/*\n+ * In the GNU C Library, \"major\" and \"minor\" are defined by <sys/sysmacros.h>.\n+ * GCC 7.3.0 also defines this in <sys/types.h> for historical compatibility.\n+ * To prevent conflicting with the major() and minor() member functions we\n+ * unconditionally undef these here.\n+ */\n+#undef major\n+#undef minor\n+\n namespace libcamera {\n \n class MediaDevice;\n", "prefixes": [ "libcamera-devel" ] }