Patch Detail
Show a patch.
GET /api/1.1/patches/16075/?format=api
{ "id": 16075, "url": "https://patchwork.libcamera.org/api/1.1/patches/16075/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16075/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220527144447.94891-5-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-27T14:44:21", "name": "[libcamera-devel,v3,04/30] py: Fix SceneFlicker enum values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "302e350a9c92f4bfa0cd6889ed787bcec334c477", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16075/mbox/", "series": [ { "id": 3146, "url": "https://patchwork.libcamera.org/api/1.1/series/3146/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3146", "date": "2022-05-27T14:44:17", "name": "More misc Python patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3146/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16075/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16075/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42742C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B875D65642;\n\tFri, 27 May 2022 16:45:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D731633A4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:06 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CD3DD80;\n\tFri, 27 May 2022 16:45:06 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662712;\n\tbh=J82y7/1hXVMiwHUAH2A1Gwma14uw5Jc//aizDlp0V5U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rPZBgqhCP0yPMfhe4W/qodkHjl3Iw7TaLGAoc4jnsJvHKbpZ0FpUL5JEABDyjbp1w\n\tqPZX1WiCA3YBjjUNu2B1e4YMx+GCpi5bUkvuOtRcB3lLiyfOs0fNhkp2DSgC3yDUiO\n\t9h8SbnBAugdG6SqRZMjNBOsO5RJ0nbto+MNuPpbcoBa7VeqwTza/4JWnJ43HjTxsmr\n\tW9FYWYaqOdWri9n8GwPyTydHPVIUZjkR8iHlnH5QYnzT97ohF/Y06Gb0ygJo2WKD4B\n\tH1Ihtl4+oJKFTuihwzSDLD5A3WGJ39cQysFOdWWUXf8s3WA/8eBN0d7rsPu5JqWtWY\n\twiyOYdNs1H9ng==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662706;\n\tbh=J82y7/1hXVMiwHUAH2A1Gwma14uw5Jc//aizDlp0V5U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NJexn7jIz28GyRFzhNrihZBRpCdn1KKQJEKMFiECe3+6RBJSNuyeYQogtU53vZFAH\n\tZl886O3tsnae1KuBh/sTRY/qNClVMQkf0w3CoS1ztAqIyLoDn7GbDChZDTzigYYirR\n\tx/R05H8uG9+jk8PJZCAzrKBSF7qNGgPBftfinpO8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NJexn7jI\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 27 May 2022 17:44:21 +0300", "Message-Id": "<20220527144447.94891-5-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/30] py: Fix SceneFlicker enum values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Stripping 'SceneFlicker' prefix from the enum value names leads to\n'50Hz' and '60Hz', which are not valid names. So add another heuristics\nto keep the prefix for SceneFlicker.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/gen-py-control-enums.py | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/py/libcamera/gen-py-control-enums.py b/src/py/libcamera/gen-py-control-enums.py\nindex dcc28b1a..6b2b5362 100755\n--- a/src/py/libcamera/gen-py-control-enums.py\n+++ b/src/py/libcamera/gen-py-control-enums.py\n@@ -42,6 +42,9 @@ def generate_py(controls):\n \n if name == 'LensShadingMapMode':\n prefix = 'LensShadingMapMode'\n+ elif name == 'SceneFlicker':\n+ # If we strip the prefix, we would get '50Hz', which is illegal name\n+ prefix = ''\n else:\n prefix = find_common_prefix([e['name'] for e in enum])\n \n", "prefixes": [ "libcamera-devel", "v3", "04/30" ] }