Patch Detail
Show a patch.
GET /api/1.1/patches/16074/?format=api
{ "id": 16074, "url": "https://patchwork.libcamera.org/api/1.1/patches/16074/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16074/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220527144447.94891-4-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-27T14:44:20", "name": "[libcamera-devel,v3,03/30] py: cam: Cleanups", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "daa7d394cdc082b7aac828d781ab92ba3e2cc16c", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16074/mbox/", "series": [ { "id": 3146, "url": "https://patchwork.libcamera.org/api/1.1/series/3146/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3146", "date": "2022-05-27T14:44:17", "name": "More misc Python patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3146/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16074/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16074/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23CA6BD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F76965646;\n\tFri, 27 May 2022 16:45:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1476A633A4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:06 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8701DB90;\n\tFri, 27 May 2022 16:45:05 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662711;\n\tbh=1k1mDOSc0wrwJgkzRG4QBagJlYu2dfFoTeBMEZ7zPTw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VYxO9RFzsWSRcyCiqRMbHDCeE8zgAIgeSZS3UxCjMVoUi9ORgTTy80881fDXROsU9\n\tV5pY+6bZrF2z/0x/JWvFr78KQZqgRd6Rwznl7O3s3taa6NO5N758OdGN8F3c2h8xu6\n\tXdtFwk4ZHv78xd/I/eJZq/QxLSt80a4CC+u9E9/Vlk0cpxR3RpZkbC/yV6yMfuNwnL\n\tZ8eeGpZkkehqwVgDc4K/LwLy0iQYTCR52tawnM7NsMxCde0bP/2OQeFONc+6Gio22P\n\t5luWDrFn/nieQk+DXPn4gcYOy8lnl37d29F3bCHxKXhpvvAo6EobUNCN8i68qygAXT\n\tp4CCeCGgfvIxA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662705;\n\tbh=1k1mDOSc0wrwJgkzRG4QBagJlYu2dfFoTeBMEZ7zPTw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=j0olAdOecs6qmYraTXst/haPH/dMGH5ZjMrvWpyt5ww9AHBcBL+kcVEXRGXY2Pljm\n\tpFLQBWiD2BtjAFmXyuCz1NWmVzqry5HcROJqVMmZBxd5T6wz79NnSuTa0nwzzfRRWW\n\t55nrzOksmN0HWMNeFc4pAOgYdaXH83Udhz14ymJ0=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"j0olAdOe\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 27 May 2022 17:44:20 +0300", "Message-Id": "<20220527144447.94891-4-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 03/30] py: cam: Cleanups", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "No functional changes. Drop unused variables, reduce typechecker\nwarnings.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/cam/cam.py | 2 +-\n src/py/cam/cam_qt.py | 12 ++----------\n src/py/cam/cam_qtgl.py | 9 ++-------\n 3 files changed, 5 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 2f0690b5..e2bc78da 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -304,7 +304,7 @@ def event_handler(state):\n \n running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n return running\n- except Exception as e:\n+ except Exception:\n traceback.print_exc()\n return False\n \ndiff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\nindex 0a25a823..bff1175b 100644\n--- a/src/py/cam/cam_qt.py\n+++ b/src/py/cam/cam_qt.py\n@@ -184,12 +184,7 @@ class QtRenderer:\n windows = []\n \n for ctx in self.contexts:\n- camera = ctx['camera']\n-\n for stream in ctx['streams']:\n- fmt = stream.configuration.pixel_format\n- size = stream.configuration.size\n-\n window = MainWindow(ctx, stream)\n window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n window.show()\n@@ -199,10 +194,10 @@ class QtRenderer:\n \n def run(self):\n camnotif = QtCore.QSocketNotifier(self.cm.efd, QtCore.QSocketNotifier.Read)\n- camnotif.activated.connect(lambda x: self.readcam())\n+ camnotif.activated.connect(lambda _: self.readcam())\n \n keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\n- keynotif.activated.connect(lambda x: self.readkey())\n+ keynotif.activated.connect(lambda _: self.readkey())\n \n print('Capturing...')\n \n@@ -292,9 +287,6 @@ class MainWindow(QtWidgets.QWidget):\n def buf_to_qpixmap(self, stream, fb):\n with fb.mmap() as mfb:\n cfg = stream.configuration\n- w = cfg.size.width\n- h = cfg.size.height\n- pitch = cfg.stride\n \n if cfg.pixel_format == libcam.formats.MJPEG:\n img = Image.open(BytesIO(mfb.planes[0]))\ndiff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\nindex 4bbcda6c..3fb7dde3 100644\n--- a/src/py/cam/cam_qtgl.py\n+++ b/src/py/cam/cam_qtgl.py\n@@ -5,16 +5,11 @@ from PyQt5 import QtCore, QtWidgets\n from PyQt5.QtCore import Qt\n \n import math\n-import numpy as np\n import os\n import sys\n \n os.environ['PYOPENGL_PLATFORM'] = 'egl'\n \n-import OpenGL\n-# OpenGL.FULL_LOGGING = True\n-\n-from OpenGL import GL as gl\n from OpenGL.EGL.EXT.image_dma_buf_import import *\n from OpenGL.EGL.KHR.image import *\n from OpenGL.EGL.VERSION.EGL_1_0 import *\n@@ -149,10 +144,10 @@ class QtRenderer:\n \n def run(self):\n camnotif = QtCore.QSocketNotifier(self.state['cm'].efd, QtCore.QSocketNotifier.Read)\n- camnotif.activated.connect(lambda x: self.readcam())\n+ camnotif.activated.connect(lambda _: self.readcam())\n \n keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\n- keynotif.activated.connect(lambda x: self.readkey())\n+ keynotif.activated.connect(lambda _: self.readkey())\n \n print('Capturing...')\n \n", "prefixes": [ "libcamera-devel", "v3", "03/30" ] }