Patch Detail
Show a patch.
GET /api/1.1/patches/16051/?format=api
{ "id": 16051, "url": "https://patchwork.libcamera.org/api/1.1/patches/16051/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16051/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220526082737.1081262-3-chenghaoyang@google.com>", "date": "2022-05-26T08:27:30", "name": "[libcamera-devel,v2,2/9] ipu3: Allow only one camera being started", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e1463f6c510223438abaf29af07d433c49b1a626", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16051/mbox/", "series": [ { "id": 3141, "url": "https://patchwork.libcamera.org/api/1.1/series/3141/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3141", "date": "2022-05-26T08:27:28", "name": "Use two imgus in ipu3 pipeline handler", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3141/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16051/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16051/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2A30C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 May 2022 08:27:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B322B65667;\n\tThu, 26 May 2022 10:27:52 +0200 (CEST)", "from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3B956565D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 May 2022 10:27:49 +0200 (CEST)", "by mail-pj1-x102b.google.com with SMTP id\n\tq92-20020a17090a17e500b001e0817e77f6so3794171pja.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 May 2022 01:27:49 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(21.160.199.104.bc.googleusercontent.com. [104.199.160.21])\n\tby smtp.gmail.com with ESMTPSA id\n\tm2-20020a170902bb8200b0016191b843e2sm834429pls.235.2022.05.26.01.27.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 May 2022 01:27:47 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653553672;\n\tbh=ABgfGQ/ElEe+i40usmKjEuyVAwo8ycwZk/ueid1QkgM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=b9jE1JjQeboIMNO0JPSLQp7RW1lcpqL3aabEVfxBSCL/3P/g/XoQLq0bC0y1FY5qM\n\tdR2del/f2mVL18hmBFADxwQ8v70mLiFKRMQVMj7SPHTWOjc45to59xf0Hrjo1NUiAu\n\tWdFGg/0wg/CoLsagfhVMa5zXOTc872EHokF2lD0WQjbdfp3LKxYnB9NwGjp9c/1rDu\n\tCuvM1CJdtwdpO1B9ZCpxJ15Yjap2Nn4eqGeQN0uPhsse5jICCbHxm/T+WXQ65RnsSS\n\tHfe5RvUSVIrZHhmPNoOzRAHGD8zdm39nnJSCFSSJXlVoOSGK3fvX0TDweZZnI0OlMJ\n\thRkaMqpYMH+dw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=7I54rMUuKWDVxcfwPnpOucKfcZsO9xgIQyAJBV3cSkg=;\n\tb=bD5sbJi7RkPAsAQFopJH4ay0kCF/jrITjA7NGbp5GT0uJ61av5xtflEy4SUIwsmLDB\n\tMmWPT9zPQ7sbq4VCXrrZxatvL1vKtqkWQ1Af4JYXfpdBEU+yP6//tarmv+G2uUa/WtAM\n\t+wU8AvCEwgjQ/JBp739SkCY9NRw5MBNdqRutg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"bD5sbJi7\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=7I54rMUuKWDVxcfwPnpOucKfcZsO9xgIQyAJBV3cSkg=;\n\tb=mwV5le7wvFeNNxr7Q8ZJHedwYqeVtMGsrEMIhnPjvnB+Oh06hFs92xZFSRDAoRCXpZ\n\tehKoquDuvbnLXG/1vZv67oy5rKLx4WcmCJBexGnm54UlYgPDotrK6X8NIviXAH2hzcvp\n\tzwBMp4JYZZF7Qg5hu0HDUt4JAE4GoYny0WEGyHvS4U4CaMFaHJjO3fqHCmUKWxQO0Xg2\n\tZkq2mh2VtW1gLxMKDZmpWDxyQFG6zTvrRtMCp3O8BcOoABYNe1iyFqjL480aAR8VRm19\n\tfef6aBIetzyiLOLTPCbLZMRuEDqCpU1UZq7+cenzLh8IYLxgmd+vtDSp0v1rS0Fz0Kiz\n\tvDKg==", "X-Gm-Message-State": "AOAM531okNrWc50NjntFY4BIGhia2TU5PY8iMcN+avZ3c1t3tSW+j6vY\n\t0mlb0dzPv+jDz7xFsVeJguBHmwVL6vTrXgRi", "X-Google-Smtp-Source": "ABdhPJxPbTlPe1zKARFtM+3NQx+s/mN/GqEzY9GZJMTtwvb5sP3LEv/mdXYkHQC21ZU9MrGcniqcjw==", "X-Received": "by 2002:a17:90b:1095:b0:1e0:ccaa:e5f0 with SMTP id\n\tgj21-20020a17090b109500b001e0ccaae5f0mr1432742pjb.198.1653553667863; \n\tThu, 26 May 2022 01:27:47 -0700 (PDT)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 May 2022 08:27:30 +0000", "Message-Id": "<20220526082737.1081262-3-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.36.1.124.g0e6072fb45-goog", "In-Reply-To": "<20220526082737.1081262-1-chenghaoyang@google.com>", "References": "<20220526082737.1081262-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/9] ipu3: Allow only one camera being\n\tstarted", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nAs we hardly have use cases/applications that need both cameras at the\nsame time, this patch adds a rule that only one camera can be started\none time. This also allows the following patches that use both imgus to\nprocess frames from one single camera.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex fd989e61..c943ee6a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -166,6 +166,8 @@ private:\n \tMediaDevice *cio2MediaDev_;\n \tMediaDevice *imguMediaDev_;\n \n+\tCamera *inUseCamera_ = nullptr;\n+\n \tstd::vector<IPABuffer> ipaBuffers_;\n };\n \n@@ -765,6 +767,14 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)\n \n int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlList *controls)\n {\n+\t/*\n+\t * Enforce that only a single camera can be used at a time to use both\n+\t * ImgUs on the camera, so that StillCapture stream can adopt another\n+\t * set of configuration.\n+\t */\n+\tif (inUseCamera_ && inUseCamera_ != camera)\n+\t\treturn -EBUSY;\n+\n \tIPU3CameraData *data = cameraData(camera);\n \tCIO2Device *cio2 = &data->cio2_;\n \tImgUDevice *imgu = data->imgu_;\n@@ -781,6 +791,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \tif (ret)\n \t\treturn ret;\n \n+\tinUseCamera_ = camera;\n+\n \tret = data->ipa_->start();\n \tif (ret)\n \t\tgoto error;\n@@ -808,6 +820,8 @@ error:\n \tfreeBuffers(camera);\n \tLOG(IPU3, Error) << \"Failed to start camera \" << camera->id();\n \n+\tinUseCamera_ = nullptr;\n+\n \treturn ret;\n }\n \n@@ -826,6 +840,8 @@ void PipelineHandlerIPU3::stopDevice(Camera *camera)\n \t\tLOG(IPU3, Warning) << \"Failed to stop camera \" << camera->id();\n \n \tfreeBuffers(camera);\n+\n+\tinUseCamera_ = nullptr;\n }\n \n void IPU3CameraData::cancelPendingRequests()\n", "prefixes": [ "libcamera-devel", "v2", "2/9" ] }