Patch Detail
Show a patch.
GET /api/1.1/patches/16040/?format=api
{ "id": 16040, "url": "https://patchwork.libcamera.org/api/1.1/patches/16040/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16040/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220525102533.32052-1-laurent.pinchart@ideasonboard.com>", "date": "2022-05-25T10:25:33", "name": "[libcamera-devel] libcamera: ipa: Move IPA control serialization structures to libcamera namespace", "commit_ref": "c3515cf6e57bf4016f84c1228f26bf7dc69027e1", "pull_url": null, "state": "accepted", "archived": false, "hash": "f95cfb2bcc4985bc89e9a39ef637e435fa8e460f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16040/mbox/", "series": [ { "id": 3137, "url": "https://patchwork.libcamera.org/api/1.1/series/3137/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3137", "date": "2022-05-25T10:25:33", "name": "[libcamera-devel] libcamera: ipa: Move IPA control serialization structures to libcamera namespace", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3137/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16040/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16040/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D396EBD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 May 2022 10:25:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 144EA65661;\n\tWed, 25 May 2022 12:25:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABCA660429\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 May 2022 12:25:41 +0200 (CEST)", "from pendragon.ideasonboard.com (unknown [141.113.67.45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E18D59D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 May 2022 12:25:41 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653474344;\n\tbh=u1+GHvh8H7c41+BilbK5KJIwBAkR2y64xmqgEZFcUFg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=LnxHJrU81jaLZfz32Hnhi0d23m3KL6YBXC1m0zlEk/5PNHR6ItQBWYb/GSWY8RMZI\n\tG6mJ5yQ4bykDTf7ebxL6ZpdgzSz9EZrdrNrexXHWNGt4jkHLhNrqIdgSr/lwr02EFT\n\tjDFkR2ZwSfQL9J+EcCYn2YuXyWSxFDIthlKFSNrAvPSBG/VxbZJBWNKY5adUgdXquS\n\tGJ8XV0C3U/Ia5NMFUqRz7tOUcpUuvssA2sCqJZspF3WSulAlSckKp+3Hh/k0aGIDh+\n\thabR4yP2R6LbSCiO9xnVsCpdQLB5tXlsTwmSVjfgshFTOd3uP/Zn1HcsMQWwKSyHTx\n\tEgXR1+0w0BD6Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653474341;\n\tbh=u1+GHvh8H7c41+BilbK5KJIwBAkR2y64xmqgEZFcUFg=;\n\th=From:To:Subject:Date:From;\n\tb=LrRbVzcH+F2tgZfb0rnvkdOQljsRLMHFym1fl8GIPmvkk5Y6jAam8/nEhtW4huXGm\n\tL9Cq7nG0AkZ7IkTQyUQIaKs7/mF3OjHjU+xig05Mwh2kjvXMYaM3P9AS97AMHMHhnU\n\tI5dYUfbNnVb7PvFw+gXE+lxTpQ2rIXIdcYX6C7OI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LrRbVzcH\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 25 May 2022 13:25:33 +0300", "Message-Id": "<20220525102533.32052-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: ipa: Move IPA control\n\tserialization structures to libcamera namespace", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The C structures used to serialize controls are currently defined in the\nroot namespace, which places them at the root level in the class list\ngenerated by Doxygen. Move them to the libcamera namespace to fix that.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/ipa/ipa_controls.h | 4 ++++\n src/libcamera/ipa_controls.cpp | 4 ++++\n 2 files changed, 8 insertions(+)\n\n\nbase-commit: 3e7f54a3128d8143afb200d626d3b208d493623a", "diff": "diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\nindex da1a759618e0..e5da1946ce1d 100644\n--- a/include/libcamera/ipa/ipa_controls.h\n+++ b/include/libcamera/ipa/ipa_controls.h\n@@ -10,6 +10,8 @@\n #include <stdint.h>\n \n #ifdef __cplusplus\n+namespace libcamera {\n+\n extern \"C\" {\n #endif\n \n@@ -48,5 +50,7 @@ struct ipa_control_info_entry {\n };\n \n #ifdef __cplusplus\n+} /* namespace libcamera */\n+\n }\n #endif\ndiff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\nindex c3489bbff646..870a443b0f38 100644\n--- a/src/libcamera/ipa_controls.cpp\n+++ b/src/libcamera/ipa_controls.cpp\n@@ -131,6 +131,8 @@\n * shall be ignored when parsing the packet.\n */\n \n+namespace libcamera {\n+\n /**\n * \\def IPA_CONTROLS_FORMAT_VERSION\n * \\brief The current control serialization format version\n@@ -224,3 +226,5 @@ static_assert(sizeof(ipa_control_value_entry) == 16,\n \n static_assert(sizeof(ipa_control_info_entry) == 16,\n \t \"Invalid ABI size change for struct ipa_control_info_entry\");\n+\n+} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel" ] }