Patch Detail
Show a patch.
GET /api/1.1/patches/16023/?format=api
{ "id": 16023, "url": "https://patchwork.libcamera.org/api/1.1/patches/16023/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16023/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220524114610.41848-18-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-24T11:46:08", "name": "[libcamera-devel,v2,17/19] py: Rename 'efd' to 'event_fd'", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4b4467adc451625a16b6b8a49a7533942217927a", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16023/mbox/", "series": [ { "id": 3134, "url": "https://patchwork.libcamera.org/api/1.1/series/3134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3134", "date": "2022-05-24T11:45:51", "name": "More misc Python patches", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16023/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16023/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51049C3276\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 May 2022 11:46:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79A256568B;\n\tTue, 24 May 2022 13:46:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1180065685\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 May 2022 13:46:39 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 642304A8;\n\tTue, 24 May 2022 13:46:38 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653392814;\n\tbh=Is73O9BqX93oyE9wi7SihC8QIUCguU6UCufvnn/heN8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rh+2VN9+byow/PJszN2s4rUfZXdgNUs7ghMM4fS/fx2G0llj5biP6Flb5uEfHgq7R\n\t/Tsh5bOkl8/4gs4drEiyG9hdEfjZt0HfH+RL4LQ6bKPmxRtA1sCdYhwu6vDhi1sm6R\n\t+F84pDv3IStRp+MI2STsm+fMgEhagqOg6xE8Nm6cJu1ROcKHl9SryRLLvs9Hys4kSj\n\tQeTeWo3Lpa+RGV+t6KfixaVg6IS25qVIkpsa7wHwkA5LIt3DZRS+AcKwUZ9wPrOlO+\n\tmGkYVhP5CEUMv5O1VcIcDGwCaJe0MB/Kp/PTyLlGgVh2J/hnU8De6jyHpwo2mNNmju\n\tdKb5OGeDalqPg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653392798;\n\tbh=Is73O9BqX93oyE9wi7SihC8QIUCguU6UCufvnn/heN8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UnAn880UduCX0ei70d3ZVAFTdGVwKPQuBMhR/1lM432bzBuojz3uThJNW8LzCoQ40\n\tDzr6Z4+t3ojmN61RFaD/7cn5nxxvDV/yEiyIm7AFs7D8i1zWqXLViM5xdEhDsFsgXi\n\t0OIGw10ah3DfigKHaC0D33BiRgH/dMmV6PgCD0Rw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UnAn880U\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 24 May 2022 14:46:08 +0300", "Message-Id": "<20220524114610.41848-18-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 17/19] py: Rename 'efd' to 'event_fd'", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n\nPerhaps it's better to have a more descriptive name here. I also\nconsidered just renaming 'efd' to 'fd', but 'event_fd' won.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/cam/cam_kms.py | 2 +-\n src/py/cam/cam_null.py | 2 +-\n src/py/cam/cam_qt.py | 2 +-\n src/py/cam/cam_qtgl.py | 2 +-\n src/py/examples/itest.py | 2 +-\n src/py/examples/simple-continuous-capture.py | 2 +-\n src/py/libcamera/py_main.cpp | 2 +-\n test/py/unittests.py | 2 +-\n 8 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\nindex 213e0b03..49b00211 100644\n--- a/src/py/cam/cam_kms.py\n+++ b/src/py/cam/cam_kms.py\n@@ -161,7 +161,7 @@ class KMSRenderer:\n \n sel = selectors.DefaultSelector()\n sel.register(self.card.fd, selectors.EVENT_READ, self.readdrm)\n- sel.register(self.cm.efd, selectors.EVENT_READ, self.readcam)\n+ sel.register(self.cm.event_fd, selectors.EVENT_READ, self.readcam)\n sel.register(sys.stdin, selectors.EVENT_READ, self.readkey)\n \n print('Press enter to exit')\ndiff --git a/src/py/cam/cam_null.py b/src/py/cam/cam_null.py\nindex 45c5f467..40dbd266 100644\n--- a/src/py/cam/cam_null.py\n+++ b/src/py/cam/cam_null.py\n@@ -23,7 +23,7 @@ class NullRenderer:\n self.running = True\n \n sel = selectors.DefaultSelector()\n- sel.register(self.cm.efd, selectors.EVENT_READ, self.readcam)\n+ sel.register(self.cm.event_fd, selectors.EVENT_READ, self.readcam)\n sel.register(sys.stdin, selectors.EVENT_READ, self.readkey)\n \n print('Press enter to exit')\ndiff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\nindex 739e9749..d8d6a98f 100644\n--- a/src/py/cam/cam_qt.py\n+++ b/src/py/cam/cam_qt.py\n@@ -193,7 +193,7 @@ class QtRenderer:\n self.windows = windows\n \n def run(self):\n- camnotif = QtCore.QSocketNotifier(self.cm.efd, QtCore.QSocketNotifier.Read)\n+ camnotif = QtCore.QSocketNotifier(self.cm.event_fd, QtCore.QSocketNotifier.Read)\n camnotif.activated.connect(lambda _: self.readcam())\n \n keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\ndiff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\nindex 5f7ccf1e..4b43f51d 100644\n--- a/src/py/cam/cam_qtgl.py\n+++ b/src/py/cam/cam_qtgl.py\n@@ -142,7 +142,7 @@ class QtRenderer:\n self.window = window\n \n def run(self):\n- camnotif = QtCore.QSocketNotifier(self.state.cm.efd, QtCore.QSocketNotifier.Read)\n+ camnotif = QtCore.QSocketNotifier(self.state.cm.event_fd, QtCore.QSocketNotifier.Read)\n camnotif.activated.connect(lambda _: self.readcam())\n \n keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\ndiff --git a/src/py/examples/itest.py b/src/py/examples/itest.py\nindex 01e020e2..2d1c6453 100755\n--- a/src/py/examples/itest.py\n+++ b/src/py/examples/itest.py\n@@ -66,7 +66,7 @@ def capture(ctx):\n # Use Selector to wait for events from the camera and from the keyboard\n \n sel = selectors.DefaultSelector()\n- sel.register(cm.efd, selectors.EVENT_READ, lambda fd: handle_camera_event(ctx))\n+ sel.register(cm.event_fd, selectors.EVENT_READ, lambda fd: handle_camera_event(ctx))\n \n reqs = []\n \ndiff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py\nindex 05fa2ada..12708914 100755\n--- a/src/py/examples/simple-continuous-capture.py\n+++ b/src/py/examples/simple-continuous-capture.py\n@@ -76,7 +76,7 @@ def capture(cm, cam, reqs):\n # Use Selector to wait for events from the camera and from the keyboard\n \n sel = selectors.DefaultSelector()\n- sel.register(cm.efd, selectors.EVENT_READ, lambda fd: handle_camera_event(cm, cam))\n+ sel.register(cm.event_fd, selectors.EVENT_READ, lambda fd: handle_camera_event(cm, cam))\n sel.register(sys.stdin, selectors.EVENT_READ, handle_key_envet)\n \n reqs = []\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 80f26c12..3fd5c0fc 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -209,7 +209,7 @@ PYBIND11_MODULE(_libcamera, m)\n \n \t\t.def_property_readonly(\"version\", &CameraManager::version)\n \n-\t\t.def_property_readonly(\"efd\", [](CameraManager &) {\n+\t\t.def_property_readonly(\"event_fd\", [](CameraManager &) {\n \t\t\treturn gEventfd;\n \t\t})\n \ndiff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 8c445bc9..426efb06 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -269,7 +269,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n gc.collect()\n \n sel = selectors.DefaultSelector()\n- sel.register(cm.efd, selectors.EVENT_READ)\n+ sel.register(cm.event_fd, selectors.EVENT_READ)\n \n reqs = []\n \n", "prefixes": [ "libcamera-devel", "v2", "17/19" ] }