Patch Detail
Show a patch.
GET /api/1.1/patches/16011/?format=api
{ "id": 16011, "url": "https://patchwork.libcamera.org/api/1.1/patches/16011/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16011/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220524114610.41848-6-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-24T11:45:56", "name": "[libcamera-devel,v2,05/19] py: Fix None value in ControlType enum", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9441ebe2a9791898cb2095d0596d6d2f9813a14c", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16011/mbox/", "series": [ { "id": 3134, "url": "https://patchwork.libcamera.org/api/1.1/series/3134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3134", "date": "2022-05-24T11:45:51", "name": "More misc Python patches", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16011/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16011/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23B72BD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 May 2022 11:46:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFD1A65660;\n\tTue, 24 May 2022 13:46:38 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B3766566C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 May 2022 13:46:32 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07048BC1;\n\tTue, 24 May 2022 13:46:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653392798;\n\tbh=gB8wORxbh5RCxUzoZ/j9CClyLL96wF3CiB0KpQy77Fw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=V1AacIKbwAujd4/H/eUT3tshusoR3ClwPZMO8wr0kuU1lRV1EH93HP8gFjOHR7i6M\n\tu7uTPld6om+8fVc/xyBoWVAqNyTH2HaYBCGd/uTkoIVJtnAGNOUfrPMkjfwdpnQrzO\n\t/GNtXaJSnNoKdavD6fViGmkEHmaYHuWVd6zrDicvzRhSVpWN2Kbm3BMrbAmJWP3RFK\n\tQ9Z9BXVKycTN+O8+dg8mC1ldkBi0T5HHSv18qKf3TLd+PvN/kgE2TVD3XtAlS1H7Wm\n\tB6hYiZBUbOYfQhgPk81gTVIT8lA8SoU868cAKKN29yk0kUx/PMq5QpIem2t36CPepo\n\t/lUnUt2eDZT8A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653392792;\n\tbh=gB8wORxbh5RCxUzoZ/j9CClyLL96wF3CiB0KpQy77Fw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fNmyUsf2M/bJNsNcDq9IMwOoIKZNhS1ImkTsP6ZyzsPSoGyoJDJvbgmM6mN+CQ8nB\n\tDHHE7+mrZ4ut29N70SWjVloJ9cEw0z9RU2ZntvMovEI8vcWu2jdSTMem8sk1w2kIux\n\tdNUwTh2pL5rjDzzf4bEmsjiPLihrmNbITQaGj31I=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fNmyUsf2\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 24 May 2022 14:45:56 +0300", "Message-Id": "<20220524114610.41848-6-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 05/19] py: Fix None value in\n\tControlType enum", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "\"None\" is not a valid name for an enum value, so change it to \"Null\".\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/py_enums.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/py_enums.cpp b/src/py/libcamera/py_enums.cpp\nindex e55318f1..96d4beef 100644\n--- a/src/py/libcamera/py_enums.cpp\n+++ b/src/py/libcamera/py_enums.cpp\n@@ -22,7 +22,7 @@ void init_py_enums(py::module &m)\n \t\t.value(\"Viewfinder\", StreamRole::Viewfinder);\n \n \tpy::enum_<ControlType>(m, \"ControlType\")\n-\t\t.value(\"None\", ControlType::ControlTypeNone)\n+\t\t.value(\"Null\", ControlType::ControlTypeNone)\n \t\t.value(\"Bool\", ControlType::ControlTypeBool)\n \t\t.value(\"Byte\", ControlType::ControlTypeByte)\n \t\t.value(\"Integer32\", ControlType::ControlTypeInteger32)\n", "prefixes": [ "libcamera-devel", "v2", "05/19" ] }