Patch Detail
Show a patch.
GET /api/1.1/patches/15981/?format=api
{ "id": 15981, "url": "https://patchwork.libcamera.org/api/1.1/patches/15981/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15981/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220519070620.10373-2-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-19T07:06:20", "name": "[libcamera-devel,v2,2/2] libcamera: formats: add missing RGBX8888 info", "commit_ref": "4a7e5d3b8b1be4d8e9bbb00eaf00266f8c0aea9d", "pull_url": null, "state": "accepted", "archived": false, "hash": "2a512366d7abb07d7b97395164d422e6a0da4702", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15981/mbox/", "series": [ { "id": 3126, "url": "https://patchwork.libcamera.org/api/1.1/series/3126/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3126", "date": "2022-05-19T07:06:19", "name": "[libcamera-devel,v2,1/2] libcamera: formats: fix warning print", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3126/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15981/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15981/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27F95C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 May 2022 07:06:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B763E65665;\n\tThu, 19 May 2022 09:06:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04E4C65654\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 May 2022 09:06:40 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 592C1E52;\n\tThu, 19 May 2022 09:06:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652944001;\n\tbh=mTdu1+ei9OhIYZLKbXebF9syI9RmnoGl1j/9hTaBeDc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nvionCcl9mUeP34i7dj5tsS4z3wRtZTazT1i8hk4NLDkNuxcFYt7ytkY0Wf+oYgWQ\n\td8I8pw7DN36dpHivFS/75JlCNFPyzsJ0tmXtl9sil72E6J481VbzXItYhm/kKIz0i4\n\tpuPUqIJKddG2jRstobio735kGCrfr67nIqUXrDB7secCuj09c8VBJLoOfqkVym5AQF\n\tPmn7Dv+AUoUsqMY6sK9nzkJUMjBLFCiK1FWZojmqy0FJJEgv+oeYafqu2xs7adZQG6\n\tp/G4Cth60rw0dU6Jqnccerc7Y75DEmi40+wsixtxZzFK6/L6Quz67shZqRuLXVTi0I\n\tTgvnFVtt1k/IA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652943999;\n\tbh=mTdu1+ei9OhIYZLKbXebF9syI9RmnoGl1j/9hTaBeDc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bymuVJd1NpN7lSr0hBqTioRDZhLcDGf/HW7fvQnCK03z5P+9fKOTU/bITxbeMps5q\n\tdHqsK2P8DY+pCk759HEj/VfSsOhT/KhDDi01cVN3WjzmJi8Yreg/1uTPQxKYm+24xj\n\tbymytxEpmwObujL3pHGT9ACVbp2x9a0PnE/K13Lk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bymuVJd1\"; dkim-atps=neutral", "To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Date": "Thu, 19 May 2022 10:06:20 +0300", "Message-Id": "<20220519070620.10373-2-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220519070620.10373-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220519070620.10373-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] libcamera: formats: add missing\n\tRGBX8888 info", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add missing RGBX8888 PixelFormatInfo.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n\nChanges to v1:\n* Fixed the wrong v4l2 format\n* Added entry to v4l2_pixelformat.cpp\n\n src/libcamera/formats.cpp | 13 +++++++++++++\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 3e60ec7d..a4f27cd4 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -231,6 +231,19 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::RGBX8888, {\n+\t\t.name = \"RGBX8888\",\n+\t\t.format = formats::RGBX8888,\n+\t\t.v4l2Formats = {\n+\t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_BGRX32),\n+\t\t\t.multi = V4L2PixelFormat(),\n+\t\t},\n+\t\t.bitsPerPixel = 32,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::BGRX8888, {\n \t\t.name = \"BGRX8888\",\n \t\t.format = formats::BGRX8888,\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 1dd93baa..0b980a97 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -61,6 +61,8 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{\n \t\t{ formats::BGRX8888, \"32-bit XRGB 8-8-8-8\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n \t\t{ formats::XBGR8888, \"32-bit RGBX 8-8-8-8\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_BGRX32),\n+\t\t{ formats::RGBX8888, \"32-bit XBGR 8-8-8-8\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32),\n \t\t{ formats::ABGR8888, \"32-bit RGBA 8-8-8-8\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32),\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }