Patch Detail
Show a patch.
GET /api/1.1/patches/15967/?format=api
{ "id": 15967, "url": "https://patchwork.libcamera.org/api/1.1/patches/15967/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15967/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220518131329.66994-17-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-18T13:13:27", "name": "[libcamera-devel,v3,16/18] py: clean up control enums generation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "818796486683e1763222b5571979e7d06813586a", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15967/mbox/", "series": [ { "id": 3122, "url": "https://patchwork.libcamera.org/api/1.1/series/3122/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3122", "date": "2022-05-18T13:13:11", "name": "Misc Python bindings patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3122/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15967/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15967/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DA2BC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 13:14:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0ED1865671;\n\tWed, 18 May 2022 15:14:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9949B65678\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 May 2022 15:13:54 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1623D3297;\n\tWed, 18 May 2022 15:13:54 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652879651;\n\tbh=BFl081IYvSgCzhZfDzo328VBEKwa3VfS1UaR2JghE1g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tyYkEtkLgLBzk9HbufPWtNA0bGF+RK7sdc4r7bL+d2f19ZMTwspotpdo0L7LpP7/X\n\tjuJ+uDaC7sQb5Zp1MClHLZiAOHzlMUJfSYdMNEzhty4KQdML72SMp7Cu0ylzuAm0b8\n\t/jh8km1HKEfSpwEDQSCDsQOrRoYzHHeCq3MBJO4SxiFe8QGItxfX/q3+i6ug5iZDbT\n\tnG3pWcT5RLrT33DGEBmZhNW/RUabfzZ5ppfdQbhJKXrefn/R8iBhYTiW6TF1P0ghSU\n\treIR0VQ3AvdBurfBEUaqnIyCmeBBNIH6bCmFWxG2yOtKRpXbJGJA+Q9Bv3vDi33bLy\n\tvL1T+D7Sk0POQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652879634;\n\tbh=BFl081IYvSgCzhZfDzo328VBEKwa3VfS1UaR2JghE1g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tRhFMcy6y1WxlOaWdDZaA3pMmYV+1Nzn/m3ktW80JaUvOr6Q/jMOwID3h2FBj7fYi\n\tAhjGWdff9Pg2dEkBt3bx06X9Clf4gccXwOLGzdNju+NkcxtpHf8tlQ8SvbdwHPAYGV\n\tz+cIqeY2AEOoSbEbqLatcw2epwCll9ZR/qxdacsg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tRhFMcy6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Wed, 18 May 2022 16:13:27 +0300", "Message-Id": "<20220518131329.66994-17-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 16/18] py: clean up control enums\n\tgeneration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Try to be more consistent with the names, and include \"control\" in all\nthe names.\n\nAlso drop a useless \"using namespace libcamera\" and only include\n\"control_ids.h\".\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/libcamera/meson.build | 12 +++++-------\n ...ated.cpp.in => py_control_enums_generated.cpp.in} | 8 +++-----\n src/py/libcamera/py_main.cpp | 4 ++--\n 3 files changed, 10 insertions(+), 14 deletions(-)\n rename src/py/libcamera/{py_enums_generated.cpp.in => py_control_enums_generated.cpp.in} (63%)", "diff": "diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 55957252..a3388c63 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -18,20 +18,18 @@ pycamera_sources = files([\n 'py_main.cpp',\n ])\n \n-gen_input_files = files([\n+gen_py_control_enums_input_files = files([\n '../../libcamera/control_ids.yaml',\n- 'py_enums_generated.cpp.in',\n+ 'py_control_enums_generated.cpp.in',\n ])\n \n gen_py_control_enums = files('gen-py-control-enums.py')\n \n-generated_sources = custom_target('py_gen_controls',\n- input : gen_input_files,\n- output : ['py_enums_generated.cpp'],\n+pycamera_sources += custom_target('py_gen_controls',\n+ input : gen_py_control_enums_input_files,\n+ output : ['py_control_enums_generated.cpp'],\n command : [gen_py_control_enums, '-o', '@OUTPUT@', '@INPUT@'])\n \n-pycamera_sources += generated_sources\n-\n pycamera_deps = [\n libcamera_public,\n py3_dep,\ndiff --git a/src/py/libcamera/py_enums_generated.cpp.in b/src/py/libcamera/py_control_enums_generated.cpp.in\nsimilarity index 63%\nrename from src/py/libcamera/py_enums_generated.cpp.in\nrename to src/py/libcamera/py_control_enums_generated.cpp.in\nindex 20e07528..ed81fbe7 100644\n--- a/src/py/libcamera/py_enums_generated.cpp.in\n+++ b/src/py/libcamera/py_control_enums_generated.cpp.in\n@@ -2,20 +2,18 @@\n /*\n * Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n *\n- * Python bindings - Auto-generated enums\n+ * Python bindings - Auto-generated control enums\n *\n * This file is auto-generated. Do not edit.\n */\n \n-#include <libcamera/libcamera.h>\n+#include <libcamera/control_ids.h>\n \n #include <pybind11/smart_holder.h>\n \n namespace py = pybind11;\n \n-using namespace libcamera;\n-\n-void init_py_enums_generated(py::module& m)\n+void init_py_control_enums_generated(py::module& m)\n {\n ${enums}\n }\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex b05bbb22..1d941160 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -131,13 +131,13 @@ static void handleRequestCompleted(Request *req)\n }\n \n void init_py_enums(py::module &m);\n-void init_py_enums_generated(py::module &m);\n+void init_py_control_enums_generated(py::module &m);\n void init_py_geometry(py::module &m);\n \n PYBIND11_MODULE(_libcamera, m)\n {\n \tinit_py_enums(m);\n-\tinit_py_enums_generated(m);\n+\tinit_py_control_enums_generated(m);\n \tinit_py_geometry(m);\n \n \t/* Forward declarations */\n", "prefixes": [ "libcamera-devel", "v3", "16/18" ] }