Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1596,
    "url": "https://patchwork.libcamera.org/api/1.1/patches/1596/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/1596/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20190703135825.32353-1-paul.elder@ideasonboard.com>",
    "date": "2019-07-03T13:58:25",
    "name": "[libcamera-devel,v3] libcamera: ipa_module: add path to module loading error message",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "bb29d60d27fe081f04b7eb63ef5637bd19a42f51",
    "submitter": {
        "id": 17,
        "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api",
        "name": "Paul Elder",
        "email": "paul.elder@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/1596/mbox/",
    "series": [
        {
            "id": 393,
            "url": "https://patchwork.libcamera.org/api/1.1/series/393/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=393",
            "date": "2019-07-03T13:58:25",
            "name": "[libcamera-devel,v3] libcamera: ipa_module: add path to module loading error message",
            "version": 3,
            "mbox": "https://patchwork.libcamera.org/series/393/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/1596/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/1596/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<paul.elder@ideasonboard.com>",
        "Received": [
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A428A60C23\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Jul 2019 15:58:35 +0200 (CEST)",
            "from neptunite.flets-east.jp\n\t(p1871204-ipngn14001hodogaya.kanagawa.ocn.ne.jp [153.220.127.204])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA30C24B;\n\tWed,  3 Jul 2019 15:58:33 +0200 (CEST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562162315;\n\tbh=vWaJvWcuirzfs4QRRFRw4+ZJz2TV5jj95bgtgqki0rI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=EFBPMqdybbi5UUosLDh9y02KOx3gExnaFJnvMltCz9Y+3uM1w0AfVqzcrI8gSC454\n\thul41JqQ09+JaHqBnn+hQRiIvkmJV1w5z6mZZ1krfP6SAGpHzkozYduq5cUIicpuWf\n\tRGGxr/zaZnwxNw/9WRIFrUavulFBef2908+brC+4=",
        "From": "Paul Elder <paul.elder@ideasonboard.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Wed,  3 Jul 2019 22:58:25 +0900",
        "Message-Id": "<20190703135825.32353-1-paul.elder@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.20.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to\n\tmodule loading error message",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.23",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Wed, 03 Jul 2019 13:58:35 -0000"
    },
    "content": "Add an error message to tell, if an IPA module failed to load, the\npath to the IPA module shared object that was attempted to be loaded.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nChanges in v3:\n- error message wording change\n- moved to under the close: label\n\nChanges in v2: don't show module version\n\n src/libcamera/ipa_module.cpp | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 58e8d1d..477f4b8 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -289,6 +289,11 @@ int IPAModule::loadIPAModuleInfo()\n unmap:\n \tmunmap(map, soSize);\n close:\n+\tif (ret)\n+\t\tLOG(IPAModule, Error)\n+\t\t\t<< \"Error loading IPA module \"\n+\t\t\t<< libPath_;\n+\n \tclose(fd);\n \treturn ret;\n }\n",
    "prefixes": [
        "libcamera-devel",
        "v3"
    ]
}