Patch Detail
Show a patch.
GET /api/1.1/patches/15959/?format=api
{ "id": 15959, "url": "https://patchwork.libcamera.org/api/1.1/patches/15959/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15959/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220518131329.66994-10-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-18T13:13:20", "name": "[libcamera-devel,v3,09/18] py: cam_kms: support multiplanar formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7855d9e70224d785c2bb9d784c2010b2a49c4075", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15959/mbox/", "series": [ { "id": 3122, "url": "https://patchwork.libcamera.org/api/1.1/series/3122/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3122", "date": "2022-05-18T13:13:11", "name": "Misc Python bindings patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3122/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15959/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15959/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9B12C3270\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 13:14:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C3FB65673;\n\tWed, 18 May 2022 15:14:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03DB265658\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 May 2022 15:13:51 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D6ED21DB;\n\tWed, 18 May 2022 15:13:50 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652879644;\n\tbh=0E1l+zZJe89mXQfzY2FnvUcWOVVH+rL1DzyelJd/0Vs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=MAuFdP+Im5QPo9GQuojDfXHf2yEFggE8Yz7aXcrvRqJIASONCa8HnRZqw6+JVFJ6Z\n\tIbE4BY3nzdjL7fprxUHcbvZ+JnIJir1B7jm5QUnX8KoiJKj7myX3ESKBzhyYbBPNFN\n\t4XvnotM5Vyec2HkYrhpGaFL7SQqItdH97VpEKJjGbmX5yc4/iptjZZyiwQa/QE1iPs\n\tOzJkIeSUDIAgmaEWDfdECTL0VS78a5M75AwQxMaNJIA2D+EfcfXvzL1sRoeEmvJUoM\n\tNfJqw7c6VoJCHacJZuStIKXLEQeo+xNAaBGcai7rR2bT4MmQO5Yr/T5+KUW0B+J8Cg\n\txFe+E4vLagZDw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652879630;\n\tbh=0E1l+zZJe89mXQfzY2FnvUcWOVVH+rL1DzyelJd/0Vs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NJAJNzXsFLR5IdYg8aomgwbZli8dHY+up9xYm1pySbrutLQHgMZYs1xKBWyjvzS6M\n\tdNlE1sRvKuPSSqC05/SmkerN1jtbdBZWvV+QvJVGYkXK9i11uE8Pnc6G3/7EIOzIMA\n\tarL743iZ2/O9WRAZDGZqlHySwnmDxYm4BFWtRnPM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NJAJNzXs\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Wed, 18 May 2022 16:13:20 +0300", "Message-Id": "<20220518131329.66994-10-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 09/18] py: cam_kms: support multiplanar\n\tformats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Support multiplanar formats in the kms renderer. Tested with RPi and\nNV12.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/py/cam/cam_kms.py | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\nindex ae6be277..f1844717 100644\n--- a/src/py/cam/cam_kms.py\n+++ b/src/py/cam/cam_kms.py\n@@ -10,6 +10,7 @@ FMT_MAP = {\n 'YUYV': pykms.PixelFormat.YUYV,\n 'ARGB8888': pykms.PixelFormat.ARGB8888,\n 'XRGB8888': pykms.PixelFormat.XRGB8888,\n+ 'NV12': pykms.PixelFormat.NV12,\n }\n \n \n@@ -133,10 +134,16 @@ class KMSRenderer:\n \n for fb in ctx['allocator'].buffers(stream):\n w, h = cfg.size\n- stride = cfg.stride\n- fd = fb.fd(0)\n+ fds = []\n+ strides = []\n+ offsets = []\n+ for i in range(fb.num_planes):\n+ fds.append(fb.fd(i))\n+ strides.append(cfg.stride)\n+ offsets.append(fb.offset(i))\n+\n drmfb = pykms.DmabufFramebuffer(self.card, w, h, fmt,\n- [fd], [stride], [0])\n+ fds, strides, offsets)\n self.cam_2_drm[fb] = drmfb\n \n idx += 1\n", "prefixes": [ "libcamera-devel", "v3", "09/18" ] }