Patch Detail
Show a patch.
GET /api/1.1/patches/15933/?format=api
{ "id": 15933, "url": "https://patchwork.libcamera.org/api/1.1/patches/15933/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15933/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220517143325.71784-10-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-17T14:33:21", "name": "[libcamera-devel,v2,09/13] py: cam_kms: fix multistream display", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "98a1bf7e6d0add2070599d24b24c37cbbd69bb74", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15933/mbox/", "series": [ { "id": 3116, "url": "https://patchwork.libcamera.org/api/1.1/series/3116/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3116", "date": "2022-05-17T14:33:12", "name": "Misc Python bindings patches", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3116/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15933/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15933/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9810C3271\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 May 2022 14:34:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D4C065667;\n\tTue, 17 May 2022 16:34:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 336246566D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 May 2022 16:33:56 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EF4CD59;\n\tTue, 17 May 2022 16:33:55 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652798040;\n\tbh=U0Vdm2wpBtY0+BD7NSs1FupKjGp9MeIUUX1p4o37m6M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1xWnfODdSw3JIMu5RSUBwLNjeinvnHfRNdA0t/lXLn+ELFWpkNKMKlXPpeUNSIEie\n\tumgDa6t7bOBpgV86usR3l+2GK2ZsbJlVtTRkNlrR/YHWFWTfNaUDtScYhbsTVxuQvt\n\tehlpQLwTkMaXiBG3EtaBEiWyFqEnAEYYYe4cMzzA046OUgMRinv62AJaNMq1D0g79z\n\tL49Z1Sue5gtXWV9zJQc9NHLbbXY+Tz/xpHWhZ4+gmk5uO1eSjG0eJ3wNjyCnW0m12y\n\t4smYjStJTGrrL5EWDDgJqaJvP0lrndmhLK2zRjdWCxVL8akc3xw5luA9pnWxCvexFA\n\tT9yhM2k9o4M1w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652798036;\n\tbh=U0Vdm2wpBtY0+BD7NSs1FupKjGp9MeIUUX1p4o37m6M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MUsbNzKaEWYIkqCSShrIW+6vhAZc4Kk5qElwtToVfYtwOandLNSlGNmKWAWXNMIg3\n\tkfne+i0rcKTaKdfk2c6GkZ/Gyz5PC0q4PfDSFCOnwezU2ulXEoJWKjmnJM59kuuQ0Q\n\tS7S3PJStYhoonxBChXXWqWvbPyiFQHBL1OkkTv08=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MUsbNzKa\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 17 May 2022 17:33:21 +0300", "Message-Id": "<20220517143325.71784-10-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 09/13] py: cam_kms: fix multistream\n\tdisplay", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of doing an atomic commit for each stream, do a single commit\nfor the two planes. This fixes the issue that only the first plane was\nactually shown.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/cam/cam_kms.py | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\nindex f1844717..d8ff0284 100644\n--- a/src/py/cam/cam_kms.py\n+++ b/src/py/cam/cam_kms.py\n@@ -75,12 +75,13 @@ class KMSRenderer:\n \n buffers = drmreq['camreq'].buffers\n \n+ req = pykms.AtomicReq(self.card)\n+\n for stream, fb in buffers.items():\n drmfb = self.cam_2_drm.get(fb, None)\n-\n- req = pykms.AtomicReq(self.card)\n self.add_plane(req, stream, drmfb)\n- req.commit()\n+\n+ req.commit()\n \n def handle_page_flip(self, frame, time):\n old = self.current\n", "prefixes": [ "libcamera-devel", "v2", "09/13" ] }