Patch Detail
Show a patch.
GET /api/1.1/patches/15915/?format=api
{ "id": 15915, "url": "https://patchwork.libcamera.org/api/1.1/patches/15915/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15915/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220516141022.96327-10-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-16T14:10:17", "name": "[libcamera-devel,09/14] py: conv.py: minor cleanups", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "974a6b011bea16a41b774559fd0c5ed37182e13b", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15915/mbox/", "series": [ { "id": 3113, "url": "https://patchwork.libcamera.org/api/1.1/series/3113/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3113", "date": "2022-05-16T14:10:08", "name": "Misc Python bindings patches", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3113/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15915/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15915/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54B38C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 May 2022 14:11:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02A0C65678;\n\tMon, 16 May 2022 16:11:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DD8E65667\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 May 2022 16:10:52 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC6D659D;\n\tMon, 16 May 2022 16:10:51 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652710261;\n\tbh=IP2QL/5PkYu8iWZ2/e8dNVwMu0kVrrqLMzzix+9M7Vk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=JsRrYQR85pWh+muBYEVB84l5fuJylSDYa12Pk9kGdROCGchyJjY6k6r9Y6hmNAzVI\n\tm7HXkdcqAsqAZsb2dv/eprCeRdsW5n4lbOti4Y/ZIUrILbSA9hBfSTEWEuGzKdb10Q\n\tUeugaoivr9eSsT8o2jC8t5ilqk1qy9SXzbnyRsXMpUWXajF8ye4YmcpCfrJBqe6Kyp\n\tSBSuSMy+SSsgGx1qamlUGbZ3F/bMIfhuJ2sxbVKPfOfQz+pi0JPpFeXXfBp1Wox2gp\n\t+VvoZ8/k9rBqfy72reIcqlvSTDSJaUgh/fgewPgSoMLEgj/bW6RwxwXwPw/zNrfo4D\n\tnOnLq1JSzqoYg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652710252;\n\tbh=IP2QL/5PkYu8iWZ2/e8dNVwMu0kVrrqLMzzix+9M7Vk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BzoYZ+k1jHQFC6jrlye3iaDj3t/zanK2ns8Svwjewm+UcgKMFTgNRC/1J1B1bdH8K\n\tR6PK9cXdfvVJtGeW4xvnJmeWr/qS+iSRFePhH9VfiJLG65P4+3lsJQfaFTnjojq3WJ\n\t8i0tmW6lbxhfqBdhnSLHl5Enr2mj7Ge50M35aIbA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BzoYZ+k1\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Mon, 16 May 2022 17:10:17 +0300", "Message-Id": "<20220516141022.96327-10-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 09/14] py: conv.py: minor cleanups", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Combine separate_components() with demosaic() and clean up the comments.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/libcamera/utils/conv.py | 54 ++++------------------------------\n 1 file changed, 6 insertions(+), 48 deletions(-)", "diff": "diff --git a/src/py/libcamera/utils/conv.py b/src/py/libcamera/utils/conv.py\nindex 71270671..2e483003 100644\n--- a/src/py/libcamera/utils/conv.py\n+++ b/src/py/libcamera/utils/conv.py\n@@ -8,19 +8,8 @@ from numpy.lib.stride_tricks import as_strided\n import numpy as np\n \n \n-def separate_components(data, r0, g0, g1, b0):\n- # Now to split the data up into its red, green, and blue components. The\n- # Bayer pattern of the OV5647 sensor is BGGR. In other words the first\n- # row contains alternating green/blue elements, the second row contains\n- # alternating red/green elements, and so on as illustrated below:\n- #\n- # GBGBGBGBGBGBGB\n- # RGRGRGRGRGRGRG\n- # GBGBGBGBGBGBGB\n- # RGRGRGRGRGRGRG\n- #\n- # Please note that if you use vflip or hflip to change the orientation\n- # of the capture, you must flip the Bayer pattern accordingly\n+def demosaic(data, r0, g0, g1, b0):\n+ # Separate the components from the Bayer data to RGB planes\n \n rgb = np.zeros(data.shape + (3,), dtype=data.dtype)\n rgb[r0[1]::2, r0[0]::2, 0] = data[r0[1]::2, r0[0]::2] # Red\n@@ -28,17 +17,9 @@ def separate_components(data, r0, g0, g1, b0):\n rgb[g1[1]::2, g1[0]::2, 1] = data[g1[1]::2, g1[0]::2] # Green\n rgb[b0[1]::2, b0[0]::2, 2] = data[b0[1]::2, b0[0]::2] # Blue\n \n- return rgb\n-\n-\n-def demosaic(rgb, r0, g0, g1, b0):\n- # At this point we now have the raw Bayer data with the correct values\n- # and colors but the data still requires de-mosaicing and\n- # post-processing. If you wish to do this yourself, end the script here!\n- #\n # Below we present a fairly naive de-mosaic method that simply\n # calculates the weighted average of a pixel based on the pixels\n- # surrounding it. The weighting is provided b0[1] a b0[1]te representation of\n+ # surrounding it. The weighting is provided by a byte representation of\n # the Bayer filter which we construct first:\n \n bayer = np.zeros(rgb.shape, dtype=np.uint8)\n@@ -58,29 +39,6 @@ def demosaic(rgb, r0, g0, g1, b0):\n borders = (window[0] - 1, window[1] - 1)\n border = (borders[0] // 2, borders[1] // 2)\n \n- # rgb_pad = np.zeros((\n- # rgb.shape[0] + borders[0],\n- # rgb.shape[1] + borders[1],\n- # rgb.shape[2]), dtype=rgb.dtype)\n- # rgb_pad[\n- # border[0]:rgb_pad.shape[0] - border[0],\n- # border[1]:rgb_pad.shape[1] - border[1],\n- # :] = rgb\n- # rgb = rgb_pad\n- #\n- # bayer_pad = np.zeros((\n- # bayer.shape[0] + borders[0],\n- # bayer.shape[1] + borders[1],\n- # bayer.shape[2]), dtype=bayer.dtype)\n- # bayer_pad[\n- # border[0]:bayer_pad.shape[0] - border[0],\n- # border[1]:bayer_pad.shape[1] - border[1],\n- # :] = bayer\n- # bayer = bayer_pad\n-\n- # In numpy >=1.7.0 just use np.pad (version in Raspbian is 1.6.2 at the\n- # time of writing...)\n- #\n rgb = np.pad(rgb, [\n (border[0], border[0]),\n (border[1], border[1]),\n@@ -157,7 +115,7 @@ def to_rgb(fmt, size, data):\n bayer_pattern = fmt[1:5]\n bitspp = int(fmt[5:])\n \n- # TODO: shifting leaves the lowest bits 0\n+ # \\todo shifting leaves the lowest bits 0\n if bitspp == 8:\n data = data.reshape((h, w))\n data = data.astype(np.uint16) << 8\n@@ -184,8 +142,7 @@ def to_rgb(fmt, size, data):\n assert(idx != -1)\n b0 = (idx % 2, idx // 2)\n \n- rgb = separate_components(data, r0, g0, g1, b0)\n- rgb = demosaic(rgb, r0, g0, g1, b0)\n+ rgb = demosaic(data, r0, g0, g1, b0)\n rgb = (rgb >> 8).astype(np.uint8)\n \n else:\n@@ -194,6 +151,7 @@ def to_rgb(fmt, size, data):\n return rgb\n \n \n+# A naive format conversion to 24-bit RGB\n def mfb_to_rgb(mfb:MappedFrameBuffer, cfg:StreamConfiguration):\n data = np.array(mfb.planes[0], dtype=np.uint8)\n rgb = to_rgb(cfg.pixel_format, cfg.size, data)\n", "prefixes": [ "libcamera-devel", "09/14" ] }