Patch Detail
Show a patch.
GET /api/1.1/patches/15897/?format=api
{ "id": 15897, "url": "https://patchwork.libcamera.org/api/1.1/patches/15897/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15897/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220512103258.324339-2-chenghaoyang@google.com>", "date": "2022-05-12T10:32:51", "name": "[libcamera-devel,1/8] Add StreamRole in StreamConfiguration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "77274a45be57fe9a38fa6f5d91bf767c83814527", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15897/mbox/", "series": [ { "id": 3111, "url": "https://patchwork.libcamera.org/api/1.1/series/3111/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3111", "date": "2022-05-12T10:32:50", "name": "Use two imgus in ipu3 pipeline handler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3111/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15897/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15897/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C53DCC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 May 2022 10:33:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5195E6049E;\n\tThu, 12 May 2022 12:33:09 +0200 (CEST)", "from mail-pl1-x635.google.com (mail-pl1-x635.google.com\n\t[IPv6:2607:f8b0:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7615C6049E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 May 2022 12:33:06 +0200 (CEST)", "by mail-pl1-x635.google.com with SMTP id q18so4443104pln.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 May 2022 03:33:06 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(174.71.80.34.bc.googleusercontent.com. [34.80.71.174])\n\tby smtp.gmail.com with ESMTPSA id\n\tt19-20020a62d153000000b005087c23ad8dsm3402219pfl.0.2022.05.12.03.33.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 May 2022 03:33:04 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652351589;\n\tbh=MW0offhMoJI/VCah591TiXh7bqFR0DpG7E9GcFsGS4Q=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wPydZUyDwIGQiyJrPmiDlaq4HMokGoXv8ckBuDSG9AllFe9JUHy36IuoQ+sUSeii0\n\tFUzpzM1PP2Ekkb6YpjOzRkyYaaRz5iD0CrV2QBGZPOXhmUbFCf/7D/oA/j4cDXNjYF\n\tuJSSD02OCL0ba9Vl36FlSVQ6HyiBc2XXiUhxsrOyc/GS8xwH8xGoweR/NqpOR/4g4n\n\tJIAF1VSeKEG0gDYX7Yc323pNagWKD3LO9jZC65rlrcgbkIrKv8dFk/TJOeZkDJ8gUr\n\tcZL768wbROVI/yDYPpzn7O7BfoydMW0qUlaOrQ14bXR4PR7DZ4oHXMhRPpR6G/C4t6\n\t/MvpAC0XErcUw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=/RLoL25Tv7rJr7zr2WqE+km06ZA1O+F8o2ekb2BaZe8=;\n\tb=KLggY4gAofckSdnpElKIaVomU+ofBq8ojFDltZ2cOCwq2DjDCedQdjq3Z3/slApWOD\n\tWsoAirNij/DHmdXIRTNxMSAkjLg5BZh3EEft07WT4lheTSkYKdx8qL2MBpA/uSJwGOO1\n\tESbMTlXPUql0pq9BkbLDl047oiCamIQbMCRKk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"KLggY4gA\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=/RLoL25Tv7rJr7zr2WqE+km06ZA1O+F8o2ekb2BaZe8=;\n\tb=1SQm2E4uZf7HiJZx9rkW2ptcQR+f+aREDpEOpOM0x38V38VE/OoFayDSt+Wg+pzkNn\n\tWtdwKWNbJ2TI7qT1D7nKWsphAvLS54IZvAZlB2BGI510ELzxGaqWER0LE7r+20Iq5O2B\n\tIvy4/QGgfi5sppYzvZUZiTK/yn3zAHTJNIQUdHodKAU5C+psSJUoVWZcGJfuR6eL4B5e\n\tpOdnreBU/gTBeDAMzKEe3jBoEk8s74vfcC6bmdj+UnJ8Gi6Zgqtuupw8TKYIPEZMCM8C\n\th7nqlZtWRCu0oSmAAFxNCovglxfNZPD+pFHxcchQ7WsObGGg3du4BTPJhitsV9NE+X2D\n\tDtMg==", "X-Gm-Message-State": "AOAM5329XwT5DtcuSKHCfEF/rpBZtFYSWVFUU1dK2JT53OhHuViTl7zL\n\tyBF81lmgmZ6lQ9cu7jVQJsIa4+om6KSraNz5", "X-Google-Smtp-Source": "ABdhPJxt7je/CJpTrF6EzosuK7pwJDrLTu30mWLi3pf4prYd0xvlplKLEAvDRV4p5UU4qYyLvuE48g==", "X-Received": "by 2002:a17:902:ea11:b0:15e:ae19:f36a with SMTP id\n\ts17-20020a170902ea1100b0015eae19f36amr29750066plg.52.1652351584694; \n\tThu, 12 May 2022 03:33:04 -0700 (PDT)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 May 2022 10:32:51 +0000", "Message-Id": "<20220512103258.324339-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.36.0.512.ge40c2bad7a-goog", "In-Reply-To": "<20220512103258.324339-1-chenghaoyang@google.com>", "References": "<20220512103258.324339-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/8] Add StreamRole in StreamConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo let ipu3 pipeline handler understand the usage of streams, this patch\nadds StreamRole member variable in StreamConfiguration, which should be\nset by the (Android) adapter.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/stream.h | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex f0ae7e62..c9e79226 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -22,6 +22,15 @@ namespace libcamera {\n class Camera;\n class Stream;\n \n+enum StreamRole {\n+\tRaw,\n+\tStillCapture,\n+\tVideoRecording,\n+\tViewfinder,\n+};\n+\n+using StreamRoles = std::vector<StreamRole>;\n+\n class StreamFormats\n {\n public:\n@@ -50,6 +59,8 @@ struct StreamConfiguration {\n \n \tstd::optional<ColorSpace> colorSpace;\n \n+\tStreamRole streamRole;\n+\n \tStream *stream() const { return stream_; }\n \tvoid setStream(Stream *stream) { stream_ = stream; }\n \tconst StreamFormats &formats() const { return formats_; }\n@@ -61,15 +72,6 @@ private:\n \tStreamFormats formats_;\n };\n \n-enum StreamRole {\n-\tRaw,\n-\tStillCapture,\n-\tVideoRecording,\n-\tViewfinder,\n-};\n-\n-using StreamRoles = std::vector<StreamRole>;\n-\n class Stream\n {\n public:\n", "prefixes": [ "libcamera-devel", "1/8" ] }