Patch Detail
Show a patch.
GET /api/1.1/patches/1589/?format=api
{ "id": 1589, "url": "https://patchwork.libcamera.org/api/1.1/patches/1589/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1589/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190703080007.21376-2-paul.elder@ideasonboard.com>", "date": "2019-07-03T08:00:01", "name": "[libcamera-devel,RFC,v2,1/7] libcamera: ipa_module_info: add license field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "006c7b84f30f804e418e4cd1a65f66b844de3c90", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1589/mbox/", "series": [ { "id": 392, "url": "https://patchwork.libcamera.org/api/1.1/series/392/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=392", "date": "2019-07-03T08:00:00", "name": "Add IPA process isolation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/392/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1589/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1589/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86C5461571\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2019 10:00:25 +0200 (CEST)", "from neptunite.flets-east.jp\n\t(p1871204-ipngn14001hodogaya.kanagawa.ocn.ne.jp [153.220.127.204])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B29724B;\n\tWed, 3 Jul 2019 10:00:23 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562140825;\n\tbh=GiboB/+QpkhPSmGFFg6QBKda2DvHAu7MkYk3Dk9gck4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OXaQMmgObPqSnD9irTYcpYbAEsHYCBOVnluF1EhZb/JqgoQ3NuLBmrqg5gBkV3O/k\n\t8lV6cyJNN03Q+hUDbs3fGG94dqE+47oE9JPGoksWxXhvbw+4byUtSpUPjC2jfw3Hrp\n\ty2TrbSaxMtTuigTkgThddYX4yEhiUB1UXnB29LOc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 3 Jul 2019 17:00:01 +0900", "Message-Id": "<20190703080007.21376-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190703080007.21376-1-paul.elder@ideasonboard.com>", "References": "<20190703080007.21376-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 1/7] libcamera: ipa_module_info:\n\tadd license field", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 03 Jul 2019 08:00:25 -0000" }, "content": "Add a field to IPAModuleInfo to contain the license of the module.\n\nUpdate the dummy IPA and IPA test to conform to the new struct layout\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nNew patch in v2\n- this replaces the isolate flag that was used in v1\n\n include/libcamera/ipa/ipa_module_info.h | 2 ++\n src/ipa/ipa_dummy.cpp | 1 +\n src/libcamera/ipa_module.cpp | 3 +++\n test/ipa/ipa_test.cpp | 1 +\n 4 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h\nindex 585f753..39dca1a 100644\n--- a/include/libcamera/ipa/ipa_module_info.h\n+++ b/include/libcamera/ipa/ipa_module_info.h\n@@ -18,6 +18,8 @@ struct IPAModuleInfo {\n \tuint32_t pipelineVersion;\n \tchar pipelineName[256];\n \tchar name[256];\n+\tchar license[64];\n+\n } __attribute__((packed));\n \n extern \"C\" {\ndiff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nindex ee7a3a8..2e6ff71 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -34,6 +34,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \t0,\n \t\"PipelineHandlerVimc\",\n \t\"Dummy IPA for Vimc\",\n+\t\"LGPLv2.1\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex d82ac69..f786c16 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -215,6 +215,9 @@ elfLoadSymbol(void *map, size_t soSize, const char *symbol)\n *\n * \\var IPAModuleInfo::name\n * \\brief The name of the IPA module\n+ *\n+ * \\var IPAModuleInfo::license\n+ * \\brief License of the IPA module\n */\n \n /**\ndiff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nindex bbef069..4c51034 100644\n--- a/test/ipa/ipa_test.cpp\n+++ b/test/ipa/ipa_test.cpp\n@@ -59,6 +59,7 @@ protected:\n \t\t\t0,\n \t\t\t\"PipelineHandlerVimc\",\n \t\t\t\"Dummy IPA for Vimc\",\n+\t\t\t\"LGPLv2.1\"\n \t\t};\n \n \t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "1/7" ] }