Patch Detail
Show a patch.
GET /api/1.1/patches/15889/?format=api
{ "id": 15889, "url": "https://patchwork.libcamera.org/api/1.1/patches/15889/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15889/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-50-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:46", "name": "[libcamera-devel,49/50] staging: media: imx: imx7-media-csi: Drop V4L2 events support", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "180ce0154f432928eaeccc50b8c9d120ffd31bb5", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15889/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/1.1/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15889/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15889/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90CBAC327F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44B6B6565A;\n\tTue, 10 May 2022 13:52:47 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D614F656B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:38 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 029E6DFF;\n\tTue, 10 May 2022 13:52:37 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183567;\n\tbh=7TZAvmLE3VyU/IP2y4JQZc51w8dX52N/5RgRLrzd8oU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TwGAWWsLIxqbTEa1ey42VPaq3JJ62zTAueHhRn+z9Jm88G1+rB9PLg9TGV+s0Ax8M\n\t7tOOmRxU32R9xy2nJNE3A/T2EME9dQzOhL+/Rc55uDrqUXQDV6X57JBpEHd0Hsxw2e\n\tWkZ3fmwhLmD3axW1CIe4uIIZn/U1DIr4/o/Sbuav0CRBqieAJeJ4ufKpz9aPsZMTSA\n\tgXuQTMA9N7e08NkVlsy5gC52XhAN9AiO68mVSNTXtDRG4sx+SLlu149KvAM8bB8AvY\n\tIUcLgbs80+CcruInvqsJHSz58rhQrWfXnH32g59HcPGDbkGE2YstL/OIzGJDmPZoRb\n\tUkhW9dzgH6ylQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183558;\n\tbh=7TZAvmLE3VyU/IP2y4JQZc51w8dX52N/5RgRLrzd8oU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FjRrUelU3+MP4783xr+OBvUr3IWrsx6/VqOZpnFpivIi8IovyQwhru9sXBmBxxy4g\n\tFFPv9o4Z1asCi2yRl1y6OwQYQSTDZrsM6gsQqh9kHc1BgzXApP4ITu2cRrxl/LKM7h\n\t9t2LHEK62svQ9tFqTh9EeK7M5vE85E/rzkdNi1MA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FjRrUelU\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:46 +0300", "Message-Id": "<20220510115147.19360-50-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 49/50] staging: media: imx:\n\timx7-media-csi: Drop V4L2 events support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The only event that the driver allows subscribing to,\nV4L2_EVENT_IMX_FRAME_INTERVAL_ERROR, is never generated. Drop events\nsupport.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 16 ----------------\n 1 file changed, 16 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 0bf69933f1bd..ae74256755f4 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -22,14 +22,12 @@\n #include <linux/types.h>\n \n #include <media/v4l2-device.h>\n-#include <media/v4l2-event.h>\n #include <media/v4l2-fwnode.h>\n #include <media/v4l2-ioctl.h>\n #include <media/v4l2-mc.h>\n #include <media/v4l2-subdev.h>\n #include <media/videobuf2-dma-contig.h>\n \n-#include <media/imx.h>\n #include \"imx-media.h\"\n \n #define IMX7_CSI_PAD_SINK\t\t0\n@@ -1212,17 +1210,6 @@ static int imx7_csi_video_g_selection(struct file *file, void *fh,\n \treturn 0;\n }\n \n-static int imx7_csi_video_subscribe_event(struct v4l2_fh *fh,\n-\t\t\t\t\t const struct v4l2_event_subscription *sub)\n-{\n-\tswitch (sub->type) {\n-\tcase V4L2_EVENT_IMX_FRAME_INTERVAL_ERROR:\n-\t\treturn v4l2_event_subscribe(fh, sub, 0, NULL);\n-\tdefault:\n-\t\treturn -EINVAL;\n-\t}\n-}\n-\n static const struct v4l2_ioctl_ops imx7_csi_video_ioctl_ops = {\n \t.vidioc_querycap\t\t= imx7_csi_video_querycap,\n \n@@ -1244,9 +1231,6 @@ static const struct v4l2_ioctl_ops imx7_csi_video_ioctl_ops = {\n \t.vidioc_expbuf\t\t\t= vb2_ioctl_expbuf,\n \t.vidioc_streamon\t\t= vb2_ioctl_streamon,\n \t.vidioc_streamoff\t\t= vb2_ioctl_streamoff,\n-\n-\t.vidioc_subscribe_event\t\t= imx7_csi_video_subscribe_event,\n-\t.vidioc_unsubscribe_event\t= v4l2_event_unsubscribe,\n };\n \n /* -----------------------------------------------------------------------------\n", "prefixes": [ "libcamera-devel", "49/50" ] }