Patch Detail
Show a patch.
GET /api/1.1/patches/15869/?format=api
{ "id": 15869, "url": "https://patchwork.libcamera.org/api/1.1/patches/15869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-30-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:26", "name": "[libcamera-devel,29/50] staging: media: imx: imx7-media-csi: Store imx7_csi in drv data", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "19075b76d306769697897341725756629ca983eb", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15869/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/1.1/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15869/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28715C326F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B00BE6566E;\n\tTue, 10 May 2022 13:52:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2C116566E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:21 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE49AB9A;\n\tTue, 10 May 2022 13:52:20 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183550;\n\tbh=Q5pLB1e2XYYIIIEjFrPhWLsfrzF2a4m2XFlEvoFIpmM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RAmsnwQUB63VnBQHThFaFfDggTfX2h5xxZ0mHv5JRfyG4iAL92lS4JNX6ARaN9Ixz\n\twBQbTYwr2MJzZmaQwH8lUyW1S8HLDW4eQhsl9re+sUzgcdwNJV95ey6QyVC8JTvsvm\n\tVfJkHpwtpn6xoHET9//3lV66xIeMhCqwsz9tkH+dONu+VjlvXf2twA+O6B9sITcd3+\n\tKCHbD3s/erj18+HIEN53TtHdLghDqjgzavFG6BbUXo5LeZ3PzbH3QZk9SracSDaNk3\n\tsabNsy/oRUDgFjMNLdr63B+U6NuSrWXn61v+44EhgDcqjsWAJ3tr2ZOlMcJCX4ASyN\n\tbLjsBazbi5Pyw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183541;\n\tbh=Q5pLB1e2XYYIIIEjFrPhWLsfrzF2a4m2XFlEvoFIpmM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A1mh1onnGcsAoADCaWcs0nvAvwPk6hFy77hJpkoRlVbpIXo7y5dP4e5d6vcaE7Q39\n\tc+aPZSd3sdKrFo8MnY2PO7DPThNLMt8P0jMXjn9CNgFqiEo8vNyuxgzBH+hOp+n18C\n\tApkdY1zvp0b7UkrzsBqL9a2GNpDGfXn1lNVqRxdg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"A1mh1onn\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:26 +0300", "Message-Id": "<20220510115147.19360-30-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 29/50] staging: media: imx:\n\timx7-media-csi: Store imx7_csi in drv data", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace the subdev pointer stored in platform drv data with the imx7_csi\npointer. Drop a now redundant dev_set_drvdata() call.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 14683a15e003..5a5157d8b27b 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1842,8 +1842,6 @@ static int imx7_csi_media_dev_init(struct imx7_csi *csi)\n {\n \tint ret;\n \n-\tdev_set_drvdata(csi->dev, csi);\n-\n \tstrscpy(csi->mdev.model, \"imx-media\", sizeof(csi->mdev.model));\n \tcsi->mdev.ops = &imx7_csi_media_ops;\n \tcsi->mdev.dev = csi->dev;\n@@ -1913,7 +1911,7 @@ static int imx7_csi_probe(struct platform_device *pdev)\n \t\treturn -ENOMEM;\n \n \tcsi->dev = dev;\n-\tplatform_set_drvdata(pdev, &csi->sd);\n+\tplatform_set_drvdata(pdev, csi);\n \n \tspin_lock_init(&csi->irqlock);\n \tmutex_init(&csi->lock);\n@@ -1977,14 +1975,13 @@ static int imx7_csi_probe(struct platform_device *pdev)\n \n static int imx7_csi_remove(struct platform_device *pdev)\n {\n-\tstruct v4l2_subdev *sd = platform_get_drvdata(pdev);\n-\tstruct imx7_csi *csi = v4l2_get_subdevdata(sd);\n+\tstruct imx7_csi *csi = platform_get_drvdata(pdev);\n \n \timx7_csi_media_cleanup(csi);\n \n \tv4l2_async_nf_unregister(&csi->notifier);\n \tv4l2_async_nf_cleanup(&csi->notifier);\n-\tv4l2_async_unregister_subdev(sd);\n+\tv4l2_async_unregister_subdev(&csi->sd);\n \n \tmutex_destroy(&csi->lock);\n \n", "prefixes": [ "libcamera-devel", "29/50" ] }