Patch Detail
Show a patch.
GET /api/1.1/patches/15858/?format=api
{ "id": 15858, "url": "https://patchwork.libcamera.org/api/1.1/patches/15858/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15858/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-19-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:15", "name": "[libcamera-devel,18/50] staging: media: imx: imx7-media-csi: Import imx_media_dev_init() helper", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "19f7be415619e61a6da962cd80bdedaf7762a2ff", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15858/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/1.1/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15858/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15858/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E57A8C326E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 836C565647;\n\tTue, 10 May 2022 13:52:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91B5165656\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:12 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABEF3B60;\n\tTue, 10 May 2022 13:52:11 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183541;\n\tbh=zHEDlecSQr99fSBCxfJcECaZP6Pkmnn8f2Cu8iYM8vQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mmZlOs5YF2uf5+Xnlu83n6Dskptu8JWaJqu3PlGcnY4jek0IvX74DZxWhw/Kiu70R\n\tjbLGkdB97672bD9MN9JFWIYRWTcVbu9iS0+Lp+f8Si1LEH451dD+Lmc37Rgw/mz9ja\n\tUbuUmpMJJDeAWLew3y1wZOolbvLz4qTrIQMr7SPdO+T5fXgDWOnYlJthlbxYSWQk5e\n\tQK/oj87GlYhqsqWMtQCsQTNC/W2l0Qj4SROuH6tDcUoX05K5Jqqke/g6VMsR9nBmtW\n\tvey/nddQ9xDmXkVUCSOZZkqXq3uAu6sw3Pa413eKYrHZ6tfQjty9CU2Cgi9OuhNXv8\n\tb78oi44kkqBIw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183532;\n\tbh=zHEDlecSQr99fSBCxfJcECaZP6Pkmnn8f2Cu8iYM8vQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QtlbVbEnLBNpuKXLVaCfGpaBO5WMQqdHC1QDnkhAijV2XdwF6RU6nqlXXiT+cP6C8\n\t8L0nk2tnTNx4H+Idu2AtNMsAtvJS8VQf7o4tMi5L6yU5AAuAI+c8UXm7hB0BvyT/im\n\tyBo80C8NCtJt81Gmly1jFE1N+wQZVq6zikP8zPy0=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QtlbVbEn\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:15 +0300", "Message-Id": "<20220510115147.19360-19-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 18/50] staging: media: imx:\n\timx7-media-csi: Import imx_media_dev_init() helper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for code refactoring, copy the imx_media_dev_init() helper\nused by this driver from imx-media-dev-common.c. Rename the function to\navoid name clashes, and leave the v4l2_device notify handler out as it\nonly serves to implement control inheritance, which this driver doesn't\nuse. No functional change intended.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 50 +++++++++++++++++++++-\n 1 file changed, 49 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex bd1bdc09e701..8b19792adfc6 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1809,13 +1809,61 @@ static void imx7_csi_media_cleanup(struct imx7_csi *csi)\n \tmedia_device_cleanup(&imxmd->md);\n }\n \n+static const struct media_device_ops imx7_csi_media_ops = {\n+\t.link_notify = v4l2_pipeline_link_notify,\n+};\n+\n+static struct imx_media_dev *imx7_csi_media_dev_init(struct device *dev)\n+{\n+\tstruct imx_media_dev *imxmd;\n+\tint ret;\n+\n+\timxmd = devm_kzalloc(dev, sizeof(*imxmd), GFP_KERNEL);\n+\tif (!imxmd)\n+\t\treturn ERR_PTR(-ENOMEM);\n+\n+\tdev_set_drvdata(dev, imxmd);\n+\n+\tstrscpy(imxmd->md.model, \"imx-media\", sizeof(imxmd->md.model));\n+\timxmd->md.ops = &imx7_csi_media_ops;\n+\timxmd->md.dev = dev;\n+\n+\tmutex_init(&imxmd->mutex);\n+\n+\timxmd->v4l2_dev.mdev = &imxmd->md;\n+\tstrscpy(imxmd->v4l2_dev.name, \"imx-media\",\n+\t\tsizeof(imxmd->v4l2_dev.name));\n+\tsnprintf(imxmd->md.bus_info, sizeof(imxmd->md.bus_info),\n+\t\t \"platform:%s\", dev_name(imxmd->md.dev));\n+\n+\tmedia_device_init(&imxmd->md);\n+\n+\tret = v4l2_device_register(dev, &imxmd->v4l2_dev);\n+\tif (ret < 0) {\n+\t\tv4l2_err(&imxmd->v4l2_dev,\n+\t\t\t \"Failed to register v4l2_device: %d\\n\", ret);\n+\t\tgoto cleanup;\n+\t}\n+\n+\tINIT_LIST_HEAD(&imxmd->vdev_list);\n+\n+\tv4l2_async_nf_init(&imxmd->notifier);\n+\n+\treturn imxmd;\n+\n+cleanup:\n+\tmedia_device_cleanup(&imxmd->md);\n+\n+\treturn ERR_PTR(ret);\n+}\n+\n static int imx7_csi_media_init(struct imx7_csi *csi)\n {\n \tstruct imx_media_dev *imxmd;\n \tint i, ret;\n \n \t/* add media device */\n-\timxmd = imx_media_dev_init(csi->dev, NULL);\n+\timxmd = imx7_csi_media_dev_init(csi->dev);\n \tif (IS_ERR(imxmd))\n \t\treturn PTR_ERR(imxmd);\n \n", "prefixes": [ "libcamera-devel", "18/50" ] }