Patch Detail
Show a patch.
GET /api/1.1/patches/15850/?format=api
{ "id": 15850, "url": "https://patchwork.libcamera.org/api/1.1/patches/15850/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15850/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-11-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:07", "name": "[libcamera-devel,10/50] staging: media: imx: imx7-media-csi: Remove imx_media_of_add_csi", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "c80b5dbdfa25dec0e7c898ba4107b2589f876f04", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15850/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/1.1/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15850/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15850/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EBC3C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3B126566F;\n\tTue, 10 May 2022 13:52:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F02A65646\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:05 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89EF1DFF;\n\tTue, 10 May 2022 13:52:04 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183532;\n\tbh=d+7BkkERKznRknT/kY5nL7k0K2j0jSnisRVTDGKQ6Co=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YocrLsXwQjqt50Sa87b24uY0FfwjZiZOsS7SGa/bSOjgIiidG6d8MsqdFk+2YERFG\n\tBRzvG4uVy6SPVLO008IUgkTvr5hxmFlq6oEQ0XQm/0QXeSssG1X2fwJMgZVYmcXmOO\n\tI/9nZ4BI+P5CJYCw7mfRtRFlNpSRTtM/D7SwAWmIrh2JgTXcXiVpiuW3i5/wLJovrc\n\tvM6Pq3h11nKIURV96j5l6QHE5ZFiW++27D7BWJ8M8QATs485QeyqLkQxS/Chkrch75\n\tTrnmmfJziDBui/zvkvbnwSgo6dZTVWeVCqQVOoGXvpMy5MC0n/qBPKTQFjoA7h6r+7\n\toGALGjTDhMvkw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183525;\n\tbh=d+7BkkERKznRknT/kY5nL7k0K2j0jSnisRVTDGKQ6Co=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eJUQtjfGxAKAf2OIwldmbr5OUD0Rqij0Wo52xqyQ4t96QKzGN6bcfomk+XuuLt0aH\n\tlvNvyIPhMIJY252kTUdfnxRJfvgK72jnMBO8e7GZMXZlMCk1Z99pSHPWqSsho2KvNT\n\ttfbgRqSp+08i3Ae06KAE8vxcqH6UCAW43iJKw/nM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eJUQtjfG\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:07 +0300", "Message-Id": "<20220510115147.19360-11-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 10/50] staging: media: imx:\n\timx7-media-csi: Remove imx_media_of_add_csi", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Paul Elder <paul.elder@ideasonboard.com>\n\nimx_media_of_add_csi() from imx-media-of.c validates that the fwnode for\nthe CSI bridge is enabled, and adds the fwnode to the async notifier of\nthe imxmd. The former is redundant, as if the CSI bridge driver probes,\nclearly it is enabled in the DT. The latter is not needed as the imxmd\nnotifier isn't used anymore. The call is thus not needed and can be\ndropped. This removes the dependency of imx7-media-csi.c on\nimx-media-of.c.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex d85b5ab204df..e7dcb602afae 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1203,12 +1203,6 @@ static int imx7_csi_media_init(struct imx7_csi *csi)\n \tif (IS_ERR(imxmd))\n \t\treturn PTR_ERR(imxmd);\n \n-\tret = imx_media_of_add_csi(imxmd, csi->dev->of_node);\n-\tif (ret < 0 && ret != -ENODEV && ret != -EEXIST) {\n-\t\timx7_csi_media_cleanup(csi);\n-\t\treturn ret;\n-\t}\n-\n \tcsi->imxmd = imxmd;\n \n \tv4l2_subdev_init(&csi->sd, &imx7_csi_subdev_ops);\n", "prefixes": [ "libcamera-devel", "10/50" ] }