Patch Detail
Show a patch.
GET /api/1.1/patches/15844/?format=api
{ "id": 15844, "url": "https://patchwork.libcamera.org/api/1.1/patches/15844/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15844/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-5-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:01", "name": "[libcamera-devel,04/50] staging: media: imx: imx7-media-csi: Drop duplicate link creation", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "0ab1a7095b160710dcd234122dcf74130f5c9bee", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15844/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/1.1/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15844/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15844/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96FE1C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 451056564D;\n\tTue, 10 May 2022 13:52:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 385D865648\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:00 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A254DFF;\n\tTue, 10 May 2022 13:51:59 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183523;\n\tbh=pcHJ/iHL8mYCDutTvm2V49TLbx7X/i0r5Te2u6dAS1Q=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zsvmt7kwqO0OG8fEZOjxP4FrgpaUpjLbqcq1saqbVYw/KirBkTPsYCN+a9ksvnjRq\n\taUp632hS7NqOYFsIyiTbC/YuMN6RGZSEXDCv2ZSNax7Pwez/2T45hJQ+FvnIYUHlE7\n\t20CJ7zma/InLZH/zH5IjtdH9n7wkXfjxdebws+errwS9gDJ8PYuStPh2MatT/LXdpQ\n\tMMH7Rvxiwm9K1EvXMvA1XOxIopbGNARwiRGXzLCGi5XoFTJaVM6VKn3UvCh5LrmTf7\n\tpqBIB8yTJHnewnY7DOtkZ2l7bcdW4UGkAIiOJ/vU3uDlNX4lFYobosWp2o5cw5bGt1\n\tZN6f8/VDg536g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183520;\n\tbh=pcHJ/iHL8mYCDutTvm2V49TLbx7X/i0r5Te2u6dAS1Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jgDwYlm6p4aEHUvn3Y4nUh2HkT21gU6UJFCytdlnkqEhrt7d8n7LTHv2ATmbP6mW7\n\tRkl0pcrnOqucYxbG6b/wI0fiq+K4NhxFBmyrlUiDOvWA8emS4rKiF8ak0nyMuYn39n\n\tj9b8iD86m0lHB8/Ge6J90T6/TudPh9gqd77Gu0P0=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jgDwYlm6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:01 +0300", "Message-Id": "<20220510115147.19360-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/50] staging: media: imx:\n\timx7-media-csi: Drop duplicate link creation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The imx_media_create_csi2_links() creates a media controller link\nbetween the CSI-2 receiver and the next entity in the pipeline, which\ncan be either a video mux (handled by the video-mux driver) or the CSI\nbridge itself. This isn't needed, as the link is already created either\nby the video-mux driver or by the imx7-media-csi driver itself (in\nimx7_csi_notify_bound()).\n\nDrop imx_media_create_csi2_links(), which allows dropping the CSI bridge\nsubdev grp_id.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 31 ----------------------\n 1 file changed, 31 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 708076b7045a..e2d6dabad007 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -726,34 +726,6 @@ static inline struct imx_media_dev *notifier2dev(struct v4l2_async_notifier *n)\n \treturn container_of(n, struct imx_media_dev, notifier);\n }\n \n-/*\n- * Create the missing media links from the CSI-2 receiver.\n- * Called after all async subdevs have bound.\n- */\n-static void imx_media_create_csi2_links(struct imx_media_dev *imxmd)\n-{\n-\tstruct v4l2_subdev *sd, *csi2 = NULL;\n-\n-\tlist_for_each_entry(sd, &imxmd->v4l2_dev.subdevs, list) {\n-\t\tif (sd->grp_id == IMX_MEDIA_GRP_ID_CSI2) {\n-\t\t\tcsi2 = sd;\n-\t\t\tbreak;\n-\t\t}\n-\t}\n-\tif (!csi2)\n-\t\treturn;\n-\n-\tlist_for_each_entry(sd, &imxmd->v4l2_dev.subdevs, list) {\n-\t\t/* skip if not a CSI or a CSI mux */\n-\t\tif (!(sd->grp_id & IMX_MEDIA_GRP_ID_IPU_CSI) &&\n-\t\t !(sd->grp_id & IMX_MEDIA_GRP_ID_CSI) &&\n-\t\t !(sd->grp_id & IMX_MEDIA_GRP_ID_CSI_MUX))\n-\t\t\tcontinue;\n-\n-\t\tv4l2_create_fwnode_links(csi2, sd);\n-\t}\n-}\n-\n /*\n * adds given video device to given imx-media source pad vdev list.\n * Continues upstream from the pad entity's sink pads.\n@@ -883,8 +855,6 @@ static int __imx_media_probe_complete(struct v4l2_async_notifier *notifier)\n \n \tmutex_lock(&imxmd->mutex);\n \n-\timx_media_create_csi2_links(imxmd);\n-\n \tret = imx_media_create_pad_vdev_lists(imxmd);\n \tif (ret)\n \t\tgoto unlock;\n@@ -1477,7 +1447,6 @@ static int imx7_csi_probe(struct platform_device *pdev)\n \tcsi->sd.dev = &pdev->dev;\n \tcsi->sd.owner = THIS_MODULE;\n \tcsi->sd.flags = V4L2_SUBDEV_FL_HAS_DEVNODE;\n-\tcsi->sd.grp_id = IMX_MEDIA_GRP_ID_CSI;\n \tsnprintf(csi->sd.name, sizeof(csi->sd.name), \"csi\");\n \n \tfor (i = 0; i < IMX7_CSI_PADS_NUM; i++)\n", "prefixes": [ "libcamera-devel", "04/50" ] }