Patch Detail
Show a patch.
GET /api/1.1/patches/1584/?format=api
{ "id": 1584, "url": "https://patchwork.libcamera.org/api/1.1/patches/1584/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1584/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190702114841.19101-4-kieran.bingham@ideasonboard.com>", "date": "2019-07-02T11:48:41", "name": "[libcamera-devel,4/4] qcam: Update window title with FPS", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7481320d9ff384cc93688835c1fdee97f01c0042", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1584/mbox/", "series": [ { "id": 390, "url": "https://patchwork.libcamera.org/api/1.1/series/390/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=390", "date": "2019-07-02T11:48:38", "name": "[libcamera-devel,1/4] Documentation: Make the project brief more expressive", "version": 1, "mbox": "https://patchwork.libcamera.org/series/390/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1584/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1584/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13E9061F67\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Jul 2019 13:48:50 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A876F524;\n\tTue, 2 Jul 2019 13:48:49 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562068129;\n\tbh=lK8GD458CQXK9G4Kv7p20o6wxLv1mGNibXiiEc3regY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CfGogUh+cREQCpwKKiRnRNGQ9Y+80jC3RQ52FZttgKBpaZSFOzkq0AY+eAVK+MY2F\n\tlilQ9DsMO2pf2LrBrphVDprUOMbawlGYyAjMvnPjHbJsGoDRNZi+ueXnf18kMuBXdg\n\tBYqckHpF1pFhkef1urummu5luA7KlPMXzKvAP+xs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 2 Jul 2019 12:48:41 +0100", "Message-Id": "<20190702114841.19101-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190702114841.19101-1-kieran.bingham@ideasonboard.com>", "References": "<20190702114841.19101-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/4] qcam: Update window title with FPS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 02 Jul 2019 11:48:50 -0000" }, "content": "Provide an average FPS in the QCam title bar to show the current rate of\nframe processing.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 23 ++++++++++++++++++++---\n src/qcam/main_window.h | 4 +++-\n 2 files changed, 23 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 61d7aa9469f0..c093bd0c809e 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -26,7 +26,7 @@ MainWindow::MainWindow(const OptionsParser::Options &options)\n {\n \tint ret;\n \n-\tsetWindowTitle();\n+\tsetWindowTitle(\"\");\n \tviewfinder_ = new ViewFinder(this);\n \tsetCentralWidget(viewfinder_);\n \tviewfinder_->setFixedSize(500, 500);\n@@ -52,10 +52,11 @@ MainWindow::~MainWindow()\n \tCameraManager::instance()->stop();\n }\n \n-void MainWindow::setWindowTitle()\n+void MainWindow::setWindowTitle(QString fps)\n {\n \tQMainWindow::setWindowTitle(\"QCam : \"\n-\t\t+ QString::fromStdString(libcamera::version.toString()));\n+\t\t+ QString::fromStdString(libcamera::version.toString())\n+\t\t+ \" (\" + fps + \")\");\n }\n \n int MainWindow::openCamera()\n@@ -152,6 +153,9 @@ int MainWindow::startCapture()\n \t\trequests.push_back(request);\n \t}\n \n+\tfirstFrameTime = 0;\n+\tframesCaptured = 0;\n+\n \tret = camera_->start();\n \tif (ret) {\n \t\tstd::cout << \"Failed to start capture\" << std::endl;\n@@ -215,6 +219,19 @@ void MainWindow::requestComplete(Request *request,\n \n \tdisplay(buffer);\n \n+\tif (firstFrameTime == 0)\n+\t\tfirstFrameTime = buffer->timestamp();\n+\n+\tuint64_t duration = buffer->timestamp() - firstFrameTime;\n+\tif (duration)\n+\t\tfps = framesCaptured * 1000000000.0 / duration;\n+\telse\n+\t\tfps = 0.0;\n+\n+\tsetWindowTitle(QString::number(fps, 'f', 2) + \" fps\");\n+\n+\tframesCaptured++;\n+\n \trequest = camera_->createRequest();\n \tif (!request) {\n \t\tstd::cerr << \"Can't create request\" << std::endl;\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex b30a86768efc..792f89c2d831 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -33,7 +33,7 @@ public:\n \t~MainWindow();\n \n private:\n-\tvoid setWindowTitle();\n+\tvoid setWindowTitle(QString info);\n \n \tint openCamera();\n \n@@ -49,6 +49,8 @@ private:\n \tstd::shared_ptr<Camera> camera_;\n \tbool isCapturing_;\n \tstd::unique_ptr<CameraConfiguration> config_;\n+\tuint64_t firstFrameTime;\n+\tuint32_t framesCaptured;\n \n \tViewFinder *viewfinder_;\n };\n", "prefixes": [ "libcamera-devel", "4/4" ] }