Patch Detail
Show a patch.
GET /api/1.1/patches/15777/?format=api
{ "id": 15777, "url": "https://patchwork.libcamera.org/api/1.1/patches/15777/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15777/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220504132154.9681-5-laurent.pinchart@ideasonboard.com>", "date": "2022-05-04T13:21:53", "name": "[libcamera-devel,4/5] libcamera: pipeline: simple: Store sensor resolution in configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04a9757e7e94b36635a8d216ab50f2af3db92a02", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15777/mbox/", "series": [ { "id": 3090, "url": "https://patchwork.libcamera.org/api/1.1/series/3090/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3090", "date": "2022-05-04T13:21:49", "name": "libcamera: pipeline: simple: Support scaling on the camea sensor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3090/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15777/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15777/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22615C326D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 May 2022 13:22:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 558DC6565A;\n\tWed, 4 May 2022 15:22:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21C0265642\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:22:01 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B47344A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:22:00 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651670526;\n\tbh=JN1RXQayuzopNsDmpw3NQuT6eRGlbIl310dd8nGKdIk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=P1DN7eEu0DOl1vwYRWAtV/y2/v20CZ5TG2F5u7NUXjtUN4gTg+0vT+z4oET2OciPb\n\tmcc3LoXOVcnCXft9bqocEcR8Vgak5esxn0OD8KWIVnxRqfavQLlWly7zKV6Vkkxgcl\n\tQNj3lOHcr5M65iLQ/bW5YYi6SA4hsWntS0E8h8sNfwhzIEWEqup3Xxnr9Y900cnbhI\n\tYQIFawHwxJ8W0uewY2chjtGIjSjP3eCNR0+yzFI9AadF2OqBSiJhsdZYUDkYvWbzK4\n\tYDoGxfGDaZwl17hcz2Xa0fSCmnvkYFnQ1Xm2QTOR7H5sMYPSh2bQLxuOV2PboJOilt\n\tZ5yUwcC7eqpFA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651670520;\n\tbh=JN1RXQayuzopNsDmpw3NQuT6eRGlbIl310dd8nGKdIk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gXzw5uTmzP1DnNlHc7J7DNQ15z1t1bsCaMP6bDoZ780oOH2gVVLh+NiGdoSKlFR32\n\tCUdTiMot1g56sjqZ3mOXX21lOWN1WN2q7O8BsqIhKfNErPpEXtUOAUJn7AOk/BxLXo\n\td/3yYB09CIcAKXe5SDv1Pwt0ApGtB9t8OR/j7zV4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gXzw5uTm\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 May 2022 16:21:53 +0300", "Message-Id": "<20220504132154.9681-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220504132154.9681-1-laurent.pinchart@ideasonboard.com>", "References": "<20220504132154.9681-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/5] libcamera: pipeline: simple: Store\n\tsensor resolution in configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When enumerating the supported configurations, store the corresponding\nsensor resolution in the SimpleCameraData::Configuration structure and\nuse it when configuring the camera, instead of hardcoding the sensor\nfull resolution. This prepares for support of downscaling in the camera\nsensor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 19deb9447c96..e7fda239d6b5 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -225,6 +225,7 @@ public:\n \n \tstruct Configuration {\n \t\tuint32_t code;\n+\t\tSize sensorSize;\n \t\tPixelFormat captureFormat;\n \t\tSize captureSize;\n \t\tstd::vector<PixelFormat> outputFormats;\n@@ -534,6 +535,7 @@ void SimpleCameraData::tryPipeline(unsigned int code, const Size &size)\n \n \t\tConfiguration config;\n \t\tconfig.code = code;\n+\t\tconfig.sensorSize = size;\n \t\tconfig.captureFormat = pixelFormat;\n \t\tconfig.captureSize = format.size;\n \n@@ -935,7 +937,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tconst SimpleCameraData::Configuration *pipeConfig = config->pipeConfig();\n \tV4L2SubdeviceFormat format{};\n \tformat.mbus_code = pipeConfig->code;\n-\tformat.size = data->sensor_->resolution();\n+\tformat.size = pipeConfig->sensorSize;\n \n \tret = data->setupFormats(&format, V4L2Subdevice::ActiveFormat);\n \tif (ret < 0)\n", "prefixes": [ "libcamera-devel", "4/5" ] }