Patch Detail
Show a patch.
GET /api/1.1/patches/15769/?format=api
{ "id": 15769, "url": "https://patchwork.libcamera.org/api/1.1/patches/15769/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15769/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220504131558.9498-3-laurent.pinchart@ideasonboard.com>", "date": "2022-05-04T13:15:55", "name": "[libcamera-devel,2/5] libcamera: formats: Add YUV444 and YVU444 pixel formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ea59e5643cfddf7b3e18c07a2e466e683a47cc7b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15769/mbox/", "series": [ { "id": 3089, "url": "https://patchwork.libcamera.org/api/1.1/series/3089/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3089", "date": "2022-05-04T13:15:53", "name": "libcamera: Support additional pixel formats and media bus codes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3089/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15769/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15769/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3766C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 May 2022 13:16:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D99FB65654;\n\tWed, 4 May 2022 15:16:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E54E65642\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:16:04 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25FA14A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:16:04 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651670166;\n\tbh=fWt404U56kVZzAAy/pmDiT2ZgDHZxGo0VUAC6a9H31o=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=F2BVOhDfXAl1UcHQbKeKo013aNy/8E8TtNDtSvFYTVRmZ4OdNxQn1aR4N7M73338I\n\tbKvqm5f9nH50tyqBxQ/AhsETnLCDQfT0chl6npFY3CZevPGjRwsD+29U4X37PtsD0z\n\tAUfzpwdMXiTVVy2n2Bu1ippjR5KCGJQPM0qHH7/VJOTSK26EHgLBHwXYdL/iPEdUgS\n\tfGfg/SeVp8U2zVpA8owhYGHn1BHhwuNJe6j+AWjcKCzYTMDOca2ozJmFydrL7ucKME\n\tsVFdAtZyTBhikI790UVK6hWuFn7kJVDtNG7Y6po/Ht1mj6qNZfcYsMZGKq0Hi1LROe\n\tp/7D9cScOqzQg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651670164;\n\tbh=fWt404U56kVZzAAy/pmDiT2ZgDHZxGo0VUAC6a9H31o=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=F6k0Et+u/qQPeKQJhunCihSaCFRG6hQJaRs1D5kejZKUK3yfWzfN/0F4OoE81WOd0\n\t+p7FD29SLxF4VZt/F+szhyom6xJ87O+//heU5LwZ9Qtfhuh2Snl1GNAlv1ok/L+8Nx\n\tbdJK7C1sO9miWEUvlkwvyRw8bMo/AwNmITaIOMVM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F6k0Et+u\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 May 2022 16:15:55 +0300", "Message-Id": "<20220504131558.9498-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220504131558.9498-1-laurent.pinchart@ideasonboard.com>", "References": "<20220504131558.9498-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/5] libcamera: formats: Add YUV444 and\n\tYVU444 pixel formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Extend planar YUV format support with 4:4:4 formats. Those formats are\nused by the i.MX8 ISI driver that will be supported by the simple\npipeline handler.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/formats.cpp | 26 ++++++++++++++++++++++++++\n src/libcamera/formats.yaml | 4 ++++\n src/libcamera/v4l2_pixelformat.cpp | 4 ++++\n 3 files changed, 34 insertions(+)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex c5cca37b02c2..e205df0529ba 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -482,6 +482,32 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 2,\n \t\t.planes = {{ { 2, 1 }, { 1, 1 }, { 1, 1 } }},\n \t} },\n+\t{ formats::YUV444, {\n+\t\t.name = \"YUV444\",\n+\t\t.format = formats::YUV444,\n+\t\t.v4l2Formats = {\n+\t\t\t.single = V4L2PixelFormat(),\n+\t\t\t.multi = V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n+\t\t},\n+\t\t.bitsPerPixel = 24,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 1, 1 }, { 1, 1 } }},\n+\t} },\n+\t{ formats::YVU444, {\n+\t\t.name = \"YVU444\",\n+\t\t.format = formats::YVU444,\n+\t\t.v4l2Formats = {\n+\t\t\t.single = V4L2PixelFormat(),\n+\t\t\t.multi = V4L2PixelFormat(V4L2_PIX_FMT_YVU444M),\n+\t\t},\n+\t\t.bitsPerPixel = 24,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 1, 1 }, { 1, 1 } }},\n+\t} },\n \n \t/* Greyscale formats. */\n \t{ formats::R8, {\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex 0b527dbefe32..7dda01325f33 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -71,6 +71,10 @@ formats:\n fourcc: DRM_FORMAT_YUV422\n - YVU422:\n fourcc: DRM_FORMAT_YVU422\n+ - YUV444:\n+ fourcc: DRM_FORMAT_YUV444\n+ - YVU444:\n+ fourcc: DRM_FORMAT_YVU444\n \n - MJPEG:\n fourcc: DRM_FORMAT_MJPEG\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 818bd1037e14..8d409943e2d3 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -115,6 +115,10 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{\n \t\t{ formats::YUV422, \"Planar YUV 4:2:2 (N-C)\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV422M),\n \t\t{ formats::YVU422, \"Planar YVU 4:2:2 (N-C)\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n+\t\t{ formats::YUV444, \"Planar YUV 4:4:4 (N-C)\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n+\t\t{ formats::YVU444, \"Planar YVU 4:4:4 (N-C)\" } },\n \n \t/* Greyscale formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_GREY),\n", "prefixes": [ "libcamera-devel", "2/5" ] }