Patch Detail
Show a patch.
GET /api/1.1/patches/15726/?format=api
{ "id": 15726, "url": "https://patchwork.libcamera.org/api/1.1/patches/15726/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15726/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220426110236.104511-4-tomi.valkeinen@ideasonboard.com>", "date": "2022-04-26T11:02:35", "name": "[libcamera-devel,v6,3/4] py: add unittests.py", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a38b30cddfdfc01df42fd501f8ea45de6fac00e3", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15726/mbox/", "series": [ { "id": 3072, "url": "https://patchwork.libcamera.org/api/1.1/series/3072/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3072", "date": "2022-04-26T11:02:32", "name": "Python bindings", "version": 6, "mbox": "https://patchwork.libcamera.org/series/3072/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15726/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15726/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27FCCC3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Apr 2022 11:03:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8AF86564C;\n\tTue, 26 Apr 2022 13:03:01 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F31BA6563D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Apr 2022 13:02:56 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 103E2488;\n\tTue, 26 Apr 2022 13:02:56 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650970981;\n\tbh=6fGlgT3t5CFsES2Trl1Zrbr8KRsAnZyunUfu+6cc3PA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0xJmEFBwp2/u4SF3Et+Y6jNqxUa/KdS0jVoU7VbMUXUzpHNUBvg4j+Ub6EqVRAgZG\n\tZTTaZOXfBSYl4XX8ApyOmN8e0uwgts1TLpg+66SxyUOOGN7isONSMklDlXuQ5TtKcJ\n\tW14DbeKyxJk9tvyPiLCYWeCKGHBcit7ChAgCfZMus8Ir6GWiFRu1wYbFbaYrhLeE4k\n\tMNNp7DYkuoLYjQfvUoRqienGqkH5kuSIExqv5VIkFrOcRKuRiJ8QlBSgCqwwbc7OHC\n\tppNi5nY5kSG89zg4d/8+CQpV6K6KtdoDHl+rfGIuVOR3W+IChQtUlgymEU4k4pKVAf\n\t6phNsfJksghWg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650970976;\n\tbh=6fGlgT3t5CFsES2Trl1Zrbr8KRsAnZyunUfu+6cc3PA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZSntBn6IqKQBvB2A7XFnFbE94P0/XuBuRQnTuYoju5FyqFPHHtFR4tMaN5xljbqQG\n\tjGpFje/5pttkN760KiBxePNZGrg2OWtnSGg7TLo0lBcnLlkNEmNKPZs5rsr9AWqu0G\n\tSWhcJDlv2PPSE/hXK2z0pv1bEYUF2VUVlQpbtPnA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZSntBn6I\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 26 Apr 2022 14:02:35 +0300", "Message-Id": "<20220426110236.104511-4-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220426110236.104511-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220426110236.104511-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 3/4] py: add unittests.py", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a simple unittests.py as a base for python unittests.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n test/meson.build | 1 +\n test/py/meson.build | 17 ++\n test/py/unittests.py | 368 +++++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 386 insertions(+)\n create mode 100644 test/py/meson.build\n create mode 100755 test/py/unittests.py", "diff": "diff --git a/test/meson.build b/test/meson.build\nindex fd4c5ca0..623f3baa 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -18,6 +18,7 @@ subdir('log')\n subdir('media_device')\n subdir('pipeline')\n subdir('process')\n+subdir('py')\n subdir('serialization')\n subdir('stream')\n subdir('v4l2_compat')\ndiff --git a/test/py/meson.build b/test/py/meson.build\nnew file mode 100644\nindex 00000000..8f0a38c6\n--- /dev/null\n+++ b/test/py/meson.build\n@@ -0,0 +1,17 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+if not pycamera_enabled\n+ subdir_done()\n+endif\n+\n+pymod = import('python')\n+py3 = pymod.find_installation('python3')\n+\n+pypathdir = meson.build_root() / 'src/py'\n+\n+test('pyunittests',\n+ py3,\n+ args : files('unittests.py'),\n+ env : ['PYTHONPATH=' + pypathdir],\n+ suite : 'pybindings',\n+ is_parallel : false)\ndiff --git a/test/py/unittests.py b/test/py/unittests.py\nnew file mode 100755\nindex 00000000..15d5b4a7\n--- /dev/null\n+++ b/test/py/unittests.py\n@@ -0,0 +1,368 @@\n+#!/usr/bin/env python3\n+\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2021, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n+\n+from collections import defaultdict\n+import errno\n+import gc\n+import libcamera as libcam\n+import os\n+import selectors\n+import time\n+import unittest\n+import weakref\n+\n+\n+class MyTestCase(unittest.TestCase):\n+ def assertZero(self, a, msg=None):\n+ self.assertEqual(a, 0, msg)\n+\n+\n+class SimpleTestMethods(MyTestCase):\n+ def test_find_ref(self):\n+ cm = libcam.CameraManager.singleton()\n+ wr_cm = weakref.ref(cm)\n+\n+ cam = cm.find(\"platform/vimc\")\n+ self.assertIsNotNone(cam)\n+ wr_cam = weakref.ref(cam)\n+\n+ cm = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_cm())\n+\n+ cam = None\n+ gc.collect()\n+ self.assertIsNone(wr_cm())\n+ self.assertIsNone(wr_cam())\n+\n+ def test_get_ref(self):\n+ cm = libcam.CameraManager.singleton()\n+ wr_cm = weakref.ref(cm)\n+\n+ cam = cm.get(\"platform/vimc.0 Sensor B\")\n+ self.assertTrue(cam is not None)\n+ wr_cam = weakref.ref(cam)\n+\n+ cm = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_cm())\n+\n+ cam = None\n+ gc.collect()\n+ self.assertIsNone(wr_cm())\n+ self.assertIsNone(wr_cam())\n+\n+ def test_acquire_release(self):\n+ cm = libcam.CameraManager.singleton()\n+ cam = cm.get(\"platform/vimc.0 Sensor B\")\n+ self.assertTrue(cam is not None)\n+\n+ ret = cam.acquire()\n+ self.assertZero(ret)\n+\n+ ret = cam.release()\n+ self.assertZero(ret)\n+\n+ def test_double_acquire(self):\n+ cm = libcam.CameraManager.singleton()\n+ cam = cm.get(\"platform/vimc.0 Sensor B\")\n+ self.assertTrue(cam is not None)\n+\n+ ret = cam.acquire()\n+ self.assertZero(ret)\n+\n+ libcam.logSetLevel(\"Camera\", \"FATAL\")\n+ ret = cam.acquire()\n+ self.assertEqual(ret, -errno.EBUSY)\n+ libcam.logSetLevel(\"Camera\", \"ERROR\")\n+\n+ ret = cam.release()\n+ self.assertZero(ret)\n+\n+ ret = cam.release()\n+ # I expected EBUSY, but looks like double release works fine\n+ self.assertZero(ret)\n+\n+\n+class CameraTesterBase(MyTestCase):\n+ def setUp(self):\n+ self.cm = libcam.CameraManager.singleton()\n+ self.cam = self.cm.find(\"platform/vimc\")\n+ if self.cam is None:\n+ self.cm = None\n+ raise Exception(\"No vimc found\")\n+\n+ ret = self.cam.acquire()\n+ if ret != 0:\n+ self.cam = None\n+ self.cm = None\n+ raise Exception(\"Failed to acquire camera\")\n+\n+ def tearDown(self):\n+ # If a test fails, the camera may be in running state. So always stop.\n+ self.cam.stop()\n+\n+ ret = self.cam.release()\n+ if ret != 0:\n+ raise Exception(\"Failed to release camera\")\n+\n+ self.cam = None\n+ self.cm = None\n+\n+\n+class AllocatorTestMethods(CameraTesterBase):\n+ def test_allocator(self):\n+ cam = self.cam\n+\n+ camconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+ wr_camconfig = weakref.ref(camconfig)\n+\n+ streamconfig = camconfig.at(0)\n+ wr_streamconfig = weakref.ref(streamconfig)\n+\n+ ret = cam.configure(camconfig)\n+ self.assertZero(ret)\n+\n+ stream = streamconfig.stream\n+ wr_stream = weakref.ref(stream)\n+\n+ # stream should keep streamconfig and camconfig alive\n+ streamconfig = None\n+ camconfig = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_camconfig())\n+ self.assertIsNotNone(wr_streamconfig())\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ self.assertTrue(ret > 0)\n+ wr_allocator = weakref.ref(allocator)\n+\n+ buffers = allocator.buffers(stream)\n+ buffers = None\n+\n+ buffer = allocator.buffers(stream)[0]\n+ self.assertIsNotNone(buffer)\n+ wr_buffer = weakref.ref(buffer)\n+\n+ allocator = None\n+ gc.collect()\n+ self.assertIsNotNone(wr_buffer())\n+ self.assertIsNotNone(wr_allocator())\n+ self.assertIsNotNone(wr_stream())\n+\n+ buffer = None\n+ gc.collect()\n+ self.assertIsNone(wr_buffer())\n+ self.assertIsNone(wr_allocator())\n+ self.assertIsNotNone(wr_stream())\n+\n+ stream = None\n+ gc.collect()\n+ self.assertIsNone(wr_stream())\n+ self.assertIsNone(wr_camconfig())\n+ self.assertIsNone(wr_streamconfig())\n+\n+\n+class SimpleCaptureMethods(CameraTesterBase):\n+ def test_sleep(self):\n+ cm = self.cm\n+ cam = self.cam\n+\n+ camconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+\n+ streamconfig = camconfig.at(0)\n+ fmts = streamconfig.formats\n+\n+ ret = cam.configure(camconfig)\n+ self.assertZero(ret)\n+\n+ stream = streamconfig.stream\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ self.assertTrue(ret > 0)\n+\n+ num_bufs = len(allocator.buffers(stream))\n+\n+ reqs = []\n+ for i in range(num_bufs):\n+ req = cam.createRequest(i)\n+ self.assertIsNotNone(req)\n+\n+ buffer = allocator.buffers(stream)[i]\n+ ret = req.addBuffer(stream, buffer)\n+ self.assertZero(ret)\n+\n+ reqs.append(req)\n+\n+ buffer = None\n+\n+ ret = cam.start()\n+ self.assertZero(ret)\n+\n+ for req in reqs:\n+ ret = cam.queueRequest(req)\n+ self.assertZero(ret)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ time.sleep(0.5)\n+\n+ reqs = cm.getReadyRequests()\n+\n+ self.assertTrue(len(reqs) == num_bufs)\n+\n+ for i, req in enumerate(reqs):\n+ self.assertTrue(i == req.cookie)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ ret = cam.stop()\n+ self.assertZero(ret)\n+\n+ def test_select(self):\n+ cm = self.cm\n+ cam = self.cam\n+\n+ camconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+\n+ streamconfig = camconfig.at(0)\n+ fmts = streamconfig.formats\n+\n+ ret = cam.configure(camconfig)\n+ self.assertZero(ret)\n+\n+ stream = streamconfig.stream\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ self.assertTrue(ret > 0)\n+\n+ num_bufs = len(allocator.buffers(stream))\n+\n+ reqs = []\n+ for i in range(num_bufs):\n+ req = cam.createRequest(i)\n+ self.assertIsNotNone(req)\n+\n+ buffer = allocator.buffers(stream)[i]\n+ ret = req.addBuffer(stream, buffer)\n+ self.assertZero(ret)\n+\n+ reqs.append(req)\n+\n+ buffer = None\n+\n+ ret = cam.start()\n+ self.assertZero(ret)\n+\n+ for req in reqs:\n+ ret = cam.queueRequest(req)\n+ self.assertZero(ret)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ sel = selectors.DefaultSelector()\n+ sel.register(cm.efd, selectors.EVENT_READ, 123)\n+\n+ reqs = []\n+\n+ running = True\n+ while running:\n+ events = sel.select()\n+ for key, mask in events:\n+ os.read(key.fileobj, 8)\n+\n+ ready_reqs = cm.getReadyRequests()\n+\n+ self.assertTrue(len(ready_reqs) > 0)\n+\n+ reqs += ready_reqs\n+\n+ if len(reqs) == num_bufs:\n+ running = False\n+\n+ self.assertTrue(len(reqs) == num_bufs)\n+\n+ for i, req in enumerate(reqs):\n+ self.assertTrue(i == req.cookie)\n+\n+ reqs = None\n+ gc.collect()\n+\n+ ret = cam.stop()\n+ self.assertZero(ret)\n+\n+\n+# Recursively expand slist's objects into olist, using seen to track already\n+# processed objects.\n+def _getr(slist, olist, seen):\n+ for e in slist:\n+ if id(e) in seen:\n+ continue\n+ seen.add(id(e))\n+ olist.append(e)\n+ tl = gc.get_referents(e)\n+ if tl:\n+ _getr(tl, olist, seen)\n+\n+\n+def get_all_objects(ignored=[]):\n+ gcl = gc.get_objects()\n+ olist = []\n+ seen = set()\n+\n+ seen.add(id(gcl))\n+ seen.add(id(olist))\n+ seen.add(id(seen))\n+ seen.update(set([id(o) for o in ignored]))\n+\n+ _getr(gcl, olist, seen)\n+\n+ return olist\n+\n+\n+def create_type_count_map(olist):\n+ map = defaultdict(int)\n+ for o in olist:\n+ map[type(o)] += 1\n+ return map\n+\n+\n+def diff_type_count_maps(before, after):\n+ return [(k, after[k] - before[k]) for k in after if after[k] != before[k]]\n+\n+\n+if __name__ == '__main__':\n+ # doesn't work very well, as things always leak a bit\n+ test_leaks = False\n+\n+ if test_leaks:\n+ gc.unfreeze()\n+ gc.collect()\n+\n+ obs_before = get_all_objects()\n+\n+ unittest.main(exit=False)\n+\n+ if test_leaks:\n+ gc.unfreeze()\n+ gc.collect()\n+\n+ obs_after = get_all_objects([obs_before])\n+\n+ before = create_type_count_map(obs_before)\n+ after = create_type_count_map(obs_after)\n+\n+ leaks = diff_type_count_maps(before, after)\n+ if len(leaks) > 0:\n+ print(leaks)\n", "prefixes": [ "libcamera-devel", "v6", "3/4" ] }