Patch Detail
Show a patch.
GET /api/1.1/patches/15660/?format=api
{ "id": 15660, "url": "https://patchwork.libcamera.org/api/1.1/patches/15660/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15660/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220408105439.144182-3-umang.jain@ideasonboard.com>", "date": "2022-04-08T10:54:39", "name": "[libcamera-devel,2/2] ipa: vimc: Synchronise parameter buffer ops naming", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7dfc958b658a97b31d59e00f8764398708b2d9bf", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15660/mbox/", "series": [ { "id": 3046, "url": "https://patchwork.libcamera.org/api/1.1/series/3046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3046", "date": "2022-04-08T10:54:37", "name": "VIMC IPA nitpicks", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15660/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15660/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EAAEC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 Apr 2022 10:54:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC9C865642;\n\tFri, 8 Apr 2022 12:54:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E50EF65640\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Apr 2022 12:54:51 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE48A499;\n\tFri, 8 Apr 2022 12:54:50 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649415293;\n\tbh=UrhIKJUSz5EYhFtmJVv08sfpRLBg6OyK/RyVq/JNZx4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=i3E5XvWeuvQli7PfSyi2p5bl4aSGqLiDZXSQRDKmoGEO9+bB1511599JALxgW8mhk\n\tkMnvnuKmCAlbxxCp36umJ7Qtp5IqL/JYrbxVRYAcxZ0Xri+ZNS4kj5FOsSXIc6zhVu\n\t/xRS7mNNiyxNwW34OiO3lkucHZESKjX42t6Zf6eqLRR11+h022kAiMSIxrHMY1okDL\n\tmEaw37oDBRmElzusEK5WrJ/OFlL+66LcNp40rmZha3mFtS26JR3vpQHJEhBKutF93C\n\tsuV6IoSIcQN3Wb3IkYL7ZM3lFWCp7pHu5w/4UJ+gxv1d4zs1fYySDoDMUQa3/0oIFW\n\tiYA4VmvTggRvA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649415291;\n\tbh=UrhIKJUSz5EYhFtmJVv08sfpRLBg6OyK/RyVq/JNZx4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ELxMtUXhGqzO56BO5Sfh3KZ4mPd0aBi3hCckI7LtdAjCbXgAWsLLjJHm/QGM+ZUoc\n\tvzAJc54XfZ64Ap8Kfia8F4zLNo2q6nJZ76avJUJ5nvx18d7Z3Qjvtf/npcgGzcKrv6\n\t5o2nA7DX6iV9vHYbvn4eXOn2p6cMKIR74twvWMas=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ELxMtUXh\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 8 Apr 2022 16:24:39 +0530", "Message-Id": "<20220408105439.144182-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220408105439.144182-1-umang.jain@ideasonboard.com>", "References": "<20220408105439.144182-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] ipa: vimc: Synchronise parameter\n\tbuffer ops naming", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Synchronise the names of the operations with respect to parameters\nbuffer with the names used in other IPA interfaces.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n include/libcamera/ipa/vimc.mojom | 4 ++--\n src/ipa/vimc/vimc.cpp | 6 +++---\n src/libcamera/pipeline/vimc/vimc.cpp | 8 ++++----\n 3 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\nindex cdc03ffb..718b9674 100644\n--- a/include/libcamera/ipa/vimc.mojom\n+++ b/include/libcamera/ipa/vimc.mojom\n@@ -37,9 +37,9 @@ interface IPAVimcInterface {\n \t * interface functions that mimick how other pipeline handlers typically\n \t * handle parameters at runtime.\n \t */\n-\t[async] fillParams(uint32 frame, uint32 bufferId);\n+\t[async] fillParamsBuffer(uint32 frame, uint32 bufferId);\n };\n \n interface IPAVimcEventInterface {\n-\tparamsFilled(uint32 bufferId);\n+\tparamsBufferReady(uint32 bufferId);\n };\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex a62e72b0..85afb279 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -44,7 +44,7 @@ public:\n \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n \n \tvoid queueRequest(uint32_t frame, const ControlList &controls) override;\n-\tvoid fillParams(uint32_t frame, uint32_t bufferId) override;\n+\tvoid fillParamsBuffer(uint32_t frame, uint32_t bufferId) override;\n \n private:\n \tvoid initTrace();\n@@ -134,7 +134,7 @@ void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n {\n }\n \n-void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n+void IPAVimc::fillParamsBuffer([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n {\n \tauto it = buffers_.find(bufferId);\n \tif (it == buffers_.end()) {\n@@ -142,7 +142,7 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n \t\treturn;\n \t}\n \n-\tparamsFilled.emit(bufferId);\n+\tparamsBufferReady.emit(bufferId);\n }\n \n void IPAVimc::initTrace()\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 69b83d07..fff95a34 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -53,7 +53,7 @@ public:\n \tint init();\n \tint allocateMockIPABuffers();\n \tvoid bufferReady(FrameBuffer *buffer);\n-\tvoid paramsFilled(unsigned int id);\n+\tvoid paramsBufferReady(unsigned int id);\n \n \tMediaDevice *media_;\n \tstd::unique_ptr<CameraSensor> sensor_;\n@@ -467,7 +467,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \t\treturn false;\n \t}\n \n-\tdata->ipa_->paramsFilled.connect(data.get(), &VimcCameraData::paramsFilled);\n+\tdata->ipa_->paramsBufferReady.connect(data.get(), &VimcCameraData::paramsBufferReady);\n \n \tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n \tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n@@ -589,7 +589,7 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n \tpipe->completeBuffer(request, buffer);\n \tpipe->completeRequest(request);\n \n-\tipa_->fillParams(request->sequence(), mockIPABufs_[0]->cookie());\n+\tipa_->fillParamsBuffer(request->sequence(), mockIPABufs_[0]->cookie());\n }\n \n int VimcCameraData::allocateMockIPABuffers()\n@@ -607,7 +607,7 @@ int VimcCameraData::allocateMockIPABuffers()\n \treturn video_->exportBuffers(kBufCount, &mockIPABufs_);\n }\n \n-void VimcCameraData::paramsFilled([[maybe_unused]] unsigned int id)\n+void VimcCameraData::paramsBufferReady([[maybe_unused]] unsigned int id)\n {\n }\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }