Patch Detail
Show a patch.
GET /api/1.1/patches/15643/?format=api
{ "id": 15643, "url": "https://patchwork.libcamera.org/api/1.1/patches/15643/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15643/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220406151833.1176-1-laurent.pinchart@ideasonboard.com>", "date": "2022-04-06T15:18:33", "name": "[libcamera-devel] libcamera: base: utils: Add missing constructor for Duration", "commit_ref": "e2d00fbcbb1a9b2da50fa2e280817a0de1a7d286", "pull_url": null, "state": "accepted", "archived": false, "hash": "1f19d816739b86111a7ae61bd7eef690b696d994", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15643/mbox/", "series": [ { "id": 3039, "url": "https://patchwork.libcamera.org/api/1.1/series/3039/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3039", "date": "2022-04-06T15:18:33", "name": "[libcamera-devel] libcamera: base: utils: Add missing constructor for Duration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3039/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15643/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15643/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5703DC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Apr 2022 15:18:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A570C65642;\n\tWed, 6 Apr 2022 17:18:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 693F4604B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Apr 2022 17:18:40 +0200 (CEST)", "from pendragon.home (117.145-247-81.adsl-dyn.isp.belgacom.be\n\t[81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 009BE482\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Apr 2022 17:18:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649258322;\n\tbh=cqhytSTROdXpe0QotY+gbk6xpE5iZ2xMct8+NOHsWWo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=sCX1XoeIOdZAS8grJwDqrUYfopZ/uii1OlTTfldtYLBDWxzqHzkhcspi7q2eh/kMq\n\tYStasDQg0PkUUkFmyqLio7Ya3yngFyUobTr2s4RCi/P62ZZI+/mtUZT8fWJ7phMewn\n\taN5jey56aALd9i1UV4YATW8GQkPlAbDp0FF5O0009fAoNLTaPkzJbVGeuuU0sYN7pe\n\t4yb3E3J5Pn1rnTeA+8PusQHYaNhJTNCAts8VFcK5w5ZWgKQiBQoskZDwEsJqzLpBdU\n\tyMJ1nYypUvDOsscqm+bJ+31mOsLLOKhV2JTvszC7aRLroohGoFGWgcvmCdUMRR5g/l\n\tE8tD93NS5vOsQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649258320;\n\tbh=cqhytSTROdXpe0QotY+gbk6xpE5iZ2xMct8+NOHsWWo=;\n\th=From:To:Subject:Date:From;\n\tb=MxisHNnDnHlYy1qGYgJFeVN5B6cHhMNsFkQZUbTiO1QV6+fkqM3qaqcX3bRHjEyZ4\n\teFLQIrBjg1DBEqElk2N+/mwN5T/wDrhkU7UZpoGj8jruzxKkjElydemm+EGpB3AhLv\n\t0dN6R/aDtbtMA2UKm0rO0hWbcXB7SVJ/4TbdjOb0=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MxisHNnD\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Apr 2022 18:18:33 +0300", "Message-Id": "<20220406151833.1176-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: base: utils: Add missing\n\tconstructor for Duration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Duration class is missing the equivalent to the\nstd::chrono::duration constructor that takes a number of ticks expressed\nas a scalar. Fix it, which allows initializing a Duration instance to 0\nor 0.0.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/utils.h | 6 ++++++\n src/libcamera/base/utils.cpp | 9 +++++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 9ab18101cf27..cfff05836de7 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -327,6 +327,12 @@ class Duration : public std::chrono::duration<double, std::nano>\n public:\n \tDuration() = default;\n \n+\ttemplate<typename Rep>\n+\tconstexpr explicit Duration(const Rep &r)\n+\t\t: BaseDuration(r)\n+\t{\n+\t}\n+\n \ttemplate<typename Rep, typename Period>\n \tconstexpr Duration(const std::chrono::duration<Rep, Period> &d)\n \t\t: BaseDuration(d)\ndiff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\nindex 8cf8a5b2c104..6a307940448e 100644\n--- a/src/libcamera/base/utils.cpp\n+++ b/src/libcamera/base/utils.cpp\n@@ -406,6 +406,15 @@ std::string toAscii(const std::string &str)\n * duration in nanoseconds with double precision\n */\n \n+/**\n+ * \\fn Duration::Duration(const Rep &r)\n+ * \\brief Construct a Duration with \\a r ticks\n+ * \\param[in] r The number of ticks\n+ *\n+ * The constructed \\a Duration object is internally represented in double\n+ * precision with \\a r nanoseconds ticks.\n+ */\n+\n /**\n * \\fn Duration::Duration(const std::chrono::duration<Rep, Period> &d)\n * \\brief Construct a Duration by converting an arbitrary std::chrono::duration\n", "prefixes": [ "libcamera-devel" ] }