Patch Detail
Show a patch.
GET /api/1.1/patches/15638/?format=api
{ "id": 15638, "url": "https://patchwork.libcamera.org/api/1.1/patches/15638/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15638/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220406141709.164794-4-umang.jain@ideasonboard.com>", "date": "2022-04-06T14:17:06", "name": "[libcamera-devel,v5,3/6] ipa: ipu3: Inline parseStatistics() into processStatsBuffer()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9db775efe8a775946703ce9224693c8be501a046", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15638/mbox/", "series": [ { "id": 3037, "url": "https://patchwork.libcamera.org/api/1.1/series/3037/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3037", "date": "2022-04-06T14:17:03", "name": "ipa: ipu3: Replace event-based ops with dedicated functions", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3037/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15638/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15638/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A1F6C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Apr 2022 14:17:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C040B65644;\n\tWed, 6 Apr 2022 16:17:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25BE9633A4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Apr 2022 16:17:32 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD2BA482;\n\tWed, 6 Apr 2022 16:17:30 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649254653;\n\tbh=DCDdXzR5EXqotv0wLejnkY0Hx6RbJS0oVZfHYjTbqGo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1IPpvbccylA+xx88CsjIBiZGtOt0kbeyLHMxW7F2LpmKg1blWESdzIcgq6LyxXZpB\n\t+bB/HyH6SgiqcfQahee7UUhB4+6Be4m9CZsmCEBuXL2VogVywjXjpuj6YDjzCzW08W\n\tMZ+T/LrXLA5XmkZY53Ppf9HAYnrIJ2BFVkJ1t8ud7AhOMIdb6cqp7LWmotyddDxizT\n\tnJFOHmJT+nuJHcR2FlaVEfg+2HsBV+ZsS2MgTWVgFRdg739IZpj1T9WQPlEv63a5xd\n\tQtSZxxHLXba7Vj+vlbKTbMFODqjMvrbEhrFuKvovppeaQPi7d6QwjUZgSETaDOC+lb\n\tf1jMU9I0SyOzw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649254651;\n\tbh=DCDdXzR5EXqotv0wLejnkY0Hx6RbJS0oVZfHYjTbqGo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gv621aeTDtQTRIijaN6a9rL8LjAltJs8bgMTVxmNIRJCoQi0hvZdSVmUFZ4h4sLVK\n\ta0+wOqBaYqRaZCfzPqtbXUTL4a2G9RyzwOjFMxltJxbgVqMHOqQ4R9W7DrRezErWAD\n\toOxzFekLwcGUA14blZnZjHir9apXn/Sj7zvjFiv4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gv621aeT\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Apr 2022 19:47:06 +0530", "Message-Id": "<20220406141709.164794-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220406141709.164794-1-umang.jain@ideasonboard.com>", "References": "<20220406141709.164794-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 3/6] ipa: ipu3: Inline\n\tparseStatistics() into processStatsBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since we have moved away from switch/case on the operation ID,\nthere's little reason to split the operation in two functions.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 54 +++++++++++++++----------------------------\n 1 file changed, 19 insertions(+), 35 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 8c9a20f5..569c1311 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -156,9 +156,6 @@ private:\n \t\t\t ControlInfoMap *ipaControls);\n \tvoid updateSessionConfiguration(const ControlInfoMap &sensorControls);\n \n-\tvoid parseStatistics(unsigned int frame,\n-\t\t\t int64_t frameTimestamp,\n-\t\t\t const ipu3_uapi_stats_3a *stats);\n \tbool validateSensorControls();\n \n \tvoid setControls(unsigned int frame);\n@@ -546,11 +543,15 @@ void IPAIPU3::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n }\n \n /**\n- * \\brief Process statistics after ISP completion\n+ * \\brief Process the statistics generated by the ImgU\n * \\param[in] frame The frame number\n * \\param[in] frameTimestamp Timestamp of the frame\n * \\param[in] bufferId ID of the statistics buffer\n * \\param[in] sensorControls Sensor controls\n+ *\n+ * Parse the most recently processed image statistics from the ImgU. The\n+ * statistics are passed to each algorithm module to run their calculations and\n+ * update their state accordingly.\n */\n void IPAIPU3::processStatsBuffer(const uint32_t frame, const int64_t frameTimestamp,\n \t\t\t\t const uint32_t bufferId, const ControlList &sensorControls)\n@@ -568,37 +569,6 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame, const int64_t frameTimest\n \tcontext_.frameContext.sensor.exposure = sensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n \tcontext_.frameContext.sensor.gain = camHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>());\n \n-\tparseStatistics(frame, frameTimestamp, stats);\n-}\n-\n-/**\n- * \\brief Queue a request and process the control list from the application\n- * \\param[in] frame The number of the frame which will be processed next\n- * \\param[in] controls The controls for the \\a frame\n- *\n- * Parse the request to handle any IPA-managed controls that were set from the\n- * application such as manual sensor settings.\n- */\n-void IPAIPU3::queueRequest(const uint32_t frame,\n-\t\t\t [[maybe_unused]] const ControlList &controls)\n-{\n-\t/* \\todo Start processing for 'frame' based on 'controls'. */\n-}\n-\n-/**\n- * \\brief Process the statistics generated by the ImgU\n- * \\param[in] frame The number of the latest frame processed\n- * \\param[in] frameTimestamp The current frame timestamp\n- * \\param[in] stats The IPU3 statistics and ISP results\n- *\n- * Parse the most recently processed image statistics from the ImgU. The\n- * statistics are passed to each algorithm module to run their calculations and\n- * update their state accordingly.\n- */\n-void IPAIPU3::parseStatistics(unsigned int frame,\n-\t\t\t [[maybe_unused]] int64_t frameTimestamp,\n-\t\t\t const ipu3_uapi_stats_3a *stats)\n-{\n \tdouble lineDuration = context_.configuration.sensor.lineDuration.get<std::micro>();\n \tint32_t vBlank = context_.configuration.sensor.defVBlank;\n \tControlList ctrls(controls::controls);\n@@ -629,6 +599,20 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \tmetadataReady.emit(frame, ctrls);\n }\n \n+/**\n+ * \\brief Queue a request and process the control list from the application\n+ * \\param[in] frame The number of the frame which will be processed next\n+ * \\param[in] controls The controls for the \\a frame\n+ *\n+ * Parse the request to handle any IPA-managed controls that were set from the\n+ * application such as manual sensor settings.\n+ */\n+void IPAIPU3::queueRequest(const uint32_t frame,\n+\t\t\t [[maybe_unused]] const ControlList &controls)\n+{\n+\t/* \\todo Start processing for 'frame' based on 'controls'. */\n+}\n+\n /**\n * \\brief Handle sensor controls for a given \\a frame number\n * \\param[in] frame The frame on which the sensor controls should be set\n", "prefixes": [ "libcamera-devel", "v5", "3/6" ] }