Patch Detail
Show a patch.
GET /api/1.1/patches/15617/?format=api
{ "id": 15617, "url": "https://patchwork.libcamera.org/api/1.1/patches/15617/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15617/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220405004215.86340-4-Rauch.Christian@gmx.de>", "date": "2022-04-05T00:42:13", "name": "[libcamera-devel,v2,3/5] provide a default fixed-sized Span constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c114a6ca9f9f5bd453260d5b411a1cfc257b70b2", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/1.1/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15617/mbox/", "series": [ { "id": 3028, "url": "https://patchwork.libcamera.org/api/1.1/series/3028/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3028", "date": "2022-04-05T00:42:10", "name": "generate and use fixed-sized Span Control types", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3028/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15617/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15617/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E046C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Apr 2022 00:42:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C42265646;\n\tTue, 5 Apr 2022 02:42:26 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12F8A60397\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Apr 2022 02:42:23 +0200 (CEST)", "from localhost.localdomain ([92.10.251.63]) by mail.gmx.net\n\t(mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1Mel81-1oBQWR2bjR-00akda; Tue, 05 Apr 2022 02:42:22 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649119346;\n\tbh=1/elyQ8hHXseydij7lEbb9vqmTVhPoAJidVmASxCNro=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qHjpZ8PMGEdEfQq9IEmtbxKTye7wuC1rA1KjO10i2tC9q3eg3Ibslm/lVbRSuDFgp\n\tGVWEmkzrA3pKEiZg8JszdLhJ0Y8MEd06PoOjjumbwqT+5GvyRnV6KM4yWxtEsaETkm\n\tt/nO1FrrztkHqr0iTmPclLJa1cGHGNnxvqeV0+plCAjT3kuDLyt4TwDx69XbHk2T+n\n\tiVuMUOOOrGy81ByLZXG7/zvEq2sNFthKDhH+p4ljDyYME4xej/q8sDIiFRXCbGUVwv\n\t1tdJSBna+gfFuj1R1fmAcGMULsCH4r5y1vGG4EXlXUfBkabi7aDQj/TSdNvuaD8kOV\n\tQTvaYB0+vw5Og==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1649119342;\n\tbh=1/elyQ8hHXseydij7lEbb9vqmTVhPoAJidVmASxCNro=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=LNab4qirnsGnZbnh7TkO9j71vEacULG35uhuOLQrTJHNXv0R4OUGnsCiYRH0GF1mj\n\tprzKy+gN+e20WZxa0TncuEd+gazHlgeptbBvf19wmNxVpBY0s1HZmoc8StoUcMWbDK\n\tEwRjDvh0LN5RUpzqt+53U7BdSkNFBNQG7rVLi6zE=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"LNab4qir\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Apr 2022 01:42:13 +0100", "Message-Id": "<20220405004215.86340-4-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220405004215.86340-1-Rauch.Christian@gmx.de>", "References": "<20220405004215.86340-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:Zn2Z6kXd7Amjxo21NqWSWXVgNVLd/hyEctvEu2NHG6yPDbdPJ5l\n\tzfT0ZkNPHgFehQIoTEFq8mtkYGJ1aOVhxia5USu/3XGPLlHwJxVx0BbfLqratUroUG57l5O\n\t6CyOTjYmFzsigoAI3IBPzbco2Y+2T/iHD8kVsk7B3ZaJqEnQCPRdcMenEvBYixu1A21IDNa\n\tI0I2RL5obnbzbrISMerwQ==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:C3k3cmL33xY=:2KCCTMSOE4Vol02fNZIUSe\n\tORnvqIAmYXqq3MW1N3bcoy61OsfFlj/qr9YduFjIzYXkfJuKVTx7x8bulGXN/QzlXMw+muY0z\n\tThWehDHoYDj2flp0rcxdEU9xh/mMuiQ5GZqlLpXHOUqy88OMO4KJNXoko+eOuxmi8P02T6bBa\n\tPApD0wd1bDcqb1vGiNz3o86YQ08x3ACORAxfDUoP70oAli0erHN+6wkmQ7cX2eRmVUAw42X4i\n\tDpWZYN6j+umaiuDp6G6ygDssCzvLH+zfhgz3XlLYx5wlgV9/ZJetjjghinmEIxW2nC84aaF8k\n\t8yE8GPD6uRba+MJsE7YmSrpTp5qRam8xr/lGdRoprwOMHScMn/5gj5jUEfQ76QoAvtpPkgbqo\n\tRuvnhdw0QhRX+1ysJINE36WwDLB7RVYwpxrurLUBEweaSgnp4BxoxOwvEynSzyUIXerQIq1+o\n\teEhzPtBdGXik9D4eViytSZDZuXBRBIt07tydAM28I039tVLHK3L2Utao2SiNQqQgQV1wkTrqp\n\tcrwrL8RmCZEneBOs98r4UFq97v2G7Ps9bGqe7eu7j6rPKCKpLAzgUsLqcWpFwqRH668iSNP/8\n\tkEoc9iQpGH8kIWhls4hLzjprSvEnT6cc+Tnk1WaimJBFwQD7S6ZGFdst06WfjeH5m00Ot6G5k\n\tQtc0vhws8YXnGP/ym+Zh4NQyClkHMiKRemOVBS+y5oCRQiNFtZJrE1QBQ0Cn7Abx7UneWPVGn\n\tR3t70KLPK8ZWqaEmkx6LZEuSv1EFzIF1L7G3CbNY4nQOolcSmwMot6+hHAk3bYqCSwHZ1gVOh\n\tRnRXTk7WgibITea6Vnr/EvuE1aw6k829fb/RDijh4Sl84+M0jcSUdEoqllvFNlnJMYW/MVYD7\n\tYbEBfz/hJFlHdb9DxUPpQN7nrQ1OSkvX8lTzoozgSE7SIT/6Ny5MRXxUkRLV4aglyz813reOP\n\thH0QZIML6J+PwQYfCx/tIhYdJSuew0Bv+yeiCKWHHp/gEi3wlr+aGsW2afftfsX+DCfUi7VOi\n\tXC0fEyd05RECQz67rX81xN2eD7kAIT/Z1+FvCWyII7lqWXDm8LyCtnLje543YJ92dOIvGOa+u\n\tRHwRy4Qob96tTM=", "Subject": "[libcamera-devel] [PATCH v2 3/5] provide a default fixed-sized Span\n\tconstructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This allows to construct empty 0-fixed-sized Spans.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n include/libcamera/base/span.h | 2 --\n include/libcamera/controls.h | 2 +-\n 2 files changed, 1 insertion(+), 3 deletions(-)\n\n--\n2.25.1", "diff": "diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\nindex 88d2e3de..bff4c115 100644\n--- a/include/libcamera/base/span.h\n+++ b/include/libcamera/base/span.h\n@@ -105,8 +105,6 @@ public:\n\n \tstatic constexpr std::size_t extent = Extent;\n\n-\ttemplate<bool Dependent = false,\n-\t\t typename = std::enable_if_t<Dependent || Extent == 0>>\n \tconstexpr Span() noexcept\n \t\t: data_(nullptr)\n \t{\ndiff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 665bcac1..de8a7770 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -167,7 +167,7 @@ public:\n\n \t\tusing V = typename T::value_type;\n \t\tconst V *value = reinterpret_cast<const V *>(data().data());\n-\t\treturn { value, numElements_ };\n+\t\treturn T{ value, numElements_ };\n \t}\n\n #ifndef __DOXYGEN__\n", "prefixes": [ "libcamera-devel", "v2", "3/5" ] }