Patch Detail
Show a patch.
GET /api/1.1/patches/15596/?format=api
{ "id": 15596, "url": "https://patchwork.libcamera.org/api/1.1/patches/15596/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15596/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220331163058.171418-4-umang.jain@ideasonboard.com>", "date": "2022-03-31T16:30:55", "name": "[libcamera-devel,v4,3/6] ipa: ipu3: Inlink parseStatistics() into processStatsBuffer()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9db775efe8a775946703ce9224693c8be501a046", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15596/mbox/", "series": [ { "id": 3020, "url": "https://patchwork.libcamera.org/api/1.1/series/3020/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3020", "date": "2022-03-31T16:30:52", "name": "ipa: ipu3: Replace event-based ops with dedicated functions​", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3020/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15596/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15596/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1E02C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 31 Mar 2022 16:31:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A96CD65635;\n\tThu, 31 Mar 2022 18:31:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87F016563E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Mar 2022 18:31:21 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.74.73.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DD54486;\n\tThu, 31 Mar 2022 18:31:18 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648744283;\n\tbh=woaICZpi4vBYwSHNgQg1gJUb3iznCV2EVIobAILwSUI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=UoswSlTzITyyrVtFq4q3nOJ4Wayu3MfQ5+teQKMnTSQ/8Z8yAqqvIqdT0EuiYR5r/\n\tXwXi/IGOuYDv0yVZhxvfnG1GfcVrq6tT4ViUhkUMmlF2BceiIEMTXp0A7TDDyHhXn4\n\tmWC0jm2xjvamJXRwTCiDUd6azlVLC2zZy7Woc8szqCX61+EozmFnH9Oi9w8SKCu/Y+\n\tGAWJXWJpe8mGWzfEWGWktIj1KhmgvtXR9B1/94ITT9gIF6E/TtarMic9SNdIaD3AOC\n\tE73idVOwG4StqwnOJPwRswDjW8DHNk8f2PumSKY+b9xb5Z/+WMnyv7fT0EakBDx1CV\n\tvOyj8tP1F5vZg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648744281;\n\tbh=woaICZpi4vBYwSHNgQg1gJUb3iznCV2EVIobAILwSUI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=No02faHa8FgioXIT0FhUlV8+HTqWYXW7zL0Yhbf3H4cAnqjdxLV8+s1dR2lUGdL54\n\tYzFyOQXjn6tQQsdElCoJl/5pPllUCzOM1XG0AVrmuzhYncPUicH14ev200Xgr9gOxA\n\tzInjQFRotJNUcxHV61yZHQORvF3AECdh0282rlGU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"No02faHa\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 31 Mar 2022 22:00:55 +0530", "Message-Id": "<20220331163058.171418-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220331163058.171418-1-umang.jain@ideasonboard.com>", "References": "<20220331163058.171418-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/6] ipa: ipu3: Inlink\n\tparseStatistics() into processStatsBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since we have moved away from switch/case on the operation ID,\nthere's little reason to split the operation in two functions.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 54 +++++++++++++++----------------------------\n 1 file changed, 19 insertions(+), 35 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 23a9033e..605ca9a5 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -157,9 +157,6 @@ private:\n \t\t\t ControlInfoMap *ipaControls);\n \tvoid updateSessionConfiguration(const ControlInfoMap &sensorControls);\n \n-\tvoid parseStatistics(unsigned int frame,\n-\t\t\t int64_t frameTimestamp,\n-\t\t\t const ipu3_uapi_stats_3a *stats);\n \tbool validateSensorControls();\n \n \tvoid setControls(unsigned int frame);\n@@ -547,11 +544,15 @@ void IPAIPU3::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n }\n \n /**\n- * \\brief Process statistics after ISP completion\n+ * \\brief Process the statistics generated by the ImgU\n * \\param[in] frame The frame number\n * \\param[in] frameTimestamp Timestamp of the frame\n * \\param[in] bufferId ID of the statistics buffer\n * \\param[in] sensorControls Sensor controls\n+ *\n+ * Parse the most recently processed image statistics from the ImgU. The\n+ * statistics are passed to each algorithm module to run their calculations and\n+ * update their state accordingly.\n */\n void IPAIPU3::processStatsBuffer(const uint32_t frame, const int64_t frameTimestamp,\n \t\t\t\t const uint32_t bufferId, const ControlList &sensorControls)\n@@ -569,37 +570,6 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame, const int64_t frameTimest\n \tcontext_.frameContext.sensor.exposure = sensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n \tcontext_.frameContext.sensor.gain = camHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>());\n \n-\tparseStatistics(frame, frameTimestamp, stats);\n-}\n-\n-/**\n- * \\brief Queue a request and process the control list from the application\n- * \\param[in] frame The number of the frame which will be processed next\n- * \\param[in] controls The controls for the \\a frame\n- *\n- * Parse the request to handle any IPA-managed controls that were set from the\n- * application such as manual sensor settings.\n- */\n-void IPAIPU3::queueRequest(const uint32_t frame,\n-\t\t\t [[maybe_unused]] const ControlList &controls)\n-{\n-\t/* \\todo Start processing for 'frame' based on 'controls'. */\n-}\n-\n-/**\n- * \\brief Process the statistics generated by the ImgU\n- * \\param[in] frame The number of the latest frame processed\n- * \\param[in] frameTimestamp The current frame timestamp\n- * \\param[in] stats The IPU3 statistics and ISP results\n- *\n- * Parse the most recently processed image statistics from the ImgU. The\n- * statistics are passed to each algorithm module to run their calculations and\n- * update their state accordingly.\n- */\n-void IPAIPU3::parseStatistics(unsigned int frame,\n-\t\t\t [[maybe_unused]] int64_t frameTimestamp,\n-\t\t\t const ipu3_uapi_stats_3a *stats)\n-{\n \tdouble lineDuration = context_.configuration.sensor.lineDuration.get<std::micro>();\n \tint32_t vBlank = context_.configuration.sensor.defVBlank;\n \tControlList ctrls(controls::controls);\n@@ -630,6 +600,20 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \tmetadataReady.emit(frame, ctrls);\n }\n \n+/**\n+ * \\brief Queue a request and process the control list from the application\n+ * \\param[in] frame The number of the frame which will be processed next\n+ * \\param[in] controls The controls for the \\a frame\n+ *\n+ * Parse the request to handle any IPA-managed controls that were set from the\n+ * application such as manual sensor settings.\n+ */\n+void IPAIPU3::queueRequest(const uint32_t frame,\n+\t\t\t [[maybe_unused]] const ControlList &controls)\n+{\n+\t/* \\todo Start processing for 'frame' based on 'controls'. */\n+}\n+\n /**\n * \\brief Handle sensor controls for a given \\a frame number\n * \\param[in] frame The frame on which the sensor controls should be set\n", "prefixes": [ "libcamera-devel", "v4", "3/6" ] }