Patch Detail
Show a patch.
GET /api/1.1/patches/15595/?format=api
{ "id": 15595, "url": "https://patchwork.libcamera.org/api/1.1/patches/15595/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15595/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220331163058.171418-3-umang.jain@ideasonboard.com>", "date": "2022-03-31T16:30:54", "name": "[libcamera-devel,v4,2/6] ipa: ipu3: Inlink fillParams() in fillParamsBuffer()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4292f2ee3dc5a2ecb9ab40366184dba0217944cb", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15595/mbox/", "series": [ { "id": 3020, "url": "https://patchwork.libcamera.org/api/1.1/series/3020/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3020", "date": "2022-03-31T16:30:52", "name": "ipa: ipu3: Replace event-based ops with dedicated functions​", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3020/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15595/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15595/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69D19C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 31 Mar 2022 16:31:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12B826563A;\n\tThu, 31 Mar 2022 18:31:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1E646563D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Mar 2022 18:31:17 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.74.73.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D838486;\n\tThu, 31 Mar 2022 18:31:15 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648744279;\n\tbh=loseBciBXbXDa57acsv32QPhI9u/TYHzc6qK45tZQlY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ckqr9p+zenZo757u7ge8havhT7yzY2HUwaAb9enbB8nnokFOP5YsXY2vp7Szadu8i\n\t88y1JX118N/LAMnLHv9VSfqgaLk16oKG4r63dEbmUncxzbc0cg5mpxAjdW9RIecW8U\n\tyN6Obkm5urWJim/RNiyO2/9Xsp/CnuVPWx86FXfeaDohWb7Rtt8RYj+m8E66HYttGb\n\twMVQ87pDZGwg+k2BBObcyGqRfPhXizH1W6DuhCojPBP4Jrs6eI5O5SPSmBikC5x+Ka\n\txHOgEzc4ZaC8/WTvnr0tzL916rqgHdTg0zK9ffPgunsQ9dnIbc8OcQmeFHwq03D+I/\n\t7/A0UDhaqH0iA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648744277;\n\tbh=loseBciBXbXDa57acsv32QPhI9u/TYHzc6qK45tZQlY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=f1L1N9kpo/1QiBj5JEao3Pvnk9pM59v+2LHwAVVOu5GAmLv/NpDiTdK2tPtho+yPT\n\tN8mX6+Umb5w9VAVYJ1w8vF7EPUxx+qsyKq0cqw6EgFo8sYzbguv+UNzVKrsLEhtUWy\n\tzCahd2eprsTRFBwA+fyZJzu5E6sDEHMBo49R/1qI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f1L1N9kp\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 31 Mar 2022 22:00:54 +0530", "Message-Id": "<20220331163058.171418-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220331163058.171418-1-umang.jain@ideasonboard.com>", "References": "<20220331163058.171418-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 2/6] ipa: ipu3: Inlink fillParams() in\n\tfillParamsBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since we have moved away from switch/case on the operation ID,\nthere's little reason to split the operation in two functions.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 47 +++++++++++++++++--------------------------\n 1 file changed, 18 insertions(+), 29 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 7779ad58..23a9033e 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -157,7 +157,6 @@ private:\n \t\t\t ControlInfoMap *ipaControls);\n \tvoid updateSessionConfiguration(const ControlInfoMap &sensorControls);\n \n-\tvoid fillParams(unsigned int frame, ipu3_uapi_params *params);\n \tvoid parseStatistics(unsigned int frame,\n \t\t\t int64_t frameTimestamp,\n \t\t\t const ipu3_uapi_stats_3a *stats);\n@@ -514,6 +513,9 @@ void IPAIPU3::unmapBuffers(const std::vector<unsigned int> &ids)\n * \\brief Fill and return a buffer with ISP processing parameters for a frame\n * \\param[in] frame The frame number\n * \\param[in] bufferId ID of the parameter buffer to fill\n+ *\n+ * Algorithms are expected to fill the IPU3 parameter buffer for the next\n+ * frame given their most recent processing of the ImgU statistics.\n */\n void IPAIPU3::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n {\n@@ -527,7 +529,21 @@ void IPAIPU3::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n \tipu3_uapi_params *params =\n \t\treinterpret_cast<ipu3_uapi_params *>(mem.data());\n \n-\tfillParams(frame, params);\n+\t/*\n+\t * The incoming params buffer may contain uninitialised data, or the\n+\t * parameters of previously queued frames. Clearing the entire buffer\n+\t * may be an expensive operation, and the kernel will only read from\n+\t * structures which have their associated use-flag set.\n+\t *\n+\t * It is the responsibility of the algorithms to set the use flags\n+\t * accordingly for any data structure they update during prepare().\n+\t */\n+\tparams->use = {};\n+\n+\tfor (auto const &algo : algorithms_)\n+\t\talgo->prepare(context_, params);\n+\n+\tparamsBufferReady.emit(frame);\n }\n \n /**\n@@ -570,33 +586,6 @@ void IPAIPU3::queueRequest(const uint32_t frame,\n \t/* \\todo Start processing for 'frame' based on 'controls'. */\n }\n \n-/**\n- * \\brief Fill the ImgU parameter buffer for the next frame\n- * \\param[in] frame The number of the latest frame processed\n- * \\param[out] params The parameter buffer to fill\n- *\n- * Algorithms are expected to fill the IPU3 parameter buffer for the next\n- * frame given their most recent processing of the ImgU statistics.\n- */\n-void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n-{\n-\t/*\n-\t * The incoming params buffer may contain uninitialised data, or the\n-\t * parameters of previously queued frames. Clearing the entire buffer\n-\t * may be an expensive operation, and the kernel will only read from\n-\t * structures which have their associated use-flag set.\n-\t *\n-\t * It is the responsibility of the algorithms to set the use flags\n-\t * accordingly for any data structure they update during prepare().\n-\t */\n-\tparams->use = {};\n-\n-\tfor (auto const &algo : algorithms_)\n-\t\talgo->prepare(context_, params);\n-\n-\tparamsBufferReady.emit(frame);\n-}\n-\n /**\n * \\brief Process the statistics generated by the ImgU\n * \\param[in] frame The number of the latest frame processed\n", "prefixes": [ "libcamera-devel", "v4", "2/6" ] }