Patch Detail
Show a patch.
GET /api/1.1/patches/1557/?format=api
{ "id": 1557, "url": "https://patchwork.libcamera.org/api/1.1/patches/1557/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1557/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190701141336.10273-1-paul.elder@ideasonboard.com>", "date": "2019-07-01T14:13:35", "name": "[libcamera-devel,v2,1/2] libcamera: ipa_module: add path to module loading error message", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f27150db42d4a6737b8e299e9abd20d8ccbce29", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1557/mbox/", "series": [ { "id": 385, "url": "https://patchwork.libcamera.org/api/1.1/series/385/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=385", "date": "2019-07-01T14:13:35", "name": "[libcamera-devel,v2,1/2] libcamera: ipa_module: add path to module loading error message", "version": 2, "mbox": "https://patchwork.libcamera.org/series/385/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1557/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1557/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BCA360BF8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jul 2019 16:14:06 +0200 (CEST)", "from emerald.jp (p1871204-ipngn14001hodogaya.kanagawa.ocn.ne.jp\n\t[153.220.127.204])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 373B5524;\n\tMon, 1 Jul 2019 16:14:03 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561990445;\n\tbh=QI46z951yXa0ZXz+waiXvMA+TSDdRm3Ts6MdLE1hXy8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=lspj3O+uSBGXVShpkR9yTp7aNCPnT5iyOBwFmg7PcZJNqUW1knlr9NbGegm9KbNFw\n\tdr9RXMzHeurcbk4/dVsXEENbPrbNiomtdCuTsqP034JAI9uUhgJahD1KDoSYvtQbZn\n\tc8dF7K5NKo+7daRi9mKyNFCXKAh4BqFrAIO5pzUs=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 Jul 2019 23:13:35 +0900", "Message-Id": "<20190701141336.10273-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[libcamera-devel] [PATCH v2 1/2] libcamera: ipa_module: add path to\n\tmodule loading error message", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 01 Jul 2019 14:14:06 -0000" }, "content": "Add an error message to tell, if an IPA module failed to load, the\npath to the IPA module shared object that was attempted to be loaded.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nChanges in v2: don't show module version\n\n src/libcamera/ipa_module.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 58e8d1d..5a46ec3 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -286,6 +286,11 @@ int IPAModule::loadIPAModuleInfo()\n \t\tret = -EINVAL;\n \t}\n \n+\tif (ret)\n+\t\tLOG(IPAModule, Error)\n+\t\t\t<< \"Error loading IPA module at \"\n+\t\t\t<< libPath_;\n+\n unmap:\n \tmunmap(map, soSize);\n close:\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }