Patch Detail
Show a patch.
GET /api/1.1/patches/1556/?format=api
{ "id": 1556, "url": "https://patchwork.libcamera.org/api/1.1/patches/1556/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1556/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190630233817.10130-15-laurent.pinchart@ideasonboard.com>", "date": "2019-06-30T23:38:17", "name": "[libcamera-devel,v3,14/14,PoC] QCam: Control demo: A SineWave Brightness", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "20793195c5b0397c7a3a28cd97d8ed52f333212a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1556/mbox/", "series": [ { "id": 384, "url": "https://patchwork.libcamera.org/api/1.1/series/384/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=384", "date": "2019-06-30T23:38:03", "name": "libcamera Controls", "version": 3, "mbox": "https://patchwork.libcamera.org/series/384/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1556/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1556/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D282161F46\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jul 2019 01:38:46 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 895BB1200\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jul 2019 01:38:46 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561937926;\n\tbh=PIlqXsOiLQbKLx2Pi8tqvo7q5gEcHawdRl3WYeCSX6M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=reEWDUW0LplV9U/+f8NOGJPJmm6h4vlBAPcI25hCEppQm9dnd1mtH5c78vawSjnha\n\tNRE+RprmfBTM1Gbb9N9m3hyqmAqWyL5zgwrBZ0lFfxxhNg/CDOv6eb2AnUTGwNLX28\n\tqg5edINi775zL2JxJHZ0onQ5Ll8p1ZBJcq0/aP4M=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 Jul 2019 02:38:17 +0300", "Message-Id": "<20190630233817.10130-15-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190630233817.10130-1-laurent.pinchart@ideasonboard.com>", "References": "<20190630233817.10130-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 14/14] [PoC] QCam: Control demo: A\n\tSineWave Brightness", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 30 Jun 2019 23:38:47 -0000" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nAs an example of how to add a control to each request, set the\nBrightness value with a changing value against the buffer time stamps.\nThe Brightness will go up and down following a sine wave to visualise\nthe control effect on the video stream.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v2:\n\n- Take controls min/max values into account\n---\n src/qcam/main_window.cpp | 29 ++++++++++++++++++++++++++++-\n src/qcam/main_window.h | 3 +++\n 2 files changed, 31 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 16b123132dd9..bfd3af1e4b92 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -5,6 +5,7 @@\n * main_window.cpp - qcam - Main application window\n */\n \n+#include <cmath>\n #include <iomanip>\n #include <iostream>\n #include <string>\n@@ -21,7 +22,8 @@\n using namespace libcamera;\n \n MainWindow::MainWindow(const OptionsParser::Options &options)\n-\t: options_(options), isCapturing_(false)\n+\t: options_(options), isCapturing_(false),\n+\t brightness_(nullptr), gain_(nullptr)\n {\n \tint ret;\n \n@@ -88,6 +90,14 @@ int MainWindow::openCamera()\n \n \tstd::cout << \"Using camera \" << camera_->name() << std::endl;\n \n+\tconst ControlInfoMap &controls = camera_->controls();\n+\tauto iter = controls.find(Brightness);\n+\tif (iter != controls.end())\n+\t\tbrightness_ = &iter->second;\n+\titer = controls.find(ManualGain);\n+\tif (iter != controls.end())\n+\t\tgain_ = &iter->second;\n+\n \tcamera_->requestCompleted.connect(this, &MainWindow::requestComplete);\n \n \treturn 0;\n@@ -184,6 +194,14 @@ void MainWindow::stopCapture()\n \tconfig_.reset();\n }\n \n+static int sineWaveValue(Buffer *buffer, const ControlInfo *info)\n+{\n+\tunsigned int millisec = buffer->timestamp() / 1000000;\n+\tconstexpr float rads = 2 * M_PI / 180;\n+\treturn (sin(0.036 * rads * millisec) + 1) / 2 *\n+\t (info->max().getInt() - info->min().getInt());\n+}\n+\n void MainWindow::requestComplete(Request *request,\n \t\t\t\t const std::map<Stream *, Buffer *> &buffers)\n {\n@@ -213,6 +231,15 @@ void MainWindow::requestComplete(Request *request,\n \t\treturn;\n \t}\n \n+\t/*\n+\t * A demonstration control, which has a distinct visual effect.\n+\t * Scale the brightness up and down with a sine wave.\n+\t */\n+\tif (brightness_)\n+\t\trequest->controls()[Brightness] = sineWaveValue(buffer, brightness_);\n+\tif (gain_)\n+\t\trequest->controls()[ManualGain] = sineWaveValue(buffer, gain_);\n+\n \trequest->setBuffers(buffers);\n \tcamera_->queueRequest(request);\n }\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex fe565cbcb460..0a52399edc74 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -48,6 +48,9 @@ private:\n \tbool isCapturing_;\n \tstd::unique_ptr<CameraConfiguration> config_;\n \n+\tconst ControlInfo *brightness_;\n+\tconst ControlInfo *gain_;\n+\n \tViewFinder *viewfinder_;\n };\n \n", "prefixes": [ "libcamera-devel", "v3", "14/14", "PoC" ] }