Patch Detail
Show a patch.
GET /api/1.1/patches/15555/?format=api
{ "id": 15555, "url": "https://patchwork.libcamera.org/api/1.1/patches/15555/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15555/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220325092555.1799897-6-kieran.bingham@ideasonboard.com>", "date": "2022-03-25T09:25:55", "name": "[libcamera-devel,v3,5/5] ipa: ipu3: af: Simplify accumulations of y_items", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bbf3e3331307f9fda8e8f4010615ab8564d21e9c", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15555/mbox/", "series": [ { "id": 3000, "url": "https://patchwork.libcamera.org/api/1.1/series/3000/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3000", "date": "2022-03-25T09:25:50", "name": "ipa: ipu3: af: Small improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3000/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15555/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15555/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80495C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Mar 2022 09:26:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34B18604DA;\n\tFri, 25 Mar 2022 10:26:07 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8C62604E8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Mar 2022 10:26:01 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75D66E1F;\n\tFri, 25 Mar 2022 10:26:01 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648200367;\n\tbh=M1ZcY7OhxCoMapUJ81i5L9ddTveG40LiKFBBuN8qkIc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=T60q8uQqkwNABSi9x4xhvFB30UYFDSvZ++rC65Z7lBumqdHFwEDUAKrnZoPW8gAr7\n\tCJeuR2Mzv8KYYbT2o8J+IehMZbd7FfTZ0dv/VPTVbOwmTWLY/CXiJzZDn76dwIRnfQ\n\tcU723Uv4hG7dEjj7BImA0hlEsi9WhAd9gw67uJ03ynTEjR84P2XSd/uQ1X/SEbngGZ\n\tafyFFVS8iPn+fJwqfuas3IGotsB5eOOwCNWMUdWexFgnF2pGhQbBIVIdE5JbmnGgaV\n\tro76SO/3bhW4Gf38EYXcWUj/eqDOPkBRynwKnV0GgDxmGBq2f9pI0Y5a5CigDk4UPP\n\tV5Hr3WIh7hbdA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648200361;\n\tbh=M1ZcY7OhxCoMapUJ81i5L9ddTveG40LiKFBBuN8qkIc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PAakxMqA25BoHU/gLk+4sPyFf4rI8UAKNiBF7TsCpIfk1YSZnyf+7dM4yWl5Fwdmq\n\tWxoQVH4xLLDqnmKE0lE28QedZrFwpO5d8Os65u5uxpbg5Ut4EzmPP9SlcpCssoqXV1\n\tbR5ENA4cwMOjg6djaJ/c7qOm22VIV5OJqaOuj98A=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PAakxMqA\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>,\n\tKate Hsuan <hpa@redhat.com>,\n\tJean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "Date": "Fri, 25 Mar 2022 09:25:55 +0000", "Message-Id": "<20220325092555.1799897-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220325092555.1799897-1-kieran.bingham@ideasonboard.com>", "References": "<20220325092555.1799897-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 5/5] ipa: ipu3: af: Simplify\n\taccumulations of y_items", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Simplify the accumulation of the total and variance with a ternary\noperator.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/af.cpp | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex c0f2d34368cb..6c25d02ec7f0 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -341,20 +341,14 @@ double Af::afEstimateVariance(Span<const y_table_item_t> y_items, bool isY1)\n \tdouble mean;\n \tdouble var_sum = 0;\n \n-\tfor (auto y : y_items) {\n-\t\tif (isY1)\n-\t\t\ttotal += y.y1_avg;\n-\t\telse\n-\t\t\ttotal += y.y2_avg;\n-\t}\n+\tfor (auto y : y_items)\n+\t\ttotal += isY1 ? y.y1_avg : y.y2_avg;\n \n \tmean = total / y_items.size();\n \n \tfor (auto y : y_items) {\n-\t\tif (isY1)\n-\t\t\tvar_sum += pow(y.y1_avg - mean, 2);\n-\t\telse\n-\t\t\tvar_sum += pow(y.y2_avg - mean, 2);\n+\t\tdouble avg = isY1 ? y.y1_avg : y.y2_avg;\n+\t\tvar_sum += pow(avg - mean, 2);\n \t}\n \n \treturn var_sum / y_items.size();\n", "prefixes": [ "libcamera-devel", "v3", "5/5" ] }