Patch Detail
Show a patch.
GET /api/1.1/patches/15542/?format=api
{ "id": 15542, "url": "https://patchwork.libcamera.org/api/1.1/patches/15542/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15542/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220325090903.880311-2-naush@raspberrypi.com>", "date": "2022-03-25T09:08:56", "name": "[libcamera-devel,v5,1/8] pipeline: raspberrypi: Avoid over-allocation for ISP Output 1", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53af004f828588596acebb54539b9c11ac8383f7", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15542/mbox/", "series": [ { "id": 2999, "url": "https://patchwork.libcamera.org/api/1.1/series/2999/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2999", "date": "2022-03-25T09:08:55", "name": "Raspberry Pi: Efficient start/stop/start sequences", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2999/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15542/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15542/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 734B5C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Mar 2022 09:09:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04446604E8;\n\tFri, 25 Mar 2022 10:09:09 +0100 (CET)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB55260136\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Mar 2022 10:09:07 +0100 (CET)", "by mail-wm1-x32d.google.com with SMTP id\n\ti67-20020a1c3b46000000b0038ce25c870dso506650wma.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Mar 2022 02:09:07 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:478c:773f:4734:d0bc])\n\tby smtp.gmail.com with ESMTPSA id\n\tc4-20020a056000184400b0020584c40778sm4915297wri.103.2022.03.25.02.09.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 25 Mar 2022 02:09:06 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648199349;\n\tbh=i63d6hUH3isSXt4iyQ9OeO4uzCK+/jYWFH31E+5m1HE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=maJJr/lxWpwyBLjqvrDnKkB0u0WCXZY1MjjFq/XJEX4nJE1ALx65wfrtrP4z4o8Xm\n\tQl7WBUH/fZ0DwUU3MJo+8lGjCokNE05TeRKx8VGDgqo6J9M2gcmBDMNFpbG+JGl+KC\n\tZDYME2RoD3EXh26Att8bewFb11LE5nsxzZXnw4Nb5uOCyNcUEojALtW/IAQYvKG9pR\n\t/gHaEiBg9ec8BKVQXWEJT+9XbVPShhoomQIm1wXerk+27zCZW5R02OTtlz2BEpVvzl\n\tNDfEaL8fGqX4fXuaokPjpR4TysmvbLiACbE5NpRd5pTfPT2zz1bXXAbLmjF8a7Fegt\n\t40HKN+p60AB7A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jcfkXUDyQsMHFwrfe/cenXQcfke3b/k+swts4GnZTjQ=;\n\tb=QKONn7bIny5rbEB1IRawLgBY5Z4KVqFDjp/SIvAJQ8DwN0PCBuNoMHuxI32GahvcRz\n\teqO0sU3F2+9M0yYX41CrqksAmxnvGKIEDDYfuI2w9BRHy1EoCV1pWw2O5Hdl/2hli9Xa\n\teHW3L2XdSmTP3k1Fq0evHMZVY0JPbyd5KbodmzsRCe4f9djV9Lj1wL9i+0TvTWqdBmVl\n\tPWZxJR6neY/ctpC3MFGInhnabzlo3mZhq/QscEBVKGdiBRKHluux2na6cOKiu2EknhmH\n\ttbbRxSWAXrtZCizTuZSzwxX3kFPoAT2Hf6PeoEXnbxO4aZHr4mJx1ga/ARa7/NC8BFFr\n\tQjkA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"QKONn7bI\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=jcfkXUDyQsMHFwrfe/cenXQcfke3b/k+swts4GnZTjQ=;\n\tb=QpmxKtSLgg2nnEkBlE7uYiPcY4mj7Df9jMcc5LdCpU1LulgTyLZlEP6NxjbeoH4mKw\n\txo3mfH2zL5Q31bl+x2UhyNKLQ0vTWebKtFyudYsQs1NrmziTluuR6gjgQx/CHa+J6+ZR\n\t8OVH+46/gfLzDkpGADNASbC6OGKgQV/KYdNaB1PS68XSfYztAg0TBS7C2d2ryApSaBZO\n\tiCDPXiS4Ng6MT9kyO5ejDHJyjeOCrHUfb5/max16pshfnbI2QwzNPqv7imipxeEmkcD/\n\tthlwVThJ8tUQhdRA3N7N8mA7QBOrWfMyyFgvyAr7rVihqlQmF0oZ6rr2xs+tfL/i+QjN\n\tgeDg==", "X-Gm-Message-State": "AOAM530tv9bPzfkpir8eis/EswaQA5X4M712FWu8WGaZLgUnFQUa6DHT\n\tdh/LMnew8vKTc7Ep3S/5CeMrVEcLVdtRgw==", "X-Google-Smtp-Source": "ABdhPJyJMrXtbzQcH0j9dBg+ovQ1CWKpvQ8gpOvHMZL+BxYXlI5ck2jQtGSK8fq2IGizT7XA85jEzA==", "X-Received": "by 2002:a1c:7219:0:b0:38c:a4f8:484f with SMTP id\n\tn25-20020a1c7219000000b0038ca4f8484fmr18069189wmc.99.1648199347157; \n\tFri, 25 Mar 2022 02:09:07 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 25 Mar 2022 09:08:56 +0000", "Message-Id": "<20220325090903.880311-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220325090903.880311-1-naush@raspberrypi.com>", "References": "<20220325090903.880311-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 1/8] pipeline: raspberrypi: Avoid\n\tover-allocation for ISP Output 1", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The V4L2DeviceFormat structure for the ISP Output 1 node was a copy of what is\nused ISP Output 0 node, but with the size changed. However, the plane size and\nstride values were not updated. So there is a possibility that the buffer might\nbe over-sized for the requested resolution.\n\nFix this by only copying the relevant fields from the ISP Output 0\nV4L2DeviceFormat structure, and let the device driver size the planes as needed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c2230199fed7..43e87a406036 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -845,11 +845,13 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t * colour denoise will not run.\n \t */\n \tif (!output1Set) {\n-\t\tV4L2DeviceFormat output1Format = format;\n+\t\tV4L2DeviceFormat output1Format;\n \t\tconstexpr Size maxDimensions(1200, 1200);\n \t\tconst Size limit = maxDimensions.boundedToAspectRatio(format.size);\n \n \t\toutput1Format.size = (format.size / 2).boundedTo(limit).alignedDownTo(2, 2);\n+\t\toutput1Format.colorSpace = format.colorSpace;\n+\t\toutput1Format.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420);\n \n \t\tLOG(RPI, Debug) << \"Setting ISP Output1 (internal) to \"\n \t\t\t\t<< output1Format.toString();\n", "prefixes": [ "libcamera-devel", "v5", "1/8" ] }