Patch Detail
Show a patch.
GET /api/1.1/patches/15495/?format=api
{ "id": 15495, "url": "https://patchwork.libcamera.org/api/1.1/patches/15495/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15495/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220322024155.6528-4-hpa@redhat.com>", "date": "2022-03-22T02:41:54", "name": "[libcamera-devel,3/4] ipa: ipu3: awb: AWB lock for AF scan", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f3a424cb28bf9cd66fe472e54c12e9078a651cd", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/1.1/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15495/mbox/", "series": [ { "id": 2981, "url": "https://patchwork.libcamera.org/api/1.1/series/2981/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2981", "date": "2022-03-22T02:41:51", "name": "ipa: ipu3: af: Temporarily suspend AWB and AE during AF scanning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2981/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15495/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15495/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4F0EC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Mar 2022 02:42:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8AF4E61FBD;\n\tTue, 22 Mar 2022 03:42:24 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F2F2604DB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 03:42:23 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n\t[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-542-Dp7vfjLZMpOxMUG8qwo3UA-1; Mon, 21 Mar 2022 22:42:21 -0400", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id E630B3803908\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 02:42:20 +0000 (UTC)", "from fedora.redhat.com (unknown [10.39.192.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 30B82C26E9D;\n\tTue, 22 Mar 2022 02:42:18 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647916944;\n\tbh=AyorgNFcvMPZMiAqo+E01o0z4Y9E8VtL9fb1qPyhsHc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ufPcLhqysId0R1Cs1xtOclWoTEs0h3h2dQcDPz+B5zkLUOCp2g2XqoKGt4GYNZFDO\n\t3EP1UC437VdYxokrrybC9ex6AwSLXawIrQVlI4U/rTH4kXuMkXQnn3URNPUR1UYksS\n\tkbbRe1OfifqGGPTUH2BGnuCGDluxExSZIuvMx9pMUw6aLDt3gD3q186o3Uf5A/YvS9\n\tljdBZoOTIin1UczxZQpIVUsgXGMAWcZiPD3JIHGsHIKD1UIeUpm25erFbEnh07jw67\n\tZDvU21NopuqUWTUhAj5LbS1JU02wDntJGwgcOc10+Fd4jcFth8i1dcvE49bUu+kyo7\n\tV4Dn8ep+ZgGtA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1647916942;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=eqQ98mKECq3Lt3koxQsSb8ZcOY2ca4TbRpxnx4YyeSI=;\n\tb=QUQ02fHcUsUivFEb3tYmGmnAIzy5FNXBJ4ImKEjfag0Dd1rZ9Ti+v8EV7RnFO9pwnNi54f\n\tme8w5LSknIP9pUXoibtZ7XvVyAODP2qlcPbWH409EsjoovrRr/BLddD6xqYcKi+jJNzoB9\n\tEwo3lPLuphKf9Qmw7CoATpejFHnCjOE=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"QUQ02fHc\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com" ], "X-MC-Unique": "Dp7vfjLZMpOxMUG8qwo3UA-1", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 22 Mar 2022 10:41:54 +0800", "Message-Id": "<20220322024155.6528-4-hpa@redhat.com>", "In-Reply-To": "<20220322024155.6528-1-hpa@redhat.com>", "References": "<20220322024155.6528-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[libcamera-devel] [PATCH 3/4] ipa: ipu3: awb: AWB lock for AF scan", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kate Hsuan via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Kate Hsuan <hpa@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the AF starts to perform the scan, AWB will be suspended to stabilize\nthe AF scene variance and improve the AF performance.\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 13 +++++++++++++\n src/ipa/ipu3/algorithms/awb.h | 1 +\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 87a6cc7a..328bd38d 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -384,11 +384,24 @@ void Awb::calculateWBGains(const ipu3_uapi_stats_3a *stats)\n \t}\n }\n \n+/**\n+ * \\brief Test the AF requested lock is exist.\n+ */\n+bool Awb::isAfRequestedLock(IPAContext context)\n+{\n+\tif (context.configuration.af.requireAeAwbLock)\n+\t\treturn true;\n+\telse\n+\t\treturn false;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::process\n */\n void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n {\n+\tif (isAfRequestedLock(context))\n+\t\treturn;\n \tcalculateWBGains(stats);\n \n \t/*\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex ab4b0a33..9673592f 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -72,6 +72,7 @@ private:\n \tvoid awbGreyWorld();\n \tuint32_t estimateCCT(double red, double green, double blue);\n \tstatic constexpr uint16_t threshold(float value);\n+\tbool isAfRequestedLock(IPAContext context);\n \n \tstd::vector<RGB> zones_;\n \tAccumulator awbStats_[kAwbStatsSizeX * kAwbStatsSizeY];\n", "prefixes": [ "libcamera-devel", "3/4" ] }