Patch Detail
Show a patch.
GET /api/1.1/patches/15440/?format=api
{ "id": 15440, "url": "https://patchwork.libcamera.org/api/1.1/patches/15440/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15440/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220310205130.336361-3-umang.jain@ideasonboard.com>", "date": "2022-03-10T20:51:29", "name": "[libcamera-devel,2/3] ipa: ipu3: Mark the beginning and end of a frame", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "904a0742fa37ed639776c8d341852732263c6dd8", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15440/mbox/", "series": [ { "id": 2958, "url": "https://patchwork.libcamera.org/api/1.1/series/2958/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2958", "date": "2022-03-10T20:51:27", "name": "ipa: ipu3: IPAFrameContext Queue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2958/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15440/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15440/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B2C4BF415\r\n\tfor <parsemail@patchwork.libcamera.org>;\r\n\tThu, 10 Mar 2022 20:51:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AABEF632ED;\r\n\tThu, 10 Mar 2022 21:51:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 964F5604E9\r\n\tfor <libcamera-devel@lists.libcamera.org>;\r\n\tThu, 10 Mar 2022 21:51:42 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.203])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25109491;\r\n\tThu, 10 Mar 2022 21:51:40 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1646945503;\r\n\tbh=VO8/u67fpPf51y20xXn2IZR/lGfY0XBRVR13z/rHl3Y=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=K2MYaQDW5no1y9o3kSi8tuHntAcKHN+H0IlaTUR7lWoHs11kOJTr3N1nWesiJZFCG\r\n\te3Cmr+efKbH3Q7/UpcsD7AYxoBpeNNdTzBSH+IZdSAEppTCUjnGqDQyA56lpiH6wc9\r\n\t855w/RC8MMW1bpNVG9PvHpr71LrGoqC1H3FVUZhDRpxmGOXz6t2xx0u3NtjJqJnpkA\r\n\tkKbJ5JzjTbXzsIzdlt7d4QiB7x55DJbvHzGb15acwRl+muetzHLnXcaIVpeVPywk8l\r\n\teLBD4DcbxyEr5hPN+y+f1nld6aK0mZyKtVFvz49RTzJMSptqj4eD6Jawh84b6lpadV\r\n\tonA1BEZp0C4kw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1646945502;\r\n\tbh=VO8/u67fpPf51y20xXn2IZR/lGfY0XBRVR13z/rHl3Y=;\r\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\r\n\tb=R6gv7PjyoO2s+hlvODfxfPzo1z6qmhZbVxBJTn6Jljkxmxjo0kmzfQYYXFgVd5Yok\r\n\tmb1NfyXO1uZdBlzspAXykK1lJwpOyK9C4+7UB0GO5E6MrYmCoUvivPtd//se5KjZqX\r\n\tOidPG4WCWU5Wc9M1CJtwKm4INPnChlvqkBm/ZjLQ=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"R6gv7Pjy\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 11 Mar 2022 02:21:29 +0530", "Message-Id": "<20220310205130.336361-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220310205130.336361-1-umang.jain@ideasonboard.com>", "References": "<20220310205130.336361-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] ipa: ipu3: Mark the beginning and end\r\n\tof a frame", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\r\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n\nIntroduce the skeleton for two functions which will be used to\ninstantiate a frame context, and do everything needed when a frame is\nreceived. Do the same for the other end, once the algorithms have run\nand updated the frame context to later deallocate the corresponding\nframe context.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\r\nindex 81788b9a..3d5c5706 100644\r\n--- a/src/ipa/ipu3/ipu3.cpp\r\n+++ b/src/ipa/ipu3/ipu3.cpp\r\n@@ -163,6 +163,14 @@ private:\r\n \tvoid setControls(unsigned int frame);\r\n \tvoid calculateBdsGrid(const Size &bdsOutputSize);\r\n \r\n+\t/*\r\n+\t * Internal events that mark the beginning of processing a new frame\r\n+\t * to the point that it has successfully completed processing its\r\n+\t * statistics.\r\n+\t */\r\n+\tvoid frameStarted(const uint32_t frame);\r\n+\tvoid frameCompleted(const uint32_t frame);\r\n+\r\n \tstd::map<unsigned int, MappedFrameBuffer> buffers_;\r\n \r\n \tControlInfoMap ctrls_;\r\n@@ -491,6 +499,14 @@ void IPAIPU3::unmapBuffers(const std::vector<unsigned int> &ids)\r\n \t}\r\n }\r\n \r\n+void IPAIPU3::frameStarted([[maybe_unused]] const uint32_t frame)\r\n+{\r\n+}\r\n+\r\n+void IPAIPU3::frameCompleted([[maybe_unused]] const uint32_t frame)\r\n+{\r\n+}\r\n+\r\n /**\r\n * \\brief Prepare the ISP to process the Request\r\n * \\param[in] frame The frame number\r\n@@ -549,6 +565,8 @@ void IPAIPU3::processControls(const uint32_t frame,\r\n \t\t\t [[maybe_unused]] const ControlList &controls)\r\n {\r\n \t/* \\todo Start processing for 'frame' based on 'controls'. */\r\n+\r\n+\tframeStarted(frame);\r\n }\r\n \r\n /**\r\n@@ -620,6 +638,8 @@ void IPAIPU3::parseStatistics(unsigned int frame,\r\n \t */\r\n \r\n \tstatsBufferReady.emit(frame, ctrls);\r\n+\r\n+\tframeCompleted(frame);\r\n }\r\n \r\n /**", "prefixes": [ "libcamera-devel", "2/3" ] }