Patch Detail
Show a patch.
GET /api/1.1/patches/15416/?format=api
{ "id": 15416, "url": "https://patchwork.libcamera.org/api/1.1/patches/15416/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15416/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220303234956.1463551-10-djrscally@gmail.com>", "date": "2022-03-03T23:49:56", "name": "[libcamera-devel,v5,9/9] ipa: ipu3: Send lens controls to pipeline handler", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "37d1f08008277087bb6ca505013afb9554399a6e", "submitter": { "id": 90, "url": "https://patchwork.libcamera.org/api/1.1/people/90/?format=api", "name": "Daniel Scally", "email": "djrscally@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15416/mbox/", "series": [ { "id": 2950, "url": "https://patchwork.libcamera.org/api/1.1/series/2950/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2950", "date": "2022-03-03T23:49:47", "name": "Enumerate CameraLens by following sensor's ancillary links", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2950/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15416/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15416/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A166EBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Mar 2022 23:50:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63DFD6117C;\n\tFri, 4 Mar 2022 00:50:24 +0100 (CET)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40F7E61185\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Mar 2022 00:50:19 +0100 (CET)", "by mail-wm1-x332.google.com with SMTP id\n\tl2-20020a7bc342000000b0037fa585de26so4609116wmj.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 03 Mar 2022 15:50:19 -0800 (PST)", "from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\ty4-20020adff144000000b001f022290737sm3079779wro.6.2022.03.03.15.50.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Mar 2022 15:50:18 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"noxKmMvh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=xyaLrzB7F7z64em4nulRSPztY9ha3Adj1IEIasZ2qeM=;\n\tb=noxKmMvhdrMvAqmOaJ4fHQaBn3HXrGsPkKlj4Eu3MmkB76t3YDbaKsWFUcV4sgxDil\n\tRd9FWvb6teDVU8G1ic1C7WIjnLpe+J8xE+Q9XDPF5vkZkbQBTg5fqRKxtrVcA3ZtwQf2\n\t7ZQ52Tx5CECOA4L6kcHC/aEN8IK4e5/Ppyof3EWSD9PyTHpasJQWAGW+go5y4agD7pD6\n\tRN3YR7xX9MS+HrxLn2EC213b6NaQIhNuIjSskTPPS1kNReBBCMt7TPUUIedX8Ml6eHR9\n\ts17J4MBIbG3VlcVIPyxSJaciY4KqAepkCQI/sxglPKxJMjk7zt8SQNReHeWViPndMreS\n\txn5w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=xyaLrzB7F7z64em4nulRSPztY9ha3Adj1IEIasZ2qeM=;\n\tb=5UUnWlc59Zo6zdNwCr/giwaU1lmQXd6c4tbOLMrAOQ+2YzyzJQJm6AZxU/McJszLMY\n\t9xdXWT2+HOOA+ofmipcl24xwGQxUndZQ8W8XMkxt1G1i4iDmTGln/6dokvcXZr4/krOC\n\t+7rMEbNJAlahC/fHtOsacXZ+27IQedV4JjrGHQxKzZFpVreSdEKeY1YR5avOmXDUQkZA\n\tjoDCujoALNvJzIwKswJUTuJ08hNGOTVXRy58GYGkeVYWuE+dvQbK/QpW5l2wjEf6EMUz\n\thv9D/Rx5sbnla9KiPKkK9UzBOaO4q0Awh1wxeOgjIAJXUaZGaSuSXmt8R/uMyt2ZgILP\n\twiHg==", "X-Gm-Message-State": "AOAM532z4Z1qp9eTLlJ6vKrNqnaQyNhGOrocyeFcXLSWTQwChDJY/Rs6\n\tHRP3rnyrTdW9EKYQIcxU9in3GvfT3SbIsQ==", "X-Google-Smtp-Source": "ABdhPJzNcCWwn+b0N6IG1TPQJPDWsUOsQALcMlY6fxNARxRmAmCng35ePn0dypDV1fwRhkvOfCdpvQ==", "X-Received": "by 2002:a1c:1907:0:b0:380:f6ec:4daa with SMTP id\n\t7-20020a1c1907000000b00380f6ec4daamr5821262wmz.50.1646351419039; \n\tThu, 03 Mar 2022 15:50:19 -0800 (PST)", "From": "Daniel Scally <djrscally@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 3 Mar 2022 23:49:56 +0000", "Message-Id": "<20220303234956.1463551-10-djrscally@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220303234956.1463551-1-djrscally@gmail.com>", "References": "<20220303234956.1463551-1-djrscally@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 9/9] ipa: ipu3: Send lens controls to\n\tpipeline handler", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Pick up the focus value from the AF algorithm and send lens controls\nalong in the frame context.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\nChanges in v5:\n\n\t- None\n\nChanges in v4:\n\n\t- Got rid of the focus variable (Laurent)\n\nChanges in v3:\n\n\t- Replaced the new focus_ member with a local variable.\n\n src/ipa/ipu3/ipu3.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex e539d875..b8c4b30f 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -704,6 +704,11 @@ void IPAIPU3::setControls(unsigned int frame)\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain_));\n \top.sensorControls = ctrls;\n \n+\tControlList lensCtrls(lensCtrls_);\n+\tlensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE,\n+\t\t static_cast<int32_t>(context_.frameContext.af.focus));\n+\top.lensControls = lensCtrls;\n+\n \tqueueFrameAction.emit(frame, op);\n }\n \n", "prefixes": [ "libcamera-devel", "v5", "9/9" ] }