Patch Detail
Show a patch.
GET /api/1.1/patches/15412/?format=api
{ "id": 15412, "url": "https://patchwork.libcamera.org/api/1.1/patches/15412/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15412/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220303234956.1463551-6-djrscally@gmail.com>", "date": "2022-03-03T23:49:52", "name": "[libcamera-devel,v5,5/9] libcamera: camera_lens: Add function to fetch subdev controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4728489250600e81d519da328b2c736da48539f0", "submitter": { "id": 90, "url": "https://patchwork.libcamera.org/api/1.1/people/90/?format=api", "name": "Daniel Scally", "email": "djrscally@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15412/mbox/", "series": [ { "id": 2950, "url": "https://patchwork.libcamera.org/api/1.1/series/2950/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2950", "date": "2022-03-03T23:49:47", "name": "Enumerate CameraLens by following sensor's ancillary links", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2950/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15412/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15412/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1795CBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Mar 2022 23:50:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B749E6117D;\n\tFri, 4 Mar 2022 00:50:21 +0100 (CET)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFBEF6115E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Mar 2022 00:50:15 +0100 (CET)", "by mail-wm1-x330.google.com with SMTP id i66so4061253wma.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 03 Mar 2022 15:50:15 -0800 (PST)", "from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\ty4-20020adff144000000b001f022290737sm3079779wro.6.2022.03.03.15.50.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Mar 2022 15:50:15 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qiX+h+Ic\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=twowYbzifRY45WIFOEBJ8E7Wqy3IcerLbWOdfwHLE5A=;\n\tb=qiX+h+IcAFN0A3D19EfFx99ui4fN9Vm3Cd0KnV4Iv/mjIdAAPktaxbxc+q/mudw2aG\n\tG/vMqzum95RruyA/caF4Ha2FxRsF9swU7jzKVkSpGM3AKn1nN8/XY9JlohUDue8kjS1u\n\t48tyb7GHzETKvDbo8pmU0vlz0oAQYgijmW/bg3x+YEsWdSJktCwCpoh4Zj6tr6I2dufw\n\t0CwCGVOfI3fLNUBCZo8k3xgFYYAEbygzgvnPUgVYcFb0x2Ee49RNlDKrGOTuV+UFAlnh\n\tXy4wiXIJAl//k0rq/WuRQEYkOdsKXBVPHswshNduL3BBa/mqrMMOb0oxDjXX6mG+0ISn\n\tlMIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=twowYbzifRY45WIFOEBJ8E7Wqy3IcerLbWOdfwHLE5A=;\n\tb=vhJ9QLeRGQAkGcgqnptfsE8mkd+ejNsT7U/fpSaH1z67vcaIq0OEsbm7OVbjqxImHE\n\tpwQXMIEs+yTZZ6K48HVXOgpciAU7VOKLqWQbljJrZ3+VYoXtiRLdveewrijP6hz/nBhr\n\tFtABgLaZ3sBl4+qAvkktkVBnuVKsVrRhUxojFwI/EvShMHW5B5Q5wBhezqX1Mm9cKVvF\n\tjgi6RKFgEj3QiBRa5SWRbVfIRugZ7uX1GlCeD0wuUXdVLrqJHNoJyirNv5edpWRctyfr\n\tOMlg/xvKQsksH+OwmqVkxtZnOqIBkrta593vG3oPfpbmwppn4dghk2BXXpjpwAgOd0Av\n\tB2xg==", "X-Gm-Message-State": "AOAM532Y8KwClHYrbqNqb45aGF+jKL5NLi7E3zlAkymiWMKBdGHOAykF\n\tK0dCFnIMcGH9ayb5Ix54e46kWvwmwWQLhA==", "X-Google-Smtp-Source": "ABdhPJyq6mKQZ2Q6hfkreeOJqQGO8RsMt5o73LfdkZ6vJ1XQGWjlsf9A9LjTUguowUSk9fJJqpLLUQ==", "X-Received": "by 2002:a05:600c:4401:b0:387:1bcb:af41 with SMTP id\n\tu1-20020a05600c440100b003871bcbaf41mr5191796wmn.101.1646351415695; \n\tThu, 03 Mar 2022 15:50:15 -0800 (PST)", "From": "Daniel Scally <djrscally@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 3 Mar 2022 23:49:52 +0000", "Message-Id": "<20220303234956.1463551-6-djrscally@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220303234956.1463551-1-djrscally@gmail.com>", "References": "<20220303234956.1463551-1-djrscally@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 5/9] libcamera: camera_lens: Add\n\tfunction to fetch subdev controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a function to the CameraLens class to fetch the V4L2 controls\nfor its V4L2 subdev\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\nChanges in v5:\n\n\t- None\n\nChanges since v4:\n\n\t- None\n\nChanges in v3:\n\n\t- s/sensor/lens\n\n\n include/libcamera/internal/camera_lens.h | 4 ++++\n src/libcamera/camera_lens.cpp | 11 +++++++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\nindex 6f2ea1bc..64794294 100644\n--- a/include/libcamera/internal/camera_lens.h\n+++ b/include/libcamera/internal/camera_lens.h\n@@ -12,6 +12,8 @@\n #include <libcamera/base/class.h>\n #include <libcamera/base/log.h>\n \n+#include <libcamera/controls.h>\n+\n namespace libcamera {\n \n class MediaEntity;\n@@ -28,6 +30,8 @@ public:\n \n \tconst std::string &model() const { return model_; }\n \n+\tconst ControlInfoMap &controls() const;\n+\n protected:\n \tstd::string logPrefix() const override;\n \ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\nindex 189cb025..142390ed 100644\n--- a/src/libcamera/camera_lens.cpp\n+++ b/src/libcamera/camera_lens.cpp\n@@ -139,4 +139,15 @@ std::string CameraLens::logPrefix() const\n \treturn \"'\" + entity_->name() + \"'\";\n }\n \n+/**\n+ * \\fn CameraLens::controls()\n+ * \\brief Retrieve the V4L2 controls of the lens' subdev\n+ *\n+ * \\return A map of the V4L2 controls supported by the lens' driver\n+ */\n+const ControlInfoMap &CameraLens::controls() const\n+{\n+\treturn subdev_->controls();\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v5", "5/9" ] }