Patch Detail
Show a patch.
GET /api/1.1/patches/15398/?format=api
{ "id": 15398, "url": "https://patchwork.libcamera.org/api/1.1/patches/15398/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15398/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220302220304.1327896-2-djrscally@gmail.com>", "date": "2022-03-02T22:03:00", "name": "[libcamera-devel,v3,1/5] media: entity: Skip non-data links in graph iteration", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "4def1a7502cd5a0275e8a64b5c7985ea99fcfd1a", "submitter": { "id": 90, "url": "https://patchwork.libcamera.org/api/1.1/people/90/?format=api", "name": "Daniel Scally", "email": "djrscally@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15398/mbox/", "series": [ { "id": 2946, "url": "https://patchwork.libcamera.org/api/1.1/series/2946/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2946", "date": "2022-03-02T22:02:59", "name": "Introduce ancillary links", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2946/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15398/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15398/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87BFEBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Mar 2022 22:03:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D20861174;\n\tWed, 2 Mar 2022 23:03:18 +0100 (CET)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F18E601F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Mar 2022 23:03:15 +0100 (CET)", "by mail-wr1-x42e.google.com with SMTP id d3so4936943wrf.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 02 Mar 2022 14:03:15 -0800 (PST)", "from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tl16-20020a05600c4f1000b0033383cdeea1sm229258wmq.10.2022.03.02.14.03.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Mar 2022 14:03:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"I44u/jpu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=GHoWxwMyzuEiKYiB4tkgakdxydoJTJ1L6memTFq7bQY=;\n\tb=I44u/jpupuxrSxPrnEOPh8ns21kZ9UZQ5Fy9vLxB5XxM26XnG7gCk9Po5De1VeBfzg\n\twwoMS+uggL+SJNdR6GpwRq7Fbi84IL5WvMmiy+GOtXm+wSv0no3NgVW0IaHRkxtfFvVP\n\t09ghhpiXSRds8U3eggpxbNFELwL1WDBp+b+s6hn0nm2gdHI9bTkMjEurS8Yv5om98+P7\n\tReQJHjxcJtOYb9LxF2W2GUx7VfadwUsG7MdbaobofDz+cdiDf+VV8dxdA9sr7ayNuZv4\n\tLSB2y+6F6/He+jHNn5aLkD9kHzwjl1hCxfsZQh3cBuVV+c/5t6SDsBzMWdsi0EsNwANA\n\trBHw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=GHoWxwMyzuEiKYiB4tkgakdxydoJTJ1L6memTFq7bQY=;\n\tb=ucxmL0EkfEj+9uf92KuwWcG+jb2PE+pEpFp3g9MrFPNpxVXeczz+QSevCUuzKhHDfZ\n\tei4UuFcqywMjqf0nDXnHMPcxino6kslAW1xBGQ3cHvhoDcPgVTXLjMb3cI5cTMRVvHZv\n\teaiMM7U0GtXj7yvWlRVCuU8AkJP3zyGreItRFFoMwJWgJyo/kAgbsLKBQeqb67OGPpgc\n\t3GtCIRfTvNt4+ErPoCpDCyVrKOzYLgb4IRFAU+XqpdUc4KCzI2ZEFUOv7MphS1t0wMqO\n\tWmdSSlAmB8B7fJ8t96bd4zrUVHIkydOSzPTMSdTLjiLCIgAJiHqn6sUJq+5b3Oo7H/MR\n\t8qcQ==", "X-Gm-Message-State": "AOAM532tgbymhucBLSxsiyZ2Ib2i7T7LI3DGTMHlpMbrhY2UoAuY+lTJ\n\tVZZRx9hvKubhyjHwCTgozHI=", "X-Google-Smtp-Source": "ABdhPJxI+8FVaH+gF7/u1qQtIoi5tjku8H+S2JdkiyDFf7cktaVaYVQJuV9HhMc5hKyGUlmf9nwpKg==", "X-Received": "by 2002:adf:d1e3:0:b0:1ea:7e17:6cff with SMTP id\n\tg3-20020adfd1e3000000b001ea7e176cffmr24545717wrd.415.1646258594962; \n\tWed, 02 Mar 2022 14:03:14 -0800 (PST)", "From": "Daniel Scally <djrscally@gmail.com>", "To": "linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Mar 2022 22:03:00 +0000", "Message-Id": "<20220302220304.1327896-2-djrscally@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220302220304.1327896-1-djrscally@gmail.com>", "References": "<20220302220304.1327896-1-djrscally@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/5] media: entity: Skip non-data links\n\tin graph iteration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "sakari.ailus@linux.intel.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When iterating over the media graph, don't follow links that are not\ndata links.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\n\nChanges since v2:\n\n\t- None\n\nChanges since v1:\n\n\t- Moved to the head of the series\n\t- s/pad-to-pad/data (Sakari)\n\t- Dropped the debug message (Laurent)\n\nChanges since the rfc:\n\n\t- new patch\n\n drivers/media/mc/mc-entity.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\nindex b411f9796191..d0563ee4b28b 100644\n--- a/drivers/media/mc/mc-entity.c\n+++ b/drivers/media/mc/mc-entity.c\n@@ -295,6 +295,12 @@ static void media_graph_walk_iter(struct media_graph *graph)\n \n \tlink = list_entry(link_top(graph), typeof(*link), list);\n \n+\t/* If the link is not a data link, don't follow it */\n+\tif ((link->flags & MEDIA_LNK_FL_LINK_TYPE) != MEDIA_LNK_FL_DATA_LINK) {\n+\t\tlink_top(graph) = link_top(graph)->next;\n+\t\treturn;\n+\t}\n+\n \t/* The link is not enabled so we do not follow. */\n \tif (!(link->flags & MEDIA_LNK_FL_ENABLED)) {\n \t\tlink_top(graph) = link_top(graph)->next;\n", "prefixes": [ "libcamera-devel", "v3", "1/5" ] }