Patch Detail
Show a patch.
GET /api/1.1/patches/15379/?format=api
{ "id": 15379, "url": "https://patchwork.libcamera.org/api/1.1/patches/15379/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15379/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220224113347.80001-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2022-02-24T11:33:45", "name": "[libcamera-devel,v3,3/5] ipa: libipa: Histogram: Constify the constructor span", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "77ba6e4f01dea52add6dc0d3a5ef459edbb09d86", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15379/mbox/", "series": [ { "id": 2937, "url": "https://patchwork.libcamera.org/api/1.1/series/2937/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2937", "date": "2022-02-24T11:33:42", "name": "IPA RkISP1 awb and misc improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2937/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15379/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15379/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF177BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Feb 2022 11:33:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C0226115A;\n\tThu, 24 Feb 2022 12:33:58 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6787D61145\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Feb 2022 12:33:53 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce74:6df2:4b76:b230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 158C2DD;\n\tThu, 24 Feb 2022 12:33:53 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vqg1dhxi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645702433;\n\tbh=sMtrrj+EYo9kT3HadhZ0KuBYFvgSed4b65pLGeDwA5g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vqg1dhxi6lAUGTvGrQkctnJD9ffNy+Vy6AuBj+XTegRzSBfIM1va2A+haHCwpEuqY\n\tLWdJPMs1a/EhtTU7x5QUvIqG8qK1QcAn6ecTc5qCFk4pYcHWjvmFzgTrI0qDcmDOI2\n\t8fjkNTI+Vk4AE0VT7MIukMW+6+vefMzvJU7NQzkg=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Feb 2022 12:33:45 +0100", "Message-Id": "<20220224113347.80001-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 3/5] ipa: libipa: Histogram: Constify\n\tthe constructor span", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Histogram constructor does not modify the data. Pass it a Span<const\nuint32_t> instead of a Span<uint32_t>.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/libipa/histogram.cpp | 2 +-\n src/ipa/libipa/histogram.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\nindex 4d94571f..d8ad1c89 100644\n--- a/src/ipa/libipa/histogram.cpp\n+++ b/src/ipa/libipa/histogram.cpp\n@@ -32,7 +32,7 @@ namespace ipa {\n * \\brief Create a cumulative histogram\n * \\param[in] data A pre-sorted histogram to be passed\n */\n-Histogram::Histogram(Span<uint32_t> data)\n+Histogram::Histogram(Span<const uint32_t> data)\n {\n \tcumulative_.reserve(data.size());\n \tcumulative_.push_back(0);\ndiff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\nindex c40a366b..164d4603 100644\n--- a/src/ipa/libipa/histogram.h\n+++ b/src/ipa/libipa/histogram.h\n@@ -22,7 +22,7 @@ namespace ipa {\n class Histogram\n {\n public:\n-\tHistogram(Span<uint32_t> data);\n+\tHistogram(Span<const uint32_t> data);\n \tsize_t bins() const { return cumulative_.size() - 1; }\n \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n \tuint64_t cumulativeFrequency(double bin) const;\n", "prefixes": [ "libcamera-devel", "v3", "3/5" ] }