Patch Detail
Show a patch.
GET /api/1.1/patches/15339/?format=api
{ "id": 15339, "url": "https://patchwork.libcamera.org/api/1.1/patches/15339/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15339/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220207150136.22584-1-ecurtin@redhat.com>", "date": "2022-02-07T15:01:36", "name": "[libcamera-devel,v3] cam: kms-sink: Once we have found a suitable pipeline to select, return", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f09a0a19d5995b1fe9d5ba25f021b47ee5d34341", "submitter": { "id": 101, "url": "https://patchwork.libcamera.org/api/1.1/people/101/?format=api", "name": "Eric Curtin", "email": "ecurtin@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15339/mbox/", "series": [ { "id": 2920, "url": "https://patchwork.libcamera.org/api/1.1/series/2920/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2920", "date": "2022-02-07T15:01:36", "name": "[libcamera-devel,v3] cam: kms-sink: Once we have found a suitable pipeline to select, return", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2920/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15339/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15339/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E56BCBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Feb 2022 15:02:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 998D56105F;\n\tMon, 7 Feb 2022 16:02:01 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F95060E58\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Feb 2022 16:01:59 +0100 (CET)", "from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-278-YhVKGFa9OhiN_t-a2kCgZQ-1; Mon, 07 Feb 2022 10:01:50 -0500", "by mail-wr1-f71.google.com with SMTP id\n\ty10-20020adfc7ca000000b001e30ed3a496so1323671wrg.15\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 07 Feb 2022 07:01:50 -0800 (PST)", "from p1.Home ([2001:8a0:6724:4500:a69c:e66f:828e:b340])\n\tby smtp.gmail.com with ESMTPSA id\n\tf8sm12137173wry.12.2022.02.07.07.01.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Feb 2022 07:01:48 -0800 (PST)" ], "Authentication-Results": [ "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"H9otRWQH\"; dkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1644246118;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=srUK9hQeqGAK4NbQmvnHpEP72CHFXPrLkcdrFKRFfTU=;\n\tb=H9otRWQHRewln8hG4kyzA6cO5XXsd0cgUuWfs5+euw2CKq7Mch0AQm/Ws2SZPw1GlABVL1\n\ttjeuoJ7Vfm4gl639qT31Sjqwuqj2ByZttdEzgaTqrblDHJMkF/EtnSexWD25HrG234vl9B\n\tU4pEgw+bD73eRbixsrYGV4SDZl00WW8=", "X-MC-Unique": "YhVKGFa9OhiN_t-a2kCgZQ-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=srUK9hQeqGAK4NbQmvnHpEP72CHFXPrLkcdrFKRFfTU=;\n\tb=guOdu/woQa+AYh+gKhaHw1AMrbWVS2sOaw858VA3YrwWN/UXYksPh4f1f7/Sil7Qib\n\trrH5LKggDo1Mr/ZcUcTRmNlUulUKnaizQiOW3u41fitZukM2EY6Fv8oI/UzQ+qeWKSTy\n\tAQSWkC4czMZItmEcv13wfRl80OYPPyzYiJ4BMY5UMxaFWBSOQJ/3C9FqdFD4tz4gOEXO\n\tXaBfqEKCC1JQDsMZzYH/qBbS76ls33Vxq8J+gf2Ir1EWApA9QOPaDgpI1LjlSn5cqhyB\n\tPwduKqyrDZtGy0G67HHSC7lH5guarOOuxcVLu2nNBDsGbliEAp5oYIh8mxzxvE6W6eNQ\n\tL8aA==", "X-Gm-Message-State": "AOAM532I6CwTwCms8omMEY53Soux9ZL0XZ5UqM9eWrqMsw/cut87auGc\n\tmjT1KTVqxoHid6Pj0J0v8CDkPmRrXvJ48ayLf1ug4vn2bwwfRfiVEnCumyEtwbTV0wpmWmCTmsv\n\tNbkBLo37xZQeI/MdDXzKD4bo6jYJqtJRb7psK8yCBgviwP7l3oVAs/Kw3qc6P1HaCVlR3ZCnBam\n\tCmBOCcd4mx", "X-Received": [ "by 2002:a5d:64a9:: with SMTP id\n\tm9mr10069143wrp.661.1644246109204; \n\tMon, 07 Feb 2022 07:01:49 -0800 (PST)", "by 2002:a5d:64a9:: with SMTP id\n\tm9mr10069130wrp.661.1644246108999; \n\tMon, 07 Feb 2022 07:01:48 -0800 (PST)" ], "X-Google-Smtp-Source": "ABdhPJzvueZhiCUNKSxEfKtg2ed+aHINaWyWBlQR8K48wfbrjjDSWWXUFnVH0/LvV6VsQ5tmtcsvoQ==", "From": "Eric Curtin <ecurtin@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 7 Feb 2022 15:01:36 +0000", "Message-Id": "<20220207150136.22584-1-ecurtin@redhat.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[libcamera-devel] [PATCH v3] cam: kms-sink: Once we have found a\n\tsuitable pipeline to select, return", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The break only breaks out of the innermost loop which is not the most\noptimal. It also breaks cam on my machines.\n\nFixes: 1de0f90dd432 (\"cam: kms_sink: Print display pipelineconfiguration\")\nSigned-off-by: Eric Curtin <ecurtin@redhat.com>\n---\n\nChanges in v3:\n- Add \"cam: kms_sink:\" tag\n\nChanges in v2:\n- Change function name to selectPipeline\n- Return int rather than pointer\n- Formatting\n- Mention in commit message that it fixes a bug on my machine also\n\n src/cam/kms_sink.cpp | 18 ++++++++++++------\n src/cam/kms_sink.h | 1 +\n 2 files changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/cam/kms_sink.cpp b/src/cam/kms_sink.cpp\nindex d30fba78..973cd370 100644\n--- a/src/cam/kms_sink.cpp\n+++ b/src/cam/kms_sink.cpp\n@@ -136,7 +136,7 @@ int KMSSink::configure(const libcamera::CameraConfiguration &config)\n \treturn 0;\n }\n \n-int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n+int KMSSink::selectPipeline(const libcamera::PixelFormat &format)\n {\n \t/*\n \t * If the requested format has an alpha channel, also consider the X\n@@ -174,25 +174,31 @@ int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n \t\t\t\t\tcrtc_ = crtc;\n \t\t\t\t\tplane_ = plane;\n \t\t\t\t\tformat_ = format;\n-\t\t\t\t\tbreak;\n+\t\t\t\t\treturn 0;\n \t\t\t\t}\n \n \t\t\t\tif (plane->supportsFormat(xFormat)) {\n \t\t\t\t\tcrtc_ = crtc;\n \t\t\t\t\tplane_ = plane;\n \t\t\t\t\tformat_ = xFormat;\n-\t\t\t\t\tbreak;\n+\t\t\t\t\treturn 0;\n \t\t\t\t}\n \t\t\t}\n \t\t}\n \t}\n \n-\tif (!crtc_) {\n+\treturn -EPIPE;\n+}\n+\n+int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n+{\n+\tconst int ret = selectPipeline(format);\n+\tif (ret) {\n \t\tstd::cerr\n \t\t\t<< \"Unable to find display pipeline for format \"\n \t\t\t<< format.toString() << std::endl;\n \n-\t\treturn -EPIPE;\n+\t\treturn ret;\n \t}\n \n \tstd::cout\n@@ -200,7 +206,7 @@ int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n \t\t<< \", connector \" << connector_->name()\n \t\t<< \" (\" << connector_->id() << \")\" << std::endl;\n \n-\treturn 0;\n+\treturn ret;\n }\n \n int KMSSink::start()\ndiff --git a/src/cam/kms_sink.h b/src/cam/kms_sink.h\nindex 1e4290ad..4a0a872c 100644\n--- a/src/cam/kms_sink.h\n+++ b/src/cam/kms_sink.h\n@@ -47,6 +47,7 @@ private:\n \t\tlibcamera::Request *camRequest_;\n \t};\n \n+\tint selectPipeline(const libcamera::PixelFormat &format);\n \tint configurePipeline(const libcamera::PixelFormat &format);\n \tvoid requestComplete(DRM::AtomicRequest *request);\n \n", "prefixes": [ "libcamera-devel", "v3" ] }