Patch Detail
Show a patch.
GET /api/1.1/patches/15331/?format=api
{ "id": 15331, "url": "https://patchwork.libcamera.org/api/1.1/patches/15331/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15331/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220204133814.303217-5-tomi.valkeinen@ideasonboard.com>", "date": "2022-02-04T13:38:13", "name": "[libcamera-devel,v4,4/5] py: add unittests.py", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3a51b412074f691a4a7f177b5b3f5d25ad878c0c", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15331/mbox/", "series": [ { "id": 2916, "url": "https://patchwork.libcamera.org/api/1.1/series/2916/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2916", "date": "2022-02-04T13:38:09", "name": "Python bindings", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2916/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15331/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15331/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7287BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Feb 2022 13:38:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55E5A609FF;\n\tFri, 4 Feb 2022 14:38:48 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67E56609F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Feb 2022 14:38:44 +0100 (CET)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE96D475;\n\tFri, 4 Feb 2022 14:38:43 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jtOMakOb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643981924;\n\tbh=MBBTki4/Xe1DZDjwSd1vXjfdBBQka67MCyaPDz0lnVQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jtOMakObsgQFv9rsYTPWaRE1lCA9kNaLIrYh9/15ecacXmI0SgoatFTwmDpihmaF1\n\tqv4M8i+BPBubBHQ0Oky28tCccNicFd1x42m3Hj5Z7HR7psFcvIp2qjkKLEG2+GWvec\n\tzVMW4DGunJSbFLQO8XH/UI6NjKRP+M4v/CQXBhIs=", "From": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 4 Feb 2022 15:38:13 +0200", "Message-Id": "<20220204133814.303217-5-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220204133814.303217-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220204133814.303217-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/5] py: add unittests.py", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a simple unittests.py as a base for python unittests.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/test/unittests.py | 366 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 366 insertions(+)\n create mode 100755 src/py/test/unittests.py", "diff": "diff --git a/src/py/test/unittests.py b/src/py/test/unittests.py\nnew file mode 100755\nindex 00000000..5fe29fd9\n--- /dev/null\n+++ b/src/py/test/unittests.py\n@@ -0,0 +1,366 @@\n+#!/usr/bin/env python3\n+\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2021, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n+\n+from collections import defaultdict\n+import errno\n+import gc\n+import libcamera as libcam\n+import os\n+import os\n+import selectors\n+import selectors\n+import time\n+import unittest\n+import weakref\n+\n+class MyTestCase(unittest.TestCase):\n+\tdef assertZero(self, a, msg=None):\n+\t\tself.assertEqual(a, 0, msg)\n+\n+class SimpleTestMethods(MyTestCase):\n+\tdef test_find_ref(self):\n+\t\tcm = libcam.CameraManager.singleton()\n+\t\twr_cm = weakref.ref(cm)\n+\n+\t\tcam = cm.find(\"platform/vimc\")\n+\t\tself.assertIsNotNone(cam)\n+\t\twr_cam = weakref.ref(cam)\n+\n+\t\tcm = None\n+\t\tgc.collect()\n+\t\tself.assertIsNotNone(wr_cm())\n+\n+\t\tcam = None\n+\t\tgc.collect()\n+\t\tself.assertIsNone(wr_cm())\n+\t\tself.assertIsNone(wr_cam())\n+\n+\tdef test_get_ref(self):\n+\t\tcm = libcam.CameraManager.singleton()\n+\t\twr_cm = weakref.ref(cm)\n+\n+\t\tcam = cm.get(\"platform/vimc.0 Sensor B\")\n+\t\tself.assertTrue(cam != None)\n+\t\twr_cam = weakref.ref(cam)\n+\n+\t\tcm = None\n+\t\tgc.collect()\n+\t\tself.assertIsNotNone(wr_cm())\n+\n+\t\tcam = None\n+\t\tgc.collect()\n+\t\tself.assertIsNone(wr_cm())\n+\t\tself.assertIsNone(wr_cam())\n+\n+\tdef test_acquire_release(self):\n+\t\tcm = libcam.CameraManager.singleton()\n+\t\tcam = cm.get(\"platform/vimc.0 Sensor B\")\n+\t\tself.assertTrue(cam != None)\n+\n+\t\tret = cam.acquire()\n+\t\tself.assertZero(ret)\n+\n+\t\tret = cam.release()\n+\t\tself.assertZero(ret)\n+\n+\tdef test_double_acquire(self):\n+\t\tcm = libcam.CameraManager.singleton()\n+\t\tcam = cm.get(\"platform/vimc.0 Sensor B\")\n+\t\tself.assertTrue(cam != None)\n+\n+\t\tret = cam.acquire()\n+\t\tself.assertZero(ret)\n+\n+\t\tlibcam.logSetLevel(\"Camera\", \"FATAL\")\n+\t\tret = cam.acquire()\n+\t\tself.assertEqual(ret, -errno.EBUSY)\n+\t\tlibcam.logSetLevel(\"Camera\", \"ERROR\")\n+\n+\t\tret = cam.release()\n+\t\tself.assertZero(ret)\n+\n+\t\tret = cam.release()\n+\t\t# I expected EBUSY, but looks like double release works fine\n+\t\tself.assertZero(ret)\n+\n+class CameraTesterBase(MyTestCase):\n+\tdef setUp(self):\n+\t\tself.cm = libcam.CameraManager.singleton()\n+\t\tself.cam = self.cm.find(\"platform/vimc\")\n+\t\tif self.cam == None:\n+\t\t\tself.cm = None\n+\t\t\traise Exception(\"No vimc found\")\n+\n+\t\tret = self.cam.acquire()\n+\t\tif ret != 0:\n+\t\t\tself.cam = None\n+\t\t\tself.cm = None\n+\t\t\traise Exception(\"Failed to acquire camera\")\n+\n+\tdef tearDown(self):\n+\t\t# If a test fails, the camera may be in running state. So always stop.\n+\t\tself.cam.stop()\n+\n+\t\tret = self.cam.release()\n+\t\tif ret != 0:\n+\t\t\traise Exception(\"Failed to release camera\")\n+\n+\t\tself.cam = None\n+\t\tself.cm = None\n+\n+\n+class AllocatorTestMethods(CameraTesterBase):\n+\tdef test_allocator(self):\n+\t\tcam = self.cam\n+\n+\t\tcamconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\n+\t\tself.assertTrue(camconfig.size == 1)\n+\t\twr_camconfig = weakref.ref(camconfig)\n+\n+\t\tstreamconfig = camconfig.at(0)\n+\t\twr_streamconfig = weakref.ref(streamconfig)\n+\n+\t\tret = cam.configure(camconfig);\n+\t\tself.assertZero(ret)\n+\n+\t\tstream = streamconfig.stream\n+\t\twr_stream = weakref.ref(stream)\n+\n+\t\t# stream should keep streamconfig and camconfig alive\n+\t\tstreamconfig = None\n+\t\tcamconfig = None\n+\t\tgc.collect()\n+\t\tself.assertIsNotNone(wr_camconfig())\n+\t\tself.assertIsNotNone(wr_streamconfig())\n+\n+\t\tallocator = libcam.FrameBufferAllocator(cam);\n+\t\tret = allocator.allocate(stream)\n+\t\tself.assertTrue(ret > 0)\n+\t\twr_allocator = weakref.ref(allocator)\n+\n+\t\tbuffers = allocator.buffers(stream)\n+\t\tbuffers = None\n+\n+\n+\t\tbuffer = allocator.buffers(stream)[0]\n+\t\tself.assertIsNotNone(buffer)\n+\t\twr_buffer = weakref.ref(buffer)\n+\n+\t\tallocator = None\n+\t\tgc.collect()\n+\t\tself.assertIsNotNone(wr_buffer())\n+\t\tself.assertIsNotNone(wr_allocator())\n+\t\tself.assertIsNotNone(wr_stream())\n+\n+\t\tbuffer = None\n+\t\tgc.collect()\n+\t\tself.assertIsNone(wr_buffer())\n+\t\tself.assertIsNone(wr_allocator())\n+\t\tself.assertIsNotNone(wr_stream())\n+\n+\t\tstream = None\n+\t\tgc.collect()\n+\t\tself.assertIsNone(wr_stream())\n+\t\tself.assertIsNone(wr_camconfig())\n+\t\tself.assertIsNone(wr_streamconfig())\n+\n+\n+class SimpleCaptureMethods(CameraTesterBase):\n+\tdef test_sleep(self):\n+\t\tcm = self.cm\n+\t\tcam = self.cam\n+\n+\t\tcamconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\n+\t\tself.assertTrue(camconfig.size == 1)\n+\n+\t\tstreamconfig = camconfig.at(0)\n+\t\tfmts = streamconfig.formats\n+\n+\t\tret = cam.configure(camconfig);\n+\t\tself.assertZero(ret)\n+\n+\t\tstream = streamconfig.stream\n+\n+\t\tallocator = libcam.FrameBufferAllocator(cam);\n+\t\tret = allocator.allocate(stream)\n+\t\tself.assertTrue(ret > 0)\n+\n+\t\tnum_bufs = len(allocator.buffers(stream))\n+\n+\t\treqs = []\n+\t\tfor i in range(num_bufs):\n+\t\t\treq = cam.createRequest(i)\n+\t\t\tself.assertIsNotNone(req)\n+\n+\t\t\tbuffer = allocator.buffers(stream)[i]\n+\t\t\tret = req.addBuffer(stream, buffer)\n+\t\t\tself.assertZero(ret)\n+\n+\t\t\treqs.append(req)\n+\n+\t\tbuffer = None\n+\n+\t\tret = cam.start()\n+\t\tself.assertZero(ret)\n+\n+\t\tfor req in reqs:\n+\t\t\tret = cam.queueRequest(req)\n+\t\t\tself.assertZero(ret)\n+\n+\t\treqs = None\n+\t\tgc.collect()\n+\n+\t\ttime.sleep(0.5)\n+\n+\t\treqs = cm.getReadyRequests()\n+\n+\t\tself.assertTrue(len(reqs) == num_bufs)\n+\n+\t\tfor i, req in enumerate(reqs):\n+\t\t\tself.assertTrue(i == req.cookie)\n+\n+\t\treqs = None\n+\t\tgc.collect()\n+\n+\t\tret = cam.stop()\n+\t\tself.assertZero(ret)\n+\n+\n+\tdef test_select(self):\n+\t\tcm = self.cm\n+\t\tcam = self.cam\n+\n+\t\tcamconfig = cam.generateConfiguration([libcam.StreamRole.StillCapture])\n+\t\tself.assertTrue(camconfig.size == 1)\n+\n+\t\tstreamconfig = camconfig.at(0)\n+\t\tfmts = streamconfig.formats\n+\n+\t\tret = cam.configure(camconfig);\n+\t\tself.assertZero(ret)\n+\n+\t\tstream = streamconfig.stream\n+\n+\t\tallocator = libcam.FrameBufferAllocator(cam);\n+\t\tret = allocator.allocate(stream)\n+\t\tself.assertTrue(ret > 0)\n+\n+\t\tnum_bufs = len(allocator.buffers(stream))\n+\n+\t\treqs = []\n+\t\tfor i in range(num_bufs):\n+\t\t\treq = cam.createRequest(i)\n+\t\t\tself.assertIsNotNone(req)\n+\n+\t\t\tbuffer = allocator.buffers(stream)[i]\n+\t\t\tret = req.addBuffer(stream, buffer)\n+\t\t\tself.assertZero(ret)\n+\n+\t\t\treqs.append(req)\n+\n+\t\tbuffer = None\n+\n+\t\tret = cam.start()\n+\t\tself.assertZero(ret)\n+\n+\t\tfor req in reqs:\n+\t\t\tret = cam.queueRequest(req)\n+\t\t\tself.assertZero(ret)\n+\n+\t\treqs = None\n+\t\tgc.collect()\n+\n+\t\tsel = selectors.DefaultSelector()\n+\t\tsel.register(cm.efd, selectors.EVENT_READ, 123)\n+\n+\t\treqs = []\n+\n+\t\trunning = True\n+\t\twhile running:\n+\t\t\tevents = sel.select()\n+\t\t\tfor key, mask in events:\n+\t\t\t\tos.read(key.fileobj, 8)\n+\n+\t\t\t\tl = cm.getReadyRequests()\n+\n+\t\t\t\tself.assertTrue(len(l) > 0)\n+\n+\t\t\t\treqs += l\n+\n+\t\t\t\tif len(reqs) == num_bufs:\n+\t\t\t\t\trunning = False\n+\n+\t\tself.assertTrue(len(reqs) == num_bufs)\n+\n+\t\tfor i, req in enumerate(reqs):\n+\t\t\tself.assertTrue(i == req.cookie)\n+\n+\t\treqs = None\n+\t\tgc.collect()\n+\n+\t\tret = cam.stop()\n+\t\tself.assertZero(ret)\n+\n+\n+\n+# Recursively expand slist's objects into olist, using seen to track already\n+# processed objects.\n+def _getr(slist, olist, seen):\n+\tfor e in slist:\n+\t\tif id(e) in seen:\n+\t\t\tcontinue\n+\t\tseen.add(id(e))\n+\t\tolist.append(e)\n+\t\ttl = gc.get_referents(e)\n+\t\tif tl:\n+\t\t\t_getr(tl, olist, seen)\n+\n+def get_all_objects(ignored = []):\n+\tgcl = gc.get_objects()\n+\tolist = []\n+\tseen = set()\n+\n+\tseen.add(id(gcl))\n+\tseen.add(id(olist))\n+\tseen.add(id(seen))\n+\tseen.update(set([id(o) for o in ignored]))\n+\n+\t_getr(gcl, olist, seen)\n+\n+\treturn olist\n+\n+def create_type_count_map(olist):\n+\tmap = defaultdict(int)\n+\tfor o in olist:\n+\t\tmap[type(o)] += 1\n+\treturn map\n+\n+def diff_type_count_maps(before, after):\n+\treturn [(k, after[k] - before[k]) for k in after if after[k] != before[k]]\n+\n+if __name__ == '__main__':\n+\t# doesn't work very well, as things always leak a bit\n+\ttest_leaks = False\n+\n+\tif test_leaks:\n+\t\tgc.unfreeze()\n+\t\tgc.collect()\n+\n+\t\tobs_before = get_all_objects()\n+\n+\tunittest.main(exit=False)\n+\n+\tif test_leaks:\n+\t\tgc.unfreeze()\n+\t\tgc.collect()\n+\n+\t\tobs_after = get_all_objects([obs_before])\n+\n+\t\tbefore = create_type_count_map(obs_before)\n+\t\tafter = create_type_count_map(obs_after)\n+\n+\t\tleaks = diff_type_count_maps(before, after)\n+\t\tif len(leaks) > 0:\n+\t\t\tprint(leaks)\n", "prefixes": [ "libcamera-devel", "v4", "4/5" ] }