Patch Detail
Show a patch.
GET /api/1.1/patches/15324/?format=api
{ "id": 15324, "url": "https://patchwork.libcamera.org/api/1.1/patches/15324/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15324/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220204092435.6343-1-david.plowman@raspberrypi.com>", "date": "2022-02-04T09:24:35", "name": "[libcamera-devel] ipa: raspberrypi: awb: Better handling of how we disable AWB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "aae9dc9ad52ff34b280d6885b00a1564e3b6045b", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15324/mbox/", "series": [ { "id": 2913, "url": "https://patchwork.libcamera.org/api/1.1/series/2913/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2913", "date": "2022-02-04T09:24:35", "name": "[libcamera-devel] ipa: raspberrypi: awb: Better handling of how we disable AWB", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2913/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15324/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15324/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ADF0BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Feb 2022 09:25:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E1E2609F3;\n\tFri, 4 Feb 2022 10:25:10 +0100 (CET)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D9DF6017A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Feb 2022 10:25:07 +0100 (CET)", "by mail-wm1-x32c.google.com with SMTP id\n\to30-20020a05600c511e00b0034f4c3186f4so8967391wms.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 04 Feb 2022 01:25:07 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tn8sm1022458wmk.18.2022.02.04.01.25.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 04 Feb 2022 01:25:06 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Vxvzjofa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=qSV/HSk0po+pFQRz6xepFbbJAua08vbyGzK/VyWkkOw=;\n\tb=Vxvzjofa6spjZcll1qQlqmWSEfMkN/hdyoFDUc8XGXFBJpk0QL1SF2Y8rNERpYQoql\n\tCnWLDNduPrkqY0RP/5B3UvQzbT5D2Ro10zt8X/gZXQ7XxKkLgX52RgtL4qMBoiAr4IG8\n\t1/A9oWogG+gKOWxuTYOjYcqo3K4DmkZlpbuMoYq7WN9X2Gct9BbYvINT9rHmQnbs6tW6\n\t2w2qKKbTLV3hoRAKp3w7MMhtdiN61PHTw1m/tqordNtRqOGdgKYVpUd3CVrzx/UfDsbJ\n\tlYfL3Xojf7vvn8wEEZ5m7i7vuv2gw2ZbPKBEpLZB63Cs9ZnJFBFzQCd7wfSHilkUwfp8\n\tpQQg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=qSV/HSk0po+pFQRz6xepFbbJAua08vbyGzK/VyWkkOw=;\n\tb=h5KTmpj6CDmxCttEPEGvnRXO3TlmMnovpexeGDNXJGBdIlEQkcJ2yyfZzdrqAMjFIE\n\tiuFaJ5UlOjfoGdEfi1rq5UOlV4k3ZLxveJM89hL6rZvUWlZAwMXpFCU06oytsx6syGYx\n\t0v/+B3lOEh6qkGi53uOxH5Bei31PaOBLkpF8KYsB7p/6btbvvuiM13Iq76y5lLXQMfEe\n\tVYgaPA1jJ12s3C/1ITqOWiKau6pU39ujzohhTRenyXRhfdIHjPjaPdNsZ7gRlxW5fKIu\n\tKKj3pAP94LFlzyA0L9felH45tTVrvLMeuFvr5hWU3n2fw92efn5Z6cAWohzI4uuKnlIw\n\t4UbA==", "X-Gm-Message-State": "AOAM530ER7uXv7Wo3Hk0RKbqHMfckdyFFMfD98j4eLwDGSw4hsne8oV5\n\tMXmxbGumrpQvBi8Uy0kBf8DE5095TT/gpxBK", "X-Google-Smtp-Source": "ABdhPJxQPPE8KEbxePFz0dZMAC9i+MqMSeAN9TkfRLSKimkchJparlIII0bbQ1yaNDBNzuFW2b8H/g==", "X-Received": "by 2002:a7b:c4c5:: with SMTP id g5mr1415657wmk.139.1643966707192;\n\tFri, 04 Feb 2022 01:25:07 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 4 Feb 2022 09:24:35 +0000", "Message-Id": "<20220204092435.6343-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: awb: Better handling of\n\thow we disable AWB", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We now handle disabling (\"pausing\") AWB in the same way as\nAEC/AGC. Instead of letting the pause flag be set so that the code\nnever runs at all, we instead fix the manual settings to the current\nvalues (but continue to be called).\n\nThe algorithm does not restart any calculations in this state, but\ncontinues to add AWB metadata to every frame. Therefore certain other\nalgorithms that want to know it (CCM and ALSC, for example) can still\nfind it.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 21 +++++++++++++++++++++\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 ++++\n 2 files changed, 25 insertions(+)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex 5cfd33a3..1ad912c7 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -172,6 +172,27 @@ void Awb::Initialise()\n \tasync_results_ = sync_results_;\n }\n \n+bool Awb::IsPaused() const\n+{\n+\treturn false;\n+}\n+\n+void Awb::Pause()\n+{\n+\t// \"Pause\" by fixing everything to the most recent values.\n+\tmanual_r_ = sync_results_.gain_r = prev_sync_results_.gain_r;\n+\tmanual_b_ = sync_results_.gain_b = prev_sync_results_.gain_b;\n+\tsync_results_.gain_g = prev_sync_results_.gain_g;\n+\tsync_results_.gain_g = prev_sync_results_.gain_g;\n+\tsync_results_.temperature_K = prev_sync_results_.temperature_K;\n+}\n+\n+void Awb::Resume()\n+{\n+\tmanual_r_ = 0.0;\n+\tmanual_b_ = 0.0;\n+}\n+\n unsigned int Awb::GetConvergenceFrames() const\n {\n \t// If not in auto mode, there is no convergence\ndiff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp b/src/ipa/raspberrypi/controller/rpi/awb.hpp\nindex 8af1f27c..ac3dca6f 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n@@ -83,6 +83,10 @@ public:\n \tchar const *Name() const override;\n \tvoid Initialise() override;\n \tvoid Read(boost::property_tree::ptree const ¶ms) override;\n+\t// AWB handles \"pausing\" for itself.\n+\tbool IsPaused() const override;\n+\tvoid Pause() override;\n+\tvoid Resume() override;\n \tunsigned int GetConvergenceFrames() const override;\n \tvoid SetMode(std::string const &name) override;\n \tvoid SetManualGains(double manual_r, double manual_b) override;\n", "prefixes": [ "libcamera-devel" ] }