Patch Detail
Show a patch.
GET /api/1.1/patches/15289/?format=api
{ "id": 15289, "url": "https://patchwork.libcamera.org/api/1.1/patches/15289/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15289/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220120114102.19477-1-hpa@redhat.com>", "date": "2022-01-20T11:41:02", "name": "[libcamera-devel,RFC,v5] ipa: ipu3: af: Auto focus for dw9719 Surface Go2 VCM", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e6f2e83fca6139186cb595bc77e733150904c89b", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/1.1/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15289/mbox/", "series": [ { "id": 2899, "url": "https://patchwork.libcamera.org/api/1.1/series/2899/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2899", "date": "2022-01-20T11:41:02", "name": "[libcamera-devel,RFC,v5] ipa: ipu3: af: Auto focus for dw9719 Surface Go2 VCM", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2899/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15289/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15289/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05F8ABF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Jan 2022 11:41:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2DF0560997;\n\tThu, 20 Jan 2022 12:41:42 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 913D360215\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Jan 2022 12:41:39 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-549-gMkrmZqPPvWJIipxBUuTag-1; Thu, 20 Jan 2022 06:41:36 -0500", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id F22611091DA2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Jan 2022 11:41:35 +0000 (UTC)", "from fedora.redhat.com (unknown [10.39.195.81])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 502927D70A;\n\tThu, 20 Jan 2022 11:41:26 +0000 (UTC)" ], "Authentication-Results": [ "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"VbarW6TC\"; dkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1642678898;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=QfFKUiOAf0ddZvIFxiKPKGOHH/Q9KCaahQsGwYjr+sE=;\n\tb=VbarW6TCZOzSGo1q0q+Ru/JNOYNbLheMPkrQKDfCVsDdKr9ZvR3KbQBhdfFTrxkuvD2wxy\n\tMiy0pdaxQl7BMNwivA4bQbjtWCk9f+j/bARkaL+DHxksQM+E1PdB9xuf7j61JhBXOfQ422\n\tEVZsd5Jduxn/pExYVi35pRdJEN+Y4NY=", "X-MC-Unique": "gMkrmZqPPvWJIipxBUuTag-1", "From": "Kate Hsuan <hpa@redhat.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 20 Jan 2022 19:41:02 +0800", "Message-Id": "<20220120114102.19477-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[libcamera-devel] [RFC v5] ipa: ipu3: af: Auto focus for dw9719\n\tSurface Go2 VCM", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since VCM for surface Go 2 (dw9719) had been successfully\ndriven, this Af module can be used to control the VCM and\ndetermine the focus value based on the IPU3 AF state.\n\nThe variance of each focus step is determined and a greedy\napproah is used to find the maximum variance of the AF\nstate and a appropriate focus value.\n\nThe grid configuration is implemented as a context. Also,\nthe grid parameter- AF_MIN_BLOCK_WIDTH is set to 4 (default\nis 3) since if the default value is used, x_start\n(x_start > 640) will be at an incorrect location of the\nimage (rightmost of the sensor).\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n src/ipa/ipu3/algorithms/af.cpp | 367 ++++++++++++++++++++++++++++\n src/ipa/ipu3/algorithms/af.h | 79 ++++++\n src/ipa/ipu3/algorithms/meson.build | 3 +-\n src/ipa/ipu3/ipa_context.cpp | 24 ++\n src/ipa/ipu3/ipa_context.h | 10 +\n src/ipa/ipu3/ipu3.cpp | 32 +++\n 6 files changed, 514 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/ipu3/algorithms/af.cpp\n create mode 100644 src/ipa/ipu3/algorithms/af.h", "diff": "diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nnew file mode 100644\nindex 00000000..26c98868\n--- /dev/null\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -0,0 +1,367 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Red Hat\n+ *\n+ * af.cpp - IPU3 auto focus control\n+ */\n+\n+#include \"af.h\"\n+\n+#include <algorithm>\n+#include <chrono>\n+#include <cmath>\n+#include <fcntl.h>\n+#include <numeric>\n+#include <sys/ioctl.h>\n+#include <sys/stat.h>\n+#include <sys/types.h>\n+#include <unistd.h>\n+\n+#include <linux/videodev2.h>\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/ipa/core_ipa_interface.h>\n+\n+#include \"libipa/histogram.h\"\n+\n+/**\n+ * \\file af.h\n+ */\n+\n+/**\n+ * \\def AF_MIN_GRID_WIDTH\n+ * \\brief the minimum width of AF grid.\n+ * The minimum grid horizontal dimensions, in number of grid blocks(cells).\n+*/\n+\n+/**\n+ * \\def AF_MIN_GRID_HEIGHT\n+ * \\brief the minimum height of AF grid.\n+ * The minimum grid horizontal dimensions, in number of grid blocks(cells).\n+*/\n+\n+/**\n+ * \\def AF_MIN_BLOCK_WIDTH\n+ * \\brief the minimum block size of the width.\n+ */\n+\n+/**\n+ * \\def AF_MAX_GRID_HEIGHT\n+ * \\brief the minimum height of AF grid.\n+ * The minimum grid horizontal dimensions, in number of grid blocks(cells).\n+*/\n+\n+/**\n+ * \\def AF_MAX_BLOCK_WIDTH\n+ * \\brief the minimum block size of the width.\n+ */\n+\n+/**\n+ * \\def AF_MAX_BLOCK_WIDTH\n+ * \\brief the maximum block size of the width.\n+ */\n+\n+/**\n+ * \\def AF_MIN_BLOCK_HEIGHT\n+ * \\brief the minimum block size of the height.\n+ */\n+\n+/**\n+ * \\def AF_MAX_BLOCK_HEIGHT\n+ * \\brief the maximum block size of the height.\n+ */\n+\n+/**\n+ * \\def AF_DEFAULT_HEIGHT_PER_SLICE\n+ * \\brief The default number of blocks in vertical axis per slice.\n+ */\n+\n+namespace libcamera {\n+\n+using namespace std::literals::chrono_literals;\n+\n+namespace ipa::ipu3::algorithms {\n+\n+/**\n+ * \\class Af\n+ * \\brief A IPU3 auto-focus accelerator based auto focus algorthim\n+ *\n+ * This algorithm is used to determine the position of the lens and get a\n+ * focused image. The IPU3 AF accelerator computes the statistics, composed\n+ * by high pass and low pass filtered value and stores in a AF buffer.\n+ * Typically, for a focused image, it has relative high contrast than a\n+ * blurred image, i.e. an out of focus image. Therefore, if an image with the\n+ * highest contrast can be found from the AF scan, the lens' position is the\n+ * best step of the focus.\n+ *\n+ */\n+\n+LOG_DEFINE_CATEGORY(IPU3Af)\n+\n+/**\n+ * Maximum focus value of the VCM control\n+ * \\todo should be obtained from the VCM driver\n+ */\n+static constexpr uint32_t MaxFocusSteps_ = 1023;\n+\n+/* minimum focus step for searching appropriate focus */\n+static constexpr uint32_t coarseSearchStep_ = 10;\n+static constexpr uint32_t fineSearchStep_ = 1;\n+\n+/* max ratio of variance change, 0.0 < MaxChange_ < 1.0 */\n+static constexpr double MaxChange_ = 0.2;\n+\n+/* the numbers of frame to be ignored, before performing focus scan. */\n+static constexpr uint32_t ignoreFrame_ = 10;\n+\n+/* fine scan range 0 < findRange_ < 1 */\n+static constexpr double findRange_ = 0.05;\n+\n+/* settings for Auto Focus from the kernel */\n+static struct ipu3_uapi_af_filter_config afFilterConfigDefault = {\n+\t{ 0, 1, 3, 7 },\n+\t{ 11, 13, 1, 2 },\n+\t{ 8, 19, 34, 242 },\n+\t0x7fdffbfe,\n+\t{ 0, 1, 6, 6 },\n+\t{ 13, 25, 3, 0 },\n+\t{ 25, 3, 177, 254 },\n+\t0x4e53ca72,\n+\t.y_calc = { 8, 8, 8, 8 },\n+\t.nf = { 0, 9, 0, 9, 0 },\n+};\n+\n+Af::Af()\n+\t: focus_(0), goodFocus_(0), currentVariance_(0.0), previousVariance_(0.0),\n+\t coarseComplete_(false), fineComplete_(false)\n+{\n+\tmaxStep_ = MaxFocusSteps_;\n+}\n+\n+Af::~Af()\n+{\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::prepare\n+ */\n+void Af::prepare(IPAContext &context, ipu3_uapi_params *params)\n+{\n+\tconst struct ipu3_uapi_grid_config &grid = context.configuration.af.afGrid;\n+\tparams->acc_param.af.grid_cfg = grid;\n+\tparams->acc_param.af.filter_config = afFilterConfigDefault;\n+\n+\t/* enable AF acc */\n+\tparams->use.acc_af = 1;\n+}\n+\n+/**\n+ * \\brief Configure the Af given a configInfo\n+ * \\param[in] context The shared IPA context\n+ * \\param[in] configInfo The IPA configuration data\n+ *\n+ * \\return 0\n+ */\n+int Af::configure(IPAContext &context,\n+\t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n+{\n+\t/* determined focus value i.e. current focus value */\n+\tcontext.frameContext.af.focus = 0;\n+\t/* maximum variance of the AF statistics */\n+\tcontext.frameContext.af.maxVariance = 0;\n+\t/* the stable AF value flag. if it is true, the AF should be in a stable state. */\n+\tcontext.frameContext.af.stable = false;\n+\t/* AF buffer length */\n+\tafRawBufferLen_ = context.configuration.af.afGrid.width *\n+\t\t\t context.configuration.af.afGrid.height;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * \\brief AF coarse scan\n+ * \\param[in] context The shared IPA context\n+ *\n+ */\n+void Af::afCoarseScan(IPAContext &context)\n+{\n+\tif (coarseComplete_ == true)\n+\t\treturn;\n+\n+\tif (afScan(context, coarseSearchStep_)) {\n+\t\tcoarseComplete_ = true;\n+\t\tcontext.frameContext.af.maxVariance = 0;\n+\t\tfocus_ = context.frameContext.af.focus - (context.frameContext.af.focus * findRange_);\n+\t\tcontext.frameContext.af.focus = focus_;\n+\t\tpreviousVariance_ = 0;\n+\t\tmaxStep_ = std::clamp(static_cast<uint32_t>(focus_ + (focus_ * findRange_)), 0U, MaxFocusSteps_);\n+\t}\n+}\n+\n+/**\n+ * \\brief AF fine scan\n+ *\n+ * Finetune the lens position with moving 1 step for each variance computation.\n+ *\n+ * \\param[in] context The shared IPA context\n+ *\n+ */\n+void Af::afFineScan(IPAContext &context)\n+{\n+\tif (coarseComplete_ != true)\n+\t\treturn;\n+\n+\tif (afScan(context, fineSearchStep_)) {\n+\t\tcontext.frameContext.af.stable = true;\n+\t\tfineComplete_ = true;\n+\t}\n+}\n+\n+/**\n+ * \\brief AF reset\n+ *\n+ * Reset all the parameter to start over the AF process.\n+ *\n+ * \\param[in] context The shared IPA context\n+ *\n+ */\n+void Af::afReset(IPAContext &context)\n+{\n+\tcontext.frameContext.af.maxVariance = 0;\n+\tcontext.frameContext.af.focus = 0;\n+\tfocus_ = 0;\n+\tcontext.frameContext.af.stable = false;\n+\tignoreCounter_ = ignoreFrame_;\n+\tpreviousVariance_ = 0.0;\n+\tcoarseComplete_ = false;\n+\tfineComplete_ = false;\n+\tmaxStep_ = MaxFocusSteps_;\n+}\n+\n+/**\n+ * \\brief AF scan\n+ * \\param[in] context The shared IPA context\n+ *\n+ * \\return True, if it finds a AF value.\n+ */\n+bool Af::afScan(IPAContext &context, int min_step)\n+{\n+\t/* find the maximum variance during the AF scan using a greedy strategy */\n+\tif (currentVariance_ > context.frameContext.af.maxVariance) {\n+\t\tcontext.frameContext.af.maxVariance = currentVariance_;\n+\t\tgoodFocus_ = focus_;\n+\t}\n+\n+\tif (focus_ > maxStep_) {\n+\t\t/* if reach the max step, move lens to the position and set \"focus stable\". */\n+\t\tcontext.frameContext.af.focus = goodFocus_;\n+\t\treturn true;\n+\t} else {\n+\t\t/* check negative gradient */\n+\t\tif ((currentVariance_ - context.frameContext.af.maxVariance) > -(context.frameContext.af.maxVariance * 0.15)) {\n+\t\t\tfocus_ += min_step;\n+\t\t\tcontext.frameContext.af.focus = focus_;\n+\t\t} else {\n+\t\t\tcontext.frameContext.af.focus = goodFocus_;\n+\t\t\tpreviousVariance_ = currentVariance_;\n+\t\t\treturn true;\n+\t\t}\n+\t}\n+\tLOG(IPU3Af, Debug) << \"Variance previous: \"\n+\t\t\t << previousVariance_\n+\t\t\t << \" current: \"\n+\t\t\t << currentVariance_\n+\t\t\t << \" Diff: \"\n+\t\t\t << (currentVariance_ - context.frameContext.af.maxVariance);\n+\tpreviousVariance_ = currentVariance_;\n+\tLOG(IPU3Af, Debug) << \"Focus searching max variance is: \"\n+\t\t\t << context.frameContext.af.maxVariance\n+\t\t\t << \" Focus step is \"\n+\t\t\t << goodFocus_\n+\t\t\t << \" Current scan is \"\n+\t\t\t << focus_;\n+\treturn false;\n+}\n+\n+/**\n+ * \\brief Determine the max contrast image and lens position. y_table is the\n+ * statictic data from IPU3 and is composed of low pass and high pass filtered\n+ * value. High pass filtered value also represents the sharpness of the image.\n+ * Based on this, if the image with highest variance of the high pass filtered\n+ * value (contrast) during the AF scan, the position of the lens should be the\n+ * best focus.\n+ * \\param[in] context The shared IPA context.\n+ * \\param[in] stats The statistic buffer of 3A from the IPU3.\n+ */\n+void Af::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n+{\n+\tuint32_t total = 0;\n+\tdouble mean;\n+\tuint64_t var_sum = 0;\n+\ty_table_item_t *y_item;\n+\tuint32_t z = 0;\n+\n+\ty_item = (y_table_item_t *)stats->af_raw_buffer.y_table;\n+\n+\t/**\n+\t * Calculate the mean and the varience AF statistics, since IPU3 only determine the AF value\n+\t * for a given grid.\n+\t * For coarse: low pass results are used.\n+\t * For fine: high pass results are used.\n+\t */\n+\tif (coarseComplete_) {\n+\t\tfor (z = 0; z < afRawBufferLen_; z++) {\n+\t\t\ttotal = total + y_item[z].y2_avg;\n+\t\t}\n+\t\tmean = total / afRawBufferLen_;\n+\n+\t\tfor (z = 0; z < afRawBufferLen_; z++) {\n+\t\t\tvar_sum = var_sum + ((y_item[z].y2_avg - mean) * (y_item[z].y2_avg - mean));\n+\t\t}\n+\t} else {\n+\t\tfor (z = 0; z < afRawBufferLen_; z++) {\n+\t\t\ttotal = total + y_item[z].y1_avg;\n+\t\t}\n+\t\tmean = total / afRawBufferLen_;\n+\n+\t\tfor (z = 0; z < afRawBufferLen_; z++) {\n+\t\t\tvar_sum = var_sum + ((y_item[z].y1_avg - mean) * (y_item[z].y1_avg - mean));\n+\t\t}\n+\t}\n+\n+\t/* Determine the average variance of the frame. */\n+\tcurrentVariance_ = static_cast<double>(var_sum) / static_cast<double>(afRawBufferLen_);\n+\tLOG(IPU3Af, Debug) << \"variance: \" << currentVariance_;\n+\n+\tif (context.frameContext.af.stable == true) {\n+\t\tconst uint32_t diff_var = std::abs(currentVariance_ - context.frameContext.af.maxVariance);\n+\t\tconst double var_ratio = diff_var / context.frameContext.af.maxVariance;\n+\t\tLOG(IPU3Af, Debug) << \"Rate of variance change: \"\n+\t\t\t\t << var_ratio\n+\t\t\t\t << \" current focus step: \"\n+\t\t\t\t << context.frameContext.af.focus;\n+\t\t/**\n+\t\t * If the change ratio of contrast is over Maxchange_ (out of focus),\n+\t\t * trigger AF again.\n+\t\t */\n+\t\tif (var_ratio > MaxChange_) {\n+\t\t\tif (ignoreCounter_ == 0) {\n+\t\t\t\tafReset(context);\n+\t\t\t} else\n+\t\t\t\tignoreCounter_--;\n+\t\t} else\n+\t\t\tignoreCounter_ = ignoreFrame_;\n+\t} else {\n+\t\tif (ignoreCounter_ != 0)\n+\t\t\tignoreCounter_--;\n+\t\telse {\n+\t\t\tafCoarseScan(context);\n+\t\t\tafFineScan(context);\n+\t\t}\n+\t}\n+}\n+\n+} /* namespace ipa::ipu3::algorithms */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\nnew file mode 100644\nindex 00000000..5654a964\n--- /dev/null\n+++ b/src/ipa/ipu3/algorithms/af.h\n@@ -0,0 +1,79 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Red Hat\n+ *\n+ * af.h - IPU3 Af control\n+ */\n+#ifndef __LIBCAMERA_IPU3_ALGORITHMS_AF_H__\n+#define __LIBCAMERA_IPU3_ALGORITHMS_AF_H__\n+\n+#include <linux/intel-ipu3.h>\n+\n+#include <libcamera/base/utils.h>\n+\n+#include <libcamera/geometry.h>\n+\n+#include \"algorithm.h\"\n+\n+/* Definitions from repo of chromium */\n+#define AF_MIN_GRID_WIDTH 16\n+#define AF_MIN_GRID_HEIGHT 16\n+#define AF_MAX_GRID_WIDTH 32\n+#define AF_MAX_GRID_HEIGHT 24\n+#define AF_MIN_BLOCK_WIDTH 4\n+#define AF_MIN_BLOCK_HEIGHT 3\n+#define AF_MAX_BLOCK_WIDTH 6\n+#define AF_MAX_BLOCK_HEIGHT 6\n+#define AF_DEFAULT_HEIGHT_PER_SLICE 2\n+\n+namespace libcamera {\n+\n+namespace ipa::ipu3::algorithms {\n+\n+class Af : public Algorithm\n+{\n+\t/* The format of y_table. From ipu3-ipa repo */\n+\ttypedef struct __attribute__((packed)) y_table_item {\n+\t\tuint16_t y1_avg;\n+\t\tuint16_t y2_avg;\n+\t} y_table_item_t;\n+\n+public:\n+\tAf();\n+\t~Af();\n+\n+\tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n+\tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n+\tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n+\n+private:\n+\tvoid afCoarseScan(IPAContext &context);\n+\tvoid afFineScan(IPAContext &context);\n+\tbool afScan(IPAContext &context, int min_step);\n+\tvoid afReset(IPAContext &context);\n+\n+\t/* Used for focus scan. */\n+\tuint32_t focus_;\n+\t/* Focus good */\n+\tuint32_t goodFocus_;\n+\t/* Recent AF statistic variance. */\n+\tdouble currentVariance_;\n+\t/* The frames to be ignore before starting measuring. */\n+\tuint32_t ignoreCounter_;\n+\t/* previous variance. it is used to determine the gradient */\n+\tdouble previousVariance_;\n+\t/* Max scan steps of each pass of AF scaning */\n+\tuint32_t maxStep_;\n+\t/* coarse scan stable. Complete low pass search (coarse) scan) */\n+\tbool coarseComplete_;\n+\t/* fine scan stable. Complete high pass scan (fine scan) */\n+\tbool fineComplete_;\n+\t/* Raw buffer length */\n+\tuint32_t afRawBufferLen_;\n+};\n+\n+} /* namespace ipa::ipu3::algorithms */\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_IPU3_ALGORITHMS_AF_H__ */\ndiff --git a/src/ipa/ipu3/algorithms/meson.build b/src/ipa/ipu3/algorithms/meson.build\nindex 4db6ae1d..e1099169 100644\n--- a/src/ipa/ipu3/algorithms/meson.build\n+++ b/src/ipa/ipu3/algorithms/meson.build\n@@ -1,8 +1,9 @@\n # SPDX-License-Identifier: CC0-1.0\n \n ipu3_ipa_algorithms = files([\n+ 'af.cpp',\n 'agc.cpp',\n 'awb.cpp',\n 'blc.cpp',\n- 'tone_mapping.cpp',\n+ 'tone_mapping.cpp'\n ])\ndiff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 86794ac1..ecb2b90a 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -67,6 +67,30 @@ namespace libcamera::ipa::ipu3 {\n *\n * \\var IPASessionConfiguration::grid.stride\n * \\brief Number of cells on one line including the ImgU padding\n+ *\n+ */\n+\n+/**\n+ * \\var IPASessionConfiguration::af\n+ * \\brief AF grid configuration of the IPA\n+ *\n+ * \\var IPASessionConfiguration::af.afGrid\n+ *\n+ */\n+\n+/**\n+ * \\var IPAFrameContext::af\n+ * \\brief Context for the Automatic Focus algorithm\n+ *\n+ * \\struct IPAFrameContext::af\n+ * \\var IPAFrameContext::af.focus\n+ * \\brief Current position of the lens\n+ *\n+ * \\var IPAFrameContext::af.maxVariance\n+ * \\brief The maximum variance of the current image.\n+ *\n+ * \\var IPAFrameContext::af.stable\n+ * \\brief is the image focused?\n */\n \n /**\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex c6dc0814..e643d38f 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -31,6 +31,10 @@ struct IPASessionConfiguration {\n \t\tdouble minAnalogueGain;\n \t\tdouble maxAnalogueGain;\n \t} agc;\n+\n+\tstruct {\n+\t\tipu3_uapi_grid_config afGrid;\n+\t} af;\n };\n \n struct IPAFrameContext {\n@@ -49,6 +53,12 @@ struct IPAFrameContext {\n \t\tdouble temperatureK;\n \t} awb;\n \n+\tstruct {\n+\t\tuint32_t focus;\n+\t\tdouble maxVariance;\n+\t\tbool stable;\n+\t} af;\n+\n \tstruct {\n \t\tuint32_t exposure;\n \t\tdouble gain;\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 3d307708..b5149bcd 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -30,6 +30,7 @@\n \n #include \"libcamera/internal/mapped_framebuffer.h\"\n \n+#include \"algorithms/af.h\"\n #include \"algorithms/agc.h\"\n #include \"algorithms/algorithm.h\"\n #include \"algorithms/awb.h\"\n@@ -157,6 +158,7 @@ private:\n \n \tvoid setControls(unsigned int frame);\n \tvoid calculateBdsGrid(const Size &bdsOutputSize);\n+\tvoid initAfGrid(const Size &bdsOutputSize);\n \n \tstd::map<unsigned int, MappedFrameBuffer> buffers_;\n \n@@ -294,6 +296,7 @@ int IPAIPU3::init(const IPASettings &settings,\n \t}\n \n \t/* Construct our Algorithms */\n+\talgorithms_.push_back(std::make_unique<algorithms::Af>());\n \talgorithms_.push_back(std::make_unique<algorithms::Agc>());\n \talgorithms_.push_back(std::make_unique<algorithms::Awb>());\n \talgorithms_.push_back(std::make_unique<algorithms::BlackLevelCorrection>());\n@@ -395,6 +398,33 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n \t\t\t << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n }\n \n+/**\n+ * \\brief Configure the IPU3 AF grid\n+ *\n+ * This function gives the default values for the AF grid configuration.\n+ * All the parameters are set to the minimum acceptable values.\n+ *\n+ * \\param bdsOutputSize The bsd output size\n+ */\n+void IPAIPU3::initAfGrid(const Size &bdsOutputSize)\n+{\n+\tstruct ipu3_uapi_grid_config &grid = context_.configuration.af.afGrid;\n+\tgrid.width = AF_MIN_GRID_WIDTH;\n+\tgrid.height = AF_MIN_GRID_HEIGHT;\n+\tgrid.block_width_log2 = AF_MIN_BLOCK_WIDTH;\n+\tgrid.block_height_log2 = AF_MIN_BLOCK_HEIGHT;\n+\tgrid.height_per_slice = AF_DEFAULT_HEIGHT_PER_SLICE;\n+\t/* x_start and y start are default to BDS center */\n+\tgrid.x_start = (bdsOutputSize.width / 2) -\n+\t\t (((grid.width << grid.block_width_log2) / 2));\n+\tgrid.y_start = (bdsOutputSize.height / 2) -\n+\t\t (((grid.height << grid.block_height_log2) / 2));\n+\t/* make sure x_start is multiplied by 10 and y_start is multiplied by 2 */\n+\tgrid.x_start = (grid.x_start / 10) * 10;\n+\tgrid.y_start = (grid.y_start / 2) * 2;\n+\tgrid.y_start = grid.y_start | IPU3_UAPI_GRID_Y_START_EN;\n+}\n+\n /**\n * \\brief Configure the IPU3 IPA\n * \\param[in] configInfo The IPA configuration data, received from the pipeline\n@@ -461,6 +491,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \n \tlineDuration_ = sensorInfo_.lineLength * 1.0s / sensorInfo_.pixelRate;\n \n+\tinitAfGrid(configInfo.bdsOutputSize);\n+\n \t/* Update the camera controls using the new sensor settings. */\n \tupdateControls(sensorInfo_, ctrls_, ipaControls);\n \n", "prefixes": [ "libcamera-devel", "RFC", "v5" ] }