Patch Detail
Show a patch.
GET /api/1.1/patches/15257/?format=api
{ "id": 15257, "url": "https://patchwork.libcamera.org/api/1.1/patches/15257/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15257/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220106113242.2383324-1-naush@raspberrypi.com>", "date": "2022-01-06T11:32:42", "name": "[libcamera-devel,v1] pipeline: raspberrypi: Return all ISP resolutions from generateConfiguration()", "commit_ref": "7b84a17e213891f9c32b4b3d258c1c8343fc9c8a", "pull_url": null, "state": "accepted", "archived": false, "hash": "2284c397b1f0f778debfe5151a8557cbe1153ab0", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15257/mbox/", "series": [ { "id": 2881, "url": "https://patchwork.libcamera.org/api/1.1/series/2881/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2881", "date": "2022-01-06T11:32:42", "name": "[libcamera-devel,v1] pipeline: raspberrypi: Return all ISP resolutions from generateConfiguration()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2881/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15257/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15257/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8D47BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 6 Jan 2022 11:32:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCD2E60925;\n\tThu, 6 Jan 2022 12:32:52 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3E4360219\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 6 Jan 2022 12:32:50 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id e9so2629000wra.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 06 Jan 2022 03:32:50 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:f2bf:e3f6:c5a8:939b])\n\tby smtp.gmail.com with ESMTPSA id\n\tu3sm2283370wrs.0.2022.01.06.03.32.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 06 Jan 2022 03:32:49 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"DkDp0ylH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=xVAx5APxE1gjIFZIn1+gvbw5O9T0d0vTvUjiHlpoqnk=;\n\tb=DkDp0ylHyk0WCko/rIMIVpLRWwXLwY6NI6p6djkCRD/Tvwc6LxvpGcGNbuhAgu5RsC\n\tKKtYYgmWRWoUHIkaJCnmzr4REEwOkqtXkKR9DASU/QM5VhPViHfM+d+feZwnuFGccxed\n\tuPF0vJNl/S5FJTmARl5+BJ5I3iOk0ebvahIMRVh2T7BmuKIeEWMtJOc04xGdelDfwmIU\n\t/xuvjz9OrlVHytJsXWJX3FzF4cJFSLzTAaLu8ZQc2mUC0moRCPhla4k4d8RaZdKXfHe3\n\tDZS729QQ39o4wiiMoyldvLAHVcIOobcfuL31RwEIFeYZGlEpGM6QdJ6x/3t3WZ8oyUHK\n\t2nSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=xVAx5APxE1gjIFZIn1+gvbw5O9T0d0vTvUjiHlpoqnk=;\n\tb=Xjk8GMD04TyyZ2CiHOMISEO2bGg/JoDc2jXipsdt/+3rS1nTuRrhP+JnxxyIx8bHKX\n\tTUFL502LAOMzzg1jXbnH17pCvZgGFzRMxBubVXaQPCCDPVGN8RmYokBvUAO5duTpgVVw\n\tWETRSxltT1kw3cBnlEIQrVZRrZatWC/0YA8lQrCYQFB8eCUQoyDUKcK/aevstC0F8+Au\n\tnjszYthuT2VqihCahye00nUlQEOmzHSZJHJAUBDE43vXV2sKZoDg3vEy0iuCIsmyHQ88\n\tLYqWn061Vkh+BS29WLHnwUUduyOYVut/QK+wsq/Kv8WVugWCdkG4AnHx6wDnCBnB8+Wv\n\tXjNw==", "X-Gm-Message-State": "AOAM530BdRVdTaZbaIpV2ZUg+zhlwvTC9JJY2KdiuynKkCaaSefzIbFK\n\tf4Nn+sxbLQUrrzJ/geQ6ag335An3Dq3i8w==", "X-Google-Smtp-Source": "ABdhPJwRC2NYip1qQqD/4anh0+FIvBw3eJHvWhAgnx677NsZ5ZG7stj+RrxkTOORHlMT0TlRBHrq6w==", "X-Received": "by 2002:a5d:468f:: with SMTP id\n\tu15mr3067617wrq.402.1641468770357; \n\tThu, 06 Jan 2022 03:32:50 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 6 Jan 2022 11:32:42 +0000", "Message-Id": "<20220106113242.2383324-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1] pipeline: raspberrypi: Return all ISP\n\tresolutions from generateConfiguration()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamerasrc gstreamer component does seem to not allow stream resolutions\nthat are not advertised by PipelineHandler::generateConfiguration(). This has\nbeen raised in a bug report [1].\n\nFix this behavior by advertising a SizeRange from the minimum ISP resolution, up\nto the sensor resolution from PipelineHandlerRPi::generateConfiguration().\n\n[1] https://bugs.libcamera.org/show_bug.cgi?id=105\n\nFixes: f16acb275c85 (\"pipeline: raspberrypi: Restrict the advertised maximum ISP output resolution\")\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex b5c687da467f..220a5749c0d9 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -639,8 +639,11 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n \t\t\t */\n \t\t\tfor (const auto &format : fmts) {\n \t\t\t\tPixelFormat pf = format.first.toPixelFormat();\n-\t\t\t\tif (pf.isValid())\n-\t\t\t\t\tdeviceFormats[pf].emplace_back(sensorSize);\n+\t\t\t\tif (pf.isValid()) {\n+\t\t\t\t\tconst SizeRange &ispSizes = format.second[0];\n+\t\t\t\t\tdeviceFormats[pf].emplace_back(ispSizes.min, sensorSize,\n+\t\t\t\t\t\t\t\t ispSizes.hStep, ispSizes.vStep);\n+\t\t\t\t}\n \t\t\t}\n \t\t}\n \n", "prefixes": [ "libcamera-devel", "v1" ] }