Patch Detail
Show a patch.
GET /api/1.1/patches/15217/?format=api
{ "id": 15217, "url": "https://patchwork.libcamera.org/api/1.1/patches/15217/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15217/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211223080110.9766-3-david.plowman@raspberrypi.com>", "date": "2021-12-23T08:01:09", "name": "[libcamera-devel,2/3] libcamera: v4l2_device: Add support for integer array controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "594faf33ba9f9e2603a53555def6859308300d82", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15217/mbox/", "series": [ { "id": 2864, "url": "https://patchwork.libcamera.org/api/1.1/series/2864/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2864", "date": "2021-12-23T08:01:07", "name": "Make use of V4L2_CID_NOTIFY_GAINS", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2864/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15217/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15217/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7903DC3258\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Dec 2021 08:01:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A07CD60908;\n\tThu, 23 Dec 2021 09:01:53 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7023F608E9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Dec 2021 09:01:50 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id c66so3077876wma.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Dec 2021 00:01:50 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ta3sm4692730wri.98.2021.12.23.00.01.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 23 Dec 2021 00:01:49 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"jAUfGyaw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=rfKOot9GmUhxezKsQbyuCgb3G0DBk/IKhALkQP2p3VU=;\n\tb=jAUfGyaw/LZdEcSqY7votC9beJtZ9nTIm/UckTgDF733s2XKeI8DLj9R6/crAClO3v\n\tLhpm4+sKX9YuJQ9VTKGsnT8KjPFLPMWw+tMlrwd7LDRDOnDIwQN2U3hTNWIQXYA2qCi1\n\tTA6+ew4v4tciJOw5ZhWkLiszhNt+5Kxp2EcnK3PnVuClvqivbbL241EB3Jg7k3eDJg/9\n\tKMTDpljDXnCJB2aGTW67RT2RcbRGRxkrKe7tLlLxkkwesShmJwbfpvlTL5MgwxwsJj6x\n\tjwYCt9rVeOPBf/Trob+lEEUtdMa7IC9T7eJ4TaAziEK52iaGgIdgg0XxXV/i4PJgvvou\n\tPJSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=rfKOot9GmUhxezKsQbyuCgb3G0DBk/IKhALkQP2p3VU=;\n\tb=3H1bE1bt8FWJm+Ka+Zwzss3LFvNgt+Q0ssiY06VMRqNuMPlt8/t3AS/BPPBkS4f0JV\n\taKbsRxDHK/M7F6MgAGOFtinJIoLWGVYoBWlMAX0nd2pHGFesveFLje29kocotW/Z4vBf\n\tVkom6Gesm1A6NCD16RG/nFGfkyaApARSElYgYEEOMcGrS+3ouHKEZrxPr0B+8fbiOB5F\n\tDiChPnuo2gWptqLDrwQelbA//xkqDADgvkYryVY/zA3IUtNU861Cqvu8hOUSMXag+4xG\n\t/ZH7kdttMN0Pn16eawI6szLDdhWock1OwQMHkkuzRfdMJLZCjWLFme3o76ckJ48JHntg\n\tpfoA==", "X-Gm-Message-State": "AOAM532g6tEUYAfk82bg40vpWv1LRdeh0heJsWV3xURF5rxFCezO51Kp\n\tVTHOzr+oYbpUpl79rTXQ69h/x3cbgjb8oA==", "X-Google-Smtp-Source": "ABdhPJwBJj65SC+tr6VqGJ+HEDVccznj5PThgqnFQOh0jWW331QLAwspkpjHaAHQukYMBjZ0teQ5VA==", "X-Received": "by 2002:a1c:f304:: with SMTP id q4mr771754wmq.162.1640246509961; \n\tThu, 23 Dec 2021 00:01:49 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Dec 2021 08:01:09 +0000", "Message-Id": "<20211223080110.9766-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211223080110.9766-1-david.plowman@raspberrypi.com>", "References": "<20211223080110.9766-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: v4l2_device: Add support\n\tfor integer array controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/v4l2_device.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 62c91779..6f9de8ad 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -316,6 +316,18 @@ int V4L2Device::setControls(ControlList *ctrls)\n \t\t\tbreak;\n \t\t}\n \n+\t\tcase ControlTypeInteger32: {\n+\t\t\tif (value.isArray()) {\n+\t\t\t\tSpan<uint8_t> data = value.data();\n+\t\t\t\tv4l2Ctrl.p_u32 = reinterpret_cast<uint32_t *>(data.data());\n+\t\t\t\tv4l2Ctrl.size = data.size();\n+\t\t\t} else {\n+\t\t\t\tv4l2Ctrl.value = value.get<int32_t>();\n+\t\t\t}\n+\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tdefault:\n \t\t\t/* \\todo To be changed to support strings. */\n \t\t\tv4l2Ctrl.value = value.get<int32_t>();\n", "prefixes": [ "libcamera-devel", "2/3" ] }