Patch Detail
Show a patch.
GET /api/1.1/patches/1521/?format=api
{ "id": 1521, "url": "https://patchwork.libcamera.org/api/1.1/patches/1521/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1521/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190625202713.10113-1-kieran.bingham@ideasonboard.com>", "date": "2019-06-25T20:27:13", "name": "[libcamera-devel,v2] libcamera: event_dispatcher_poll: Remove struct keyword from for-range", "commit_ref": "caf25dc5cfd11b965316f02610d49ae3d886716b", "pull_url": null, "state": "accepted", "archived": false, "hash": "4120e7cea1c1868b6944d0a4118387143cc5dbea", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1521/mbox/", "series": [ { "id": 376, "url": "https://patchwork.libcamera.org/api/1.1/series/376/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=376", "date": "2019-06-25T20:27:13", "name": "[libcamera-devel,v2] libcamera: event_dispatcher_poll: Remove struct keyword from for-range", "version": 2, "mbox": "https://patchwork.libcamera.org/series/376/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1521/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1521/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E41E060BC7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2019 22:27:17 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4696F510;\n\tTue, 25 Jun 2019 22:27:17 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561494437;\n\tbh=3pm3qp+3KxledXfjkUzIDAue1Z05DSjBStXh9QxpKYo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=sV0Ypvfe7gDFMQ4BhPQvpONuNhQlfKe2ciTB4s3Zl04ZnwrtrLdwr4oiyYlcEOht6\n\tphNuh0yk/01jyynSRoRDIwBP8LN3EaD8LFQUPAYgE61nuq7YuhVufDz+zrOCQWkriR\n\tsqC92kKNrz5NkuS3GE1/hwFjqT3p26QAZfNUGf2A=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\t\"[autobuild.buildroot.net] Thomas Petazzoni\"\n\t<thomas.petazzoni@bootlin.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Tue, 25 Jun 2019 21:27:13 +0100", "Message-Id": "<20190625202713.10113-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: event_dispatcher_poll:\n\tRemove struct keyword from for-range", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 25 Jun 2019 20:27:18 -0000" }, "content": "When using -std=c++11, GCC versions 6.2 and 6.3 take objection to\ndeclaring a struct type when using a range based iterator:\n\n event_dispatcher_poll.cpp:231:13: error: types may not be defined\n\tin a for-range-declaration [-Werror]\n\n\t\tfor (const struct pollfd &pfd : pollfds) {\n\t\t ^~~~~~\n\n\tcc1plus: all warnings being treated as errors\n\nRemoving the keyword 'struct' ensures that the compiler does not try to\ndeclare the type, and instead uses the type as already defined by the\nrelevant poll.h header.\n\nThis issue does not affect later compiler versions, though earlier\nversions do complain about this keyword if the -std=c++11 option is not\ngiven.\n\nReported-by: [autobuild.buildroot.net] Thomas Petazzoni <thomas.petazzoni@bootlin.com>\n http://autobuild.buildroot.net/results/f6dd4c60c04892c8b1669e6000fce7edb2b6349e/\n\nFixes: 8356f8a6ab87 (\"libcamera: Add a poll-based event dispatcher\")\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/event_dispatcher_poll.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp\nindex 0ff99fce47ab..df9dffb2326c 100644\n--- a/src/libcamera/event_dispatcher_poll.cpp\n+++ b/src/libcamera/event_dispatcher_poll.cpp\n@@ -241,7 +241,7 @@ void EventDispatcherPoll::processNotifiers(const std::vector<struct pollfd> &pol\n \t\t{ EventNotifier::Exception, POLLPRI },\n \t};\n \n-\tfor (const struct pollfd &pfd : pollfds) {\n+\tfor (const pollfd &pfd : pollfds) {\n \t\tauto iter = notifiers_.find(pfd.fd);\n \t\tASSERT(iter != notifiers_.end());\n \n", "prefixes": [ "libcamera-devel", "v2" ] }