Patch Detail
Show a patch.
GET /api/1.1/patches/15191/?format=api
{ "id": 15191, "url": "https://patchwork.libcamera.org/api/1.1/patches/15191/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15191/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211221051023.2628625-3-paul.elder@ideasonboard.com>", "date": "2021-12-21T05:10:22", "name": "[libcamera-devel,v2,2/3] ipa: raspberrypi: Clean up NoiseReductionMode values", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "65b569e317cd53bdf37be07da7966211bdedc7cb", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15191/mbox/", "series": [ { "id": 2852, "url": "https://patchwork.libcamera.org/api/1.1/series/2852/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2852", "date": "2021-12-21T05:10:20", "name": "Noise reduction", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2852/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15191/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15191/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C97AC3258\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Dec 2021 05:10:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 863CA608F9;\n\tTue, 21 Dec 2021 06:10:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EABBB608E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Dec 2021 06:10:36 +0100 (CET)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18355881;\n\tTue, 21 Dec 2021 06:10:35 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"clcqCXcC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640063436;\n\tbh=MxGOIeVSivwDTuR0LVtTL6rvOHsaDNX/QyYay+eNRpw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=clcqCXcCEKTIzkmCDErJ4+Z9ZLx0wkO+KyWE6rybYs+u98tYCZqbL3jBIgfS4v932\n\tsW7vXbgwayjw3Obg2yEjen4mAKgFj4C4H+vh9T+kGhESnx89Pm3elNPCVVREXDGMix\n\t0LyyddHGbabavlYG+s/C50Y3J0N17p5K0DCZgnmU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Dec 2021 23:10:22 -0600", "Message-Id": "<20211221051023.2628625-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20211221051023.2628625-1-paul.elder@ideasonboard.com>", "References": "<20211221051023.2628625-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/3] ipa: raspberrypi: Clean up\n\tNoiseReductionMode values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the NoiseReductionMode values that the raspberrypi IPA does not\nsupport. The ControlInfo values that the IPA reports will be used for\ncapability detection, so values that it does not support shall be\nremoved.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNo change in v2:\n- constexpr did not work\n---\n include/libcamera/ipa/raspberrypi.h | 8 +++++++-\n src/ipa/raspberrypi/raspberrypi.cpp | 2 --\n 2 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex 548bfba0..593139c5 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -18,6 +18,12 @@ namespace libcamera {\n \n namespace RPi {\n \n+const std::array<const ControlValue, 3> RPiNoiseReductionModeValues = {\n+\tstatic_cast<int32_t>(controls::NoiseReductionModeOff),\n+\tstatic_cast<int32_t>(controls::NoiseReductionModeFast),\n+\tstatic_cast<int32_t>(controls::NoiseReductionModeHighQuality),\n+};\n+\n /*\n * List of controls handled by the Raspberry Pi IPA\n *\n@@ -46,7 +52,7 @@ static const ControlInfoMap Controls({\n \t\t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n \t\t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n \t\t{ &controls::FrameDurationLimits, ControlInfo(INT64_C(1000), INT64_C(1000000000)) },\n-\t\t{ &controls::NoiseReductionMode, ControlInfo(controls::NoiseReductionModeValues) }\n+\t\t{ &controls::NoiseReductionMode, ControlInfo(RPiNoiseReductionModeValues) }\n \t}, controls::controls);\n \n } /* namespace RPi */\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 3f497be1..e0685c69 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -618,8 +618,6 @@ static const std::map<int32_t, RPiController::DenoiseMode> DenoiseModeTable = {\n \t{ controls::NoiseReductionModeOff, RPiController::DenoiseMode::Off },\n \t{ controls::NoiseReductionModeFast, RPiController::DenoiseMode::ColourFast },\n \t{ controls::NoiseReductionModeHighQuality, RPiController::DenoiseMode::ColourHighQuality },\n-\t{ controls::NoiseReductionModeRaw, RPiController::DenoiseMode::ColourOff },\n-\t{ controls::NoiseReductionModeZSL, RPiController::DenoiseMode::ColourHighQuality },\n };\n \n void IPARPi::queueRequest(const ControlList &controls)\n", "prefixes": [ "libcamera-devel", "v2", "2/3" ] }