Patch Detail
Show a patch.
GET /api/1.1/patches/15188/?format=api
{ "id": 15188, "url": "https://patchwork.libcamera.org/api/1.1/patches/15188/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15188/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211221045340.2571544-1-paul.elder@ideasonboard.com>", "date": "2021-12-21T04:53:40", "name": "[libcamera-devel,v1] android: Hardcode lens focus range in result metadata", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "7cd2e6d880cfa920647c2501250b49ddcd4a7ae8", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15188/mbox/", "series": [ { "id": 2851, "url": "https://patchwork.libcamera.org/api/1.1/series/2851/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2851", "date": "2021-12-21T04:53:40", "name": "[libcamera-devel,v1] android: Hardcode lens focus range in result metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2851/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15188/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15188/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1502BBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Dec 2021 04:53:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7893F608ED;\n\tTue, 21 Dec 2021 05:53:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3DDB608A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Dec 2021 05:53:51 +0100 (CET)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E503A881;\n\tTue, 21 Dec 2021 05:53:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HXkigEz2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640062431;\n\tbh=OzJ9kMiPcZUKqWtPHenQ1C5kfIu9bcFVKNGJYWKwJXk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=HXkigEz2E8a/gkIStNpqGFEULU0S60s8jT84hMfFxqM+dFpTz5aBQavyfD8gOMMEu\n\tQotrJlnw53iUYgsCwOX/h3i5xouwd2YNiFLjgWFaUmAnMdZ0To4I7WYd0cdNLXG84e\n\tzuu2lbj/ZTwiHHoNe7KckrLesRBxSiuI0vL++drs=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Dec 2021 22:53:40 -0600", "Message-Id": "<20211221045340.2571544-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1] android: Hardcode lens focus range in\n\tresult metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hardcode the lens focus range in result metadata. As our lens focus\ndistance calibration is hardcoded to uncalibrated, and our minimum focus\ndistance is zero, we hardcode the lens focus range to [0, 0].\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_device.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 6c2ea61f..8861447d 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1650,6 +1650,9 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n \t\t\t\t\t testPatternMode);\n \t}\n \n+\tstd::vector<float> focusRange = { 0.0f, 0.0f };\n+\tresultMetadata->addEntry(ANDROID_LENS_FOCUS_RANGE, focusRange);\n+\n \t/*\n \t * Return the result metadata pack even is not valid: get() will return\n \t * nullptr.\n", "prefixes": [ "libcamera-devel", "v1" ] }