Patch Detail
Show a patch.
GET /api/1.1/patches/15177/?format=api
{ "id": 15177, "url": "https://patchwork.libcamera.org/api/1.1/patches/15177/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15177/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211220232629.1485890-7-paul.elder@ideasonboard.com>", "date": "2021-12-20T23:26:29", "name": "[libcamera-devel,v2,6/6] android: Add CONTROL_MODE_OFF in template and static metadata", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "2dffb1eccfc8fe5b85dbffd4239c44d359cb4728", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15177/mbox/", "series": [ { "id": 2848, "url": "https://patchwork.libcamera.org/api/1.1/series/2848/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2848", "date": "2021-12-20T23:26:23", "name": "android: Miscellaneous fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2848/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15177/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15177/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F4B3C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Dec 2021 23:26:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5011608E8;\n\tTue, 21 Dec 2021 00:26:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB7D9608E8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Dec 2021 00:26:51 +0100 (CET)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBF96881;\n\tTue, 21 Dec 2021 00:26:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"noJgvEQW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640042811;\n\tbh=+C/aKL8lVxGRY1vrIaEejDjaGTKhF+Z4JU4WvIiT0Pc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=noJgvEQW38hpHAGKhy0pVziT4a56OzLin92b+5DO0LYpHxtPH2+NHIir4/f3upCku\n\twal9XAwOqsi8iSwI83bmH10DQ6jld5tyr1y7rC42S3pdn9SpN+J+0USzBvmBYCtcff\n\tJZ4vMZ22jHsWTpCF7LxxNHqdSBMpebNxXg8aGc1A=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Dec 2021 17:26:29 -0600", "Message-Id": "<20211220232629.1485890-7-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20211220232629.1485890-1-paul.elder@ideasonboard.com>", "References": "<20211220232629.1485890-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 6/6] android: Add CONTROL_MODE_OFF in\n\ttemplate and static metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add CONTROL_MODE_OFF to the available control modes in static metadata,\nif both AE off and AWB off are available. Also set CONTROL_MODE_OFF in\nthe manual template.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 18 +++++++++++++++++-\n 1 file changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex ea2aaf58..a2e42a5c 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -996,7 +996,17 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n \t\t\t\t awbLockAvailable);\n \n-\tchar availableControlModes = ANDROID_CONTROL_MODE_AUTO;\n+\t/*\n+\t * \\todo Get this from some combination of the available AE and AWB\n+\t * modes\n+\t */\n+\tstd::vector<uint8_t> availableControlModes = { ANDROID_CONTROL_MODE_AUTO };\n+\tif (staticMetadata_->entryContains<uint8_t>(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n+\t\t\t\t\t\t ANDROID_CONTROL_AE_MODE_OFF) &&\n+\t staticMetadata_->entryContains<uint8_t>(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n+\t\t\t\t\t\t ANDROID_CONTROL_AWB_MODE_OFF)) {\n+\t\tavailableControlModes.push_back(ANDROID_CONTROL_MODE_OFF);\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_MODES,\n \t\t\t\t availableControlModes);\n \n@@ -1452,6 +1462,12 @@ std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplateManual() cons\n \tif (!manualTemplate)\n \t\treturn nullptr;\n \n+\tif (staticMetadata_->entryContains<uint8_t>(ANDROID_CONTROL_AVAILABLE_MODES,\n+\t\t\t\t\t\t ANDROID_CONTROL_MODE_OFF)) {\n+\t\tuint8_t mode = ANDROID_CONTROL_MODE_OFF;\n+\t\tmanualTemplate->appendEntry(ANDROID_CONTROL_MODE, mode);\n+\t}\n+\n \treturn manualTemplate;\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "6/6" ] }